[jira] [Updated] (HBASE-4878) Master crash when splitting hlog may cause data loss

[Ted Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4878:
--

Summary: Master crash when splitting hlog may cause data loss  (was: Master 
crash when spliting hlog may cause data loss)

 Master crash when splitting hlog may cause data loss
 

 Key: HBASE-4878
 URL: https://issues.apache.org/jira/browse/HBASE-4878
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.0
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.92.0, 0.94.0

 Attachments: hbase-4878.diff, hbase-4878v2.patch


 Let's see the code of HlogSplitter#splitLog(final FileStatus[] logfiles)
 {code}
 private ListPath splitLog(final FileStatus[] logfiles) throws IOException {
  try {
   for (FileStatus log : logfiles) {
   parseHLog(in, logPath, entryBuffers, fs, conf, skipErrors);
  }
  archiveLogs(srcDir, corruptedLogs, processedLogs, oldLogDir, fs, conf);
  } finally {
   status.setStatus(Finishing writing output logs and closing down.);
   splits = outputSink.finishWritingAndClose();
 }
 }
 {code}
 If master is killed, after finishing archiveLogs(srcDir, corruptedLogs, 
 processedLogs, oldLogDir, fs, conf), 
 but before finishing splits = outputSink.finishWritingAndClose();
 Log date would loss!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4878) Master crash when splitting hlog may cause data loss

[Ted Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4878:
--

  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

 Master crash when splitting hlog may cause data loss
 

 Key: HBASE-4878
 URL: https://issues.apache.org/jira/browse/HBASE-4878
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.0
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.92.0, 0.94.0

 Attachments: hbase-4878.diff, hbase-4878v2.patch


 Let's see the code of HlogSplitter#splitLog(final FileStatus[] logfiles)
 {code}
 private ListPath splitLog(final FileStatus[] logfiles) throws IOException {
  try {
   for (FileStatus log : logfiles) {
   parseHLog(in, logPath, entryBuffers, fs, conf, skipErrors);
  }
  archiveLogs(srcDir, corruptedLogs, processedLogs, oldLogDir, fs, conf);
  } finally {
   status.setStatus(Finishing writing output logs and closing down.);
   splits = outputSink.finishWritingAndClose();
 }
 }
 {code}
 If master is killed, after finishing archiveLogs(srcDir, corruptedLogs, 
 processedLogs, oldLogDir, fs, conf), 
 but before finishing splits = outputSink.finishWritingAndClose();
 Log date would loss!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira