[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5667: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk a while back. > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: Filters >Reporter: David Arthur >Assignee: David Arthur >Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5667: -- Comment: was deleted (was: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520612/HBASE-5667.diff against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.client.TestMetaMigrationRemovingHTD org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.TestMultiVersions org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//console This message is automatically generated.) > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Assignee: David Arthur >Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5667: -- Fix Version/s: 0.96.0 Hadoop Flags: Reviewed > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Assignee: David Arthur >Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated HBASE-5667: Attachment: HBASE-5667.diff Yea on second thought keeping DOTALL is best for compatability. However, I don't like implicit things like that, so I added a comment to the (String) explaining it. > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Priority: Minor > Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated HBASE-5667: Attachment: HBASE-5667.diff * Changed constructor to (String, int) * Added example in docs * Removed DOTALL from (String) constructor > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Priority: Minor > Attachments: HBASE-5667.diff, HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated HBASE-5667: Attachment: HBASE-5667.diff > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Priority: Minor > Attachments: HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated HBASE-5667: Status: Patch Available (was: Open) > RegexStringComparator supports java.util.regex.Pattern flags > > > Key: HBASE-5667 > URL: https://issues.apache.org/jira/browse/HBASE-5667 > Project: HBase > Issue Type: Improvement > Components: filters >Reporter: David Arthur >Priority: Minor > Attachments: HBASE-5667.diff > > > * Add constructor that takes in a Pattern > * Add Pattern's flags to Writable fields, and actually use them when > recomposing the Filter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
