[jira] [Updated] (HBASE-5775) ZKUtil doesn't handle deleteRecurisively cleanly
[ https://issues.apache.org/jira/browse/HBASE-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-5775: - Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to 0.94 and 0.96. > ZKUtil doesn't handle deleteRecurisively cleanly > > > Key: HBASE-5775 > URL: https://issues.apache.org/jira/browse/HBASE-5775 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.94.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Fix For: 0.94.0, 0.96.0 > > Attachments: java_HBASE-5775.patch > > > ZKUtil.deleteNodeRecursively()'s contract says that it handles deletion of > the node and all its children. However, nothing is mentioned as to what > happens if the node you are attempting to delete doesn't actually exist. > Turns out, it throws a null pointer exception. I > 'm proposing that we change the code s.t. it handles the case where the > parent is already gone and exits cleanly, rather than failing horribly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5775) ZKUtil doesn't handle deleteRecurisively cleanly
[ https://issues.apache.org/jira/browse/HBASE-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5775: - Status: Patch Available (was: Open) +1 on patch > ZKUtil doesn't handle deleteRecurisively cleanly > > > Key: HBASE-5775 > URL: https://issues.apache.org/jira/browse/HBASE-5775 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.94.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Fix For: 0.94.0, 0.96.0 > > Attachments: java_HBASE-5775.patch > > > ZKUtil.deleteNodeRecursively()'s contract says that it handles deletion of > the node and all its children. However, nothing is mentioned as to what > happens if the node you are attempting to delete doesn't actually exist. > Turns out, it throws a null pointer exception. I > 'm proposing that we change the code s.t. it handles the case where the > parent is already gone and exits cleanly, rather than failing horribly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5775) ZKUtil doesn't handle deleteRecurisively cleanly
[ https://issues.apache.org/jira/browse/HBASE-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse Yates updated HBASE-5775: --- Attachment: java_HBASE-5775.patch Attaching patch. Simple one line fix and updating associated test. > ZKUtil doesn't handle deleteRecurisively cleanly > > > Key: HBASE-5775 > URL: https://issues.apache.org/jira/browse/HBASE-5775 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.94.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Fix For: 0.94.0, 0.96.0 > > Attachments: java_HBASE-5775.patch > > > ZKUtil.deleteNodeRecursively()'s contract says that it handles deletion of > the node and all its children. However, nothing is mentioned as to what > happens if the node you are attempting to delete doesn't actually exist. > Turns out, it throws a null pointer exception. I > 'm proposing that we change the code s.t. it handles the case where the > parent is already gone and exits cleanly, rather than failing horribly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira