[ 
https://issues.apache.org/jira/browse/HIVE-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702016#comment-15702016
 ] 

Jesus Camacho Rodriguez edited comment on HIVE-15273 at 11/28/16 2:01 PM:
--------------------------------------------------------------------------

[~bslim], I have just checked the patch and overall looks good.

In addition to addressing [~leftylev]'s comments, could you remove the 
initialization for _numConnection_ and _readTimeout_ with hardcoded values in 
DruidSerDe? Since we will pass through the _initialization_ method and default 
values already exist in HiveConf.java, we do not need to hardcode the value for 
these properties. Thanks


was (Author: jcamachorodriguez):
[~bslim], I have just checked the patch and overall looks good.

In addition to addressing [~leftylev]'s comments, could you remove the 
initialization for _ numConnection_ and _readTimeout_ with hardcoded values in 
DruidSerDe? Since we will pass through the _initialization_ method and default 
values already exist in HiveConf.java, we do not need to hardcode the value for 
these properties. Thanks

> Http Client not configured correctly
> ------------------------------------
>
>                 Key: HIVE-15273
>                 URL: https://issues.apache.org/jira/browse/HIVE-15273
>             Project: Hive
>          Issue Type: Bug
>          Components: Druid integration
>            Reporter: slim bouguerra
>            Assignee: slim bouguerra
>            Priority: Minor
>         Attachments: 0001-adding-confing-to-http-client.patch
>
>
> Current used http client by the druid-hive record reader is constructed with 
> default values. Default values of numConnection and ReadTimeout are very 
> small which can lead to following exception " ERROR 
> [2ee34a2b-c8a5-4748-ab91-db3621d2aa5c main] CliDriver: Failed with exception 
> java.io.IOException:java.io.IOException: java.io.IOException: org.apache.h
> ive.druid.org.jboss.netty.channel.ChannelException: Channel disconnected"
> Full stack can be found 
> here.https://gist.github.com/b-slim/384ca6a96698f5b51ad9b171cff556a2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to