[ 
https://issues.apache.org/jira/browse/HIVE-19661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494045#comment-16494045
 ] 

Sergey Shelukhin edited comment on HIVE-19661 at 5/29/18 6:45 PM:
------------------------------------------------------------------

1) Is context needed in the UDF object other than to get the config? Perhaps 
the boolean can just be set inside "configure".
2) Re2J license needs to be added to the file with other licenses to LICENSE 
file.
3) Also build appears to have failed. Looks like HiveConf changes are missing 
from the patch file.

cc [~ashutoshc] since it needs new dependency, I wonder if we need more than 
one +1


was (Author: sershe):
1) Is context needed in the UDF object other than to get the config? Perhaps 
the boolean can just be set inside "configure".
2) Re2J license needs to be added to the file with other licenses to LICENSE 
file.
3) Also build appears to have failed. Looks like HiveConf changes are missing 
from the patch file.

cc [~ashutoshc] since it needs new dependency, maybe 

> switch Hive UDFs to use Re2J regex engine
> -----------------------------------------
>
>                 Key: HIVE-19661
>                 URL: https://issues.apache.org/jira/browse/HIVE-19661
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Rajkumar Singh
>            Assignee: Rajkumar Singh
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-19661.patch
>
>
> Java regex engine can be very slow in some cases e.g. 
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8203458



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to