[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903844#comment-14903844
]
Yongzhi Chen commented on HIVE-11217:
-
Thanks [~prasanth_j] for reviewing the patch.
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903612#comment-14903612
]
Prasanth Jayachandran commented on HIVE-11217:
--
Sure. Not a problem. +1. Sorr
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903588#comment-14903588
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], when I try to improve the perfor
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903424#comment-14903424
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], the place that I put the code to
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903372#comment-14903372
]
Prasanth Jayachandran commented on HIVE-11217:
--
[~ychena] Thanks for the expl
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902595#comment-14902595
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], Thanks for review the change.
I
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901963#comment-14901963
]
Prasanth Jayachandran commented on HIVE-11217:
--
[~ychena] SemanticAnalyzer in
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877341#comment-14877341
]
Yongzhi Chen commented on HIVE-11217:
-
The four failures are not related.
org.apache.
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877177#comment-14877177
]
Hive QA commented on HIVE-11217:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876635#comment-14876635
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], I do not quite understand why it
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876026#comment-14876026
]
Prasanth Jayachandran commented on HIVE-11217:
--
[~ychena] Yes. IMO, that's th
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875738#comment-14875738
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], you make a very good point.
Do
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804973#comment-14804973
]
Prasanth Jayachandran commented on HIVE-11217:
--
I tried the following
{code:
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804929#comment-14804929
]
Hive QA commented on HIVE-11217:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804809#comment-14804809
]
Yongzhi Chen commented on HIVE-11217:
-
For the LazySimpleSerDe already supports void,
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804516#comment-14804516
]
Prasanth Jayachandran commented on HIVE-11217:
--
Agreed with your initial comm
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804476#comment-14804476
]
Ashutosh Chauhan commented on HIVE-11217:
-
I am still not convinced that silently
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803001#comment-14803001
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], changes in TypeCheckProcFactory
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791546#comment-14791546
]
Prasanth Jayachandran commented on HIVE-11217:
--
[~ychena] My suggestion is to
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791534#comment-14791534
]
Yongzhi Chen commented on HIVE-11217:
-
Very recent changes in master affect the output
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791491#comment-14791491
]
Hive QA commented on HIVE-11217:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790570#comment-14790570
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], I can not find a proper place in
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743833#comment-14743833
]
Prasanth Jayachandran commented on HIVE-11217:
--
[~ychena] Sorry I didn't look
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743548#comment-14743548
]
Yongzhi Chen commented on HIVE-11217:
-
[~prasanth_j], The first patch of this jira is
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720391#comment-14720391
]
Prasanth Jayachandran commented on HIVE-11217:
--
For insert queries hive maps
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720387#comment-14720387
]
Prasanth Jayachandran commented on HIVE-11217:
--
OrcProto is generated file an
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708894#comment-14708894
]
Ashutosh Chauhan commented on HIVE-11217:
-
Patch seems reasonable to me. [~prasant
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642933#comment-14642933
]
Aihua Xu commented on HIVE-11217:
-
[~ychena] This change seems reasonable to let ORC be co
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634244#comment-14634244
]
Yongzhi Chen commented on HIVE-11217:
-
[~spena] and [~ctang.ma], could you review the
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634075#comment-14634075
]
Hive QA commented on HIVE-11217:
{color:green}Overall{color}: +1 all checks pass
Here a
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633896#comment-14633896
]
Yongzhi Chen commented on HIVE-11217:
-
On second thought, maybe we should choose optio
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625798#comment-14625798
]
Yongzhi Chen commented on HIVE-11217:
-
Without the patch, for query create table t2 as
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625747#comment-14625747
]
Hive QA commented on HIVE-11217:
{color:green}Overall{color}: +1 all checks pass
Here a
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625635#comment-14625635
]
Ashutosh Chauhan commented on HIVE-11217:
-
I am not sure implicitly assuming strin
[
https://issues.apache.org/jira/browse/HIVE-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625508#comment-14625508
]
Yongzhi Chen commented on HIVE-11217:
-
Fixing it by change void type in the field sche
35 matches
Mail list logo