[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961432#comment-14961432
]
Thejas M Nair commented on HIVE-12083:
--
+1
> HIVE-10965 introduces thrift error if partNames or
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961662#comment-14961662
]
Sushanth Sowmyan commented on HIVE-12083:
-
Thanks, Thejas!
Committed to branch-1, branch-1.2 and
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957767#comment-14957767
]
Sushanth Sowmyan commented on HIVE-12083:
-
[~thejas]/[~ashutoshc], can I bug either of you for a
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955751#comment-14955751
]
Hive QA commented on HIVE-12083:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953421#comment-14953421
]
Sushanth Sowmyan commented on HIVE-12083:
-
> Should we short circuit for empty partitions case as
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953504#comment-14953504
]
Sushanth Sowmyan commented on HIVE-12083:
-
Spoke to ashutosh about this - going to make one more
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952260#comment-14952260
]
Hive QA commented on HIVE-12083:
{color:red}Overall{color}: -1 at least one tests failed
Here are the
[
https://issues.apache.org/jira/browse/HIVE-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952481#comment-14952481
]
Thejas M Nair commented on HIVE-12083:
--
The patch looks good to me. Thanks for adding the tests! +1