[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-12-04 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041265#comment-15041265 ] Lefty Leverenz commented on HIVE-12182: --- Thanks [~ngangam]. > ALTER TABLE PARTITION COLUMN does not

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-12-02 Thread Naveen Gangam (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035799#comment-15035799 ] Naveen Gangam commented on HIVE-12182: -- [~leftylev] There is no syntax change with this fix. So I

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-12-01 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034865#comment-15034865 ] Lefty Leverenz commented on HIVE-12182: --- Did this make any syntax changes? If so, it needs a

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-12-01 Thread Naveen Gangam (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033914#comment-15033914 ] Naveen Gangam commented on HIVE-12182: -- Yongzhi, Thank you for the review and committing this. >

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-28 Thread Naveen Gangam (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030671#comment-15030671 ] Naveen Gangam commented on HIVE-12182: -- The test failures seem un-related to the change. > ALTER

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-28 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030821#comment-15030821 ] Yongzhi Chen commented on HIVE-12182: - +1 > ALTER TABLE PARTITION COLUMN does not set partition

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029436#comment-15029436 ] Hive QA commented on HIVE-12182: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-09 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996795#comment-14996795 ] Yongzhi Chen commented on HIVE-12182: - [~ngangam], you may need rebase your change. > ALTER TABLE

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994952#comment-14994952 ] Hive QA commented on HIVE-12182: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-03 Thread Naveen Gangam (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987892#comment-14987892 ] Naveen Gangam commented on HIVE-12182: -- Good point. I believe it should to prevent is from including

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-03 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987780#comment-14987780 ] Yongzhi Chen commented on HIVE-12182: - [~ngangam], could you add unit test to catch regression in the

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-03 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987831#comment-14987831 ] Yongzhi Chen commented on HIVE-12182: - Following is from BaseSemanticAnalyzer.java Should this patch

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-03 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988071#comment-14988071 ] Yongzhi Chen commented on HIVE-12182: - I think it is useful to handle the special charactors which

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-11-02 Thread Naveen Gangam (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986169#comment-14986169 ] Naveen Gangam commented on HIVE-12182: -- The test failures do not appear to be related to the patch.

[jira] [Commented] (HIVE-12182) ALTER TABLE PARTITION COLUMN does not set partition column comments

2015-10-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983096#comment-14983096 ] Hive QA commented on HIVE-12182: Here are the results of testing the latest attachment: