[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-11-12 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003277#comment-15003277 ] Jimmy Xiang commented on HIVE-12187: This is an enhancement. The backport is not clean. It is safer

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-11-12 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003306#comment-15003306 ] Sergey Shelukhin commented on HIVE-12187: - Thanks! > Release plan once a query is executed >

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-22 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969876#comment-14969876 ] Jimmy Xiang commented on HIVE-12187: The unit test failures are not related. I am going to commit this

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-22 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969812#comment-14969812 ] Chaoyu Tang commented on HIVE-12187: [~jxiang] The patch looks good to me, except I am not quite sure

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-22 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969830#comment-14969830 ] Jimmy Xiang commented on HIVE-12187: [~ctang.ma], thanks a lot for the review. For the locks related

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-22 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969397#comment-14969397 ] Jimmy Xiang commented on HIVE-12187: The locks are not released at close(). It is usually released

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-22 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969338#comment-14969338 ] Chaoyu Tang commented on HIVE-12187: [~jxiang] I wonder why you save the locks, if any, in the close()

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-21 Thread Alan Gates (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967791#comment-14967791 ] Alan Gates commented on HIVE-12187: --- The change looks good to me from a locks perspective. [~ekoifman]

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-21 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968114#comment-14968114 ] Jimmy Xiang commented on HIVE-12187: The change to the locks is to avoid some lock leakage actually.

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-21 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968088#comment-14968088 ] Eugene Koifman commented on HIVE-12187: --- [~jxiang], could you elaborate a little on what the intent

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-20 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965677#comment-14965677 ] Jimmy Xiang commented on HIVE-12187: Discussed patch v1 with Xuefu. Patch v2 also simplified the code

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-20 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965903#comment-14965903 ] Jimmy Xiang commented on HIVE-12187: [~alangates], patch v2 touched the HiveLocks a little. When

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965938#comment-14965938 ] Hive QA commented on HIVE-12187: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12187) Release plan once a query is executed

2015-10-16 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961544#comment-14961544 ] Hive QA commented on HIVE-12187: Here are the results of testing the latest attachment: