[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649547#comment-16649547
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Actually can you commit the patch for me? I have
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649456#comment-16649456
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Do you know what mvninstall does?
> Improve logging with
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648311#comment-16648311
]
Peter Vary commented on HIVE-12254:
---
That's a win!
[~aihuaxu]: You commit or shall I? :)
> Improve
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648093#comment-16648093
]
Hive QA commented on HIVE-12254:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648074#comment-16648074
]
Hive QA commented on HIVE-12254:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645161#comment-16645161
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Thanks for +1. I will get a green run before commit.
>
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645051#comment-16645051
]
Peter Vary commented on HIVE-12254:
---
+1 from me if we can get a green run
AFAIK we still have the
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643950#comment-16643950
]
Yongzhi Chen commented on HIVE-12254:
-
[~aihuaxu], did you check the mvninstall failure ?
> Improve
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643740#comment-16643740
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] and [~ychena] Can you help review the latest patch?
>
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639082#comment-16639082
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Can you take a look at the latest patch? The test failure is
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638536#comment-16638536
]
Hive QA commented on HIVE-12254:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638470#comment-16638470
]
Hive QA commented on HIVE-12254:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636506#comment-16636506
]
Hive QA commented on HIVE-12254:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636489#comment-16636489
]
Hive QA commented on HIVE-12254:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635830#comment-16635830
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Actually the test case doesn't mock returning queryState so
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635344#comment-16635344
]
Peter Vary commented on HIVE-12254:
---
TestCliDriverMethods failures seems related. We might want to
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635225#comment-16635225
]
Hive QA commented on HIVE-12254:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635183#comment-16635183
]
Hive QA commented on HIVE-12254:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634334#comment-16634334
]
Aihua Xu commented on HIVE-12254:
-
[~pvary] Thanks for reviewing the patch.
* Such CallerContext is a
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634066#comment-16634066
]
Peter Vary commented on HIVE-12254:
---
[~aihuaxu]: 3 quick questions:
* What happens when multiple
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632976#comment-16632976
]
Hive QA commented on HIVE-12254:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632964#comment-16632964
]
Hive QA commented on HIVE-12254:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632576#comment-16632576
]
Aihua Xu commented on HIVE-12254:
-
[~sershe], [~pvary], [~ychena] can you help review the code?
>
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631037#comment-16631037
]
Aihua Xu commented on HIVE-12254:
-
Thanks [~sershe]
> Improve logging with yarn/hdfs
>
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631026#comment-16631026
]
Sergey Shelukhin commented on HIVE-12254:
-
Nobody is currently looking at it. Feel free to take
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631021#comment-16631021
]
Aihua Xu commented on HIVE-12254:
-
[~vikram.dixit] and [~sershe] Do you plan to include this change? It's
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259108#comment-15259108
]
Sergey Shelukhin commented on HIVE-12254:
-
+1 conditional on also including the fix for HIVE-13408
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139912#comment-15139912
]
Sergey Shelukhin commented on HIVE-12254:
-
{noformat}
+String logPrefix =
[
https://issues.apache.org/jira/browse/HIVE-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972145#comment-14972145
]
Sergey Shelukhin commented on HIVE-12254:
-
+1
> Improve logging with yarn/hdfs
>
29 matches
Mail list logo
