[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982752#comment-14982752
]
Hive QA commented on HIVE-12281:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977912#comment-14977912
]
Matt McCline commented on HIVE-12281:
-
+1 LGTM
> Vectorized MapJoin - use Operator::isLogDebugEnabled
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978915#comment-14978915
]
Ashutosh Chauhan commented on HIVE-12281:
-
isLogEnabled() is an anti-pattern. Its actually slower
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978927#comment-14978927
]
Sergey Shelukhin commented on HIVE-12281:
-
The logging call itself is expensive, at least before
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978907#comment-14978907
]
Gopal V commented on HIVE-12281:
There's an HTTP UI interface in LLAP which lets you turn on logging for a
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978895#comment-14978895
]
Sergey Shelukhin commented on HIVE-12281:
-
Any reason to not have isLogDebugEnabled static, since
[
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979767#comment-14979767
]
Hive QA commented on HIVE-12281:
Here are the results of testing the latest attachment:
