[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018504#comment-15018504
]
Sergey Shelukhin commented on HIVE-12319:
-
This patch has broken MiniLlap test - it has failed in
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018700#comment-15018700
]
Aleksei Statkevich commented on HIVE-12319:
---
Filed a jira HIVE-12487 and suggested a fix there.
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018931#comment-15018931
]
Ashutosh Chauhan commented on HIVE-12319:
-
[~sershe] I am not able to repro this on fresh master.
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018992#comment-15018992
]
Sergey Shelukhin commented on HIVE-12319:
-
The tests didn't run at all, this for some reason
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010136#comment-15010136
]
Aleksei Statkevich commented on HIVE-12319:
---
[~ashutoshc], here's the review link:
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009625#comment-15009625
]
Ashutosh Chauhan commented on HIVE-12319:
-
[~Aleksei] Can you create a RB entry for this?
>
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010322#comment-15010322
]
Ashutosh Chauhan commented on HIVE-12319:
-
+1
> Remove HadoopShims::getHadoopConfNames()
>
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006350#comment-15006350
]
Hive QA commented on HIVE-12319:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004149#comment-15004149
]
Ashutosh Chauhan commented on HIVE-12319:
-
I dont see much value of keeping them in HiveConf.
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004361#comment-15004361
]
Aleksei Statkevich commented on HIVE-12319:
---
Before the change these config names with default
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004609#comment-15004609
]
Hive QA commented on HIVE-12319:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1500#comment-1500
]
Ashutosh Chauhan commented on HIVE-12319:
-
yes.
e.g., we should directly reference
[
https://issues.apache.org/jira/browse/HIVE-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005155#comment-15005155
]
Aleksei Statkevich commented on HIVE-12319:
---
Makes sense. I'll make this change.
> Remove
13 matches
Mail list logo