[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-04 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042283#comment-15042283 ] Jimmy Xiang commented on HIVE-12574: Chatted with Aihua on this patch. Looks good to me. +1 >

[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-04 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042155#comment-15042155 ] Aihua Xu commented on HIVE-12574: - [~rhbutani] or [~navis], can you help review the code? > windowing

[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-03 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037992#comment-15037992 ] Aihua Xu commented on HIVE-12574: - Patch#2: include the fix for count() and collect_set(). We need to

[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-03 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038356#comment-15038356 ] Sergey Shelukhin commented on HIVE-12574: - [~rhbutani] might be the best person to review this. >

[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039540#comment-15039540 ] Hive QA commented on HIVE-12574: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12574) windowing function returns incorrect result when the window size is larger than the partition size

2015-12-02 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036838#comment-15036838 ] Aihua Xu commented on HIVE-12574: - Initial patch: add the check if the result is ready to output. >