[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207312#comment-15207312
]
Vikram Dixit K commented on HIVE-13286:
---
Committed to both master and branch-2.0. Thanks [~aihuaxu]!
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207015#comment-15207015
]
Aihua Xu commented on HIVE-13286:
-
[~vikram.dixit] Those tests are not related. Sorry. Forgot to mention
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206870#comment-15206870
]
Vikram Dixit K commented on HIVE-13286:
---
[~aihuaxu] Are the test failures related? Otherwise let me
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205308#comment-15205308
]
Vikram Dixit K commented on HIVE-13286:
---
I tested the latest patch. It works as expected. +1
>
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205076#comment-15205076
]
Aihua Xu commented on HIVE-13286:
-
[~vikram.dixit] How is the new patch? Can you take a look?
> Query ID
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200688#comment-15200688
]
Aihua Xu commented on HIVE-13286:
-
Let me take a look at CLI cases.
> Query ID is being reused across
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199635#comment-15199635
]
Hive QA commented on HIVE-13286:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200729#comment-15200729
]
Vikram Dixit K commented on HIVE-13286:
---
Yeah. In one of the cli tests, I just added this:
set
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197821#comment-15197821
]
Vikram Dixit K commented on HIVE-13286:
---
It looks good to me. I ran a local test for the same. +1
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200337#comment-15200337
]
Vikram Dixit K commented on HIVE-13286:
---
Actually this is what you need:
{code}
diff --git
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200051#comment-15200051
]
Aihua Xu commented on HIVE-13286:
-
Attached patch-2: fix the unit test.
> Query ID is being reused across
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200317#comment-15200317
]
Vikram Dixit K commented on HIVE-13286:
---
[~aihuaxu] I think the bug still exists here. I see that
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196271#comment-15196271
]
Aihua Xu commented on HIVE-13286:
-
Attached the patch-1: disallow the input of the queryId. queryId will
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196105#comment-15196105
]
Vikram Dixit K commented on HIVE-13286:
---
Great! Thanks!
> Query ID is being reused across queries
>
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196100#comment-15196100
]
Vikram Dixit K commented on HIVE-13286:
---
Yeah. The same queryId causes issues. We should disallow a
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196097#comment-15196097
]
Aihua Xu commented on HIVE-13286:
-
I see. I will disallow the input of queryId and generate a new one
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196054#comment-15196054
]
Aihua Xu commented on HIVE-13286:
-
I moved to initialize the queryId earlier so that starting from the
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196044#comment-15196044
]
Vikram Dixit K commented on HIVE-13286:
---
[~aihuaxu] Consider the following scenario: In Tez/Spark,
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195987#comment-15195987
]
Aihua Xu commented on HIVE-13286:
-
Actually what I need is the unique queryId. Think of the scenario that
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195836#comment-15195836
]
Vikram Dixit K commented on HIVE-13286:
---
The issue here is that if we make a change in the incoming
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195815#comment-15195815
]
Aihua Xu commented on HIVE-13286:
-
OK. I think there is an issue there. confOverlay is passed from the
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195794#comment-15195794
]
Aihua Xu commented on HIVE-13286:
-
QueryId should be unique. The user overwritten queryId is for the user
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195761#comment-15195761
]
Siddharth Seth commented on HIVE-13286:
---
[~aihuaxu] - I'm curious as to why we allow the queryId to
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195298#comment-15195298
]
Aihua Xu commented on HIVE-13286:
-
OK. We had a followup to fix HIVE-12456 to avoid storing queryId in
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195278#comment-15195278
]
Aihua Xu commented on HIVE-13286:
-
[~vikram.dixit] This is to check if we provide queryId from the client.
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194593#comment-15194593
]
Aihua Xu commented on HIVE-13286:
-
I will take a look. That seems to be an issue and not my intention.
[
https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194509#comment-15194509
]
Vikram Dixit K commented on HIVE-13286:
---
I think it primarily comes down to this: the hive conf
27 matches
Mail list logo
