[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239166#comment-15239166
]
Aihua Xu commented on HIVE-13410:
-
+1. The patch looks good.
> PerfLog metrics scopes not closed if there
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238646#comment-15238646
]
Szehon Ho commented on HIVE-13410:
--
Finally the flaky tests are fixed. [~aihuaxu] can you please review
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238617#comment-15238617
]
Hive QA commented on HIVE-13410:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234455#comment-15234455
]
Hive QA commented on HIVE-13410:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226187#comment-15226187
]
Hive QA commented on HIVE-13410:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223612#comment-15223612
]
Hive QA commented on HIVE-13410:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223046#comment-15223046
]
Aihua Xu commented on HIVE-13410:
-
The perflogger is per session and we are not tracking for each query,
[
https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222890#comment-15222890
]
Aihua Xu commented on HIVE-13410:
-
[~szehon] The code looks good. Question about the unit tests: seems we
