[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341368#comment-15341368
]
Lefty Leverenz commented on HIVE-13490:
---
Okay, although I'd prefer making it clearer instead of
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340368#comment-15340368
]
Zoltan Haindrich commented on HIVE-13490:
-
This whole sentence was confusing
I just wanted to
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339193#comment-15339193
]
Lefty Leverenz commented on HIVE-13490:
---
[~kgyrtkirk], in the docs there's one sentence I don't
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339170#comment-15339170
]
Lefty Leverenz commented on HIVE-13490:
---
These are the sections:
* [FAQ-How do I import into
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313135#comment-15313135
]
Zoltan Haindrich commented on HIVE-13490:
-
i've added some documentation about it to
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311280#comment-15311280
]
Zoltan Haindrich commented on HIVE-13490:
-
i'll do it...when i will have permission to edit ;)
>
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308832#comment-15308832
]
Siddharth Seth commented on HIVE-13490:
---
Would be good to modify
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308526#comment-15308526
]
Sergio Peña commented on HIVE-13490:
+1 Patch looks good.
> Change itests to be part of the main Hive
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308492#comment-15308492
]
Ashutosh Chauhan commented on HIVE-13490:
-
+1 LGTM
> Change itests to be part of the main Hive
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305073#comment-15305073
]
Siddharth Seth commented on HIVE-13490:
---
This looks good to me, at least to enable better itests
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300912#comment-15300912
]
Siddharth Seth commented on HIVE-13490:
---
Changed the owner. You should be able to change it as well
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300401#comment-15300401
]
Zoltan Haindrich commented on HIVE-13490:
-
i'm using the profile based patch locally - and it
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300316#comment-15300316
]
Jesus Camacho Rodriguez commented on HIVE-13490:
Removing 2.1.0 target. Please feel free
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298286#comment-15298286
]
Sergio Peña commented on HIVE-13490:
I like the use of a profile to invoke integration tests. We can
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297156#comment-15297156
]
Siddharth Seth commented on HIVE-13490:
---
[~kgyrtkirk] - I'd be in favour of the second approach,
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274166#comment-15274166
]
Sergio Peña commented on HIVE-13490:
[~kgyrtkirk] Your changes may work great for this :)
I'd like to
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274131#comment-15274131
]
Zoltan Haindrich commented on HIVE-13490:
-
i've played with this a bit...I just want to add the
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270579#comment-15270579
]
Ashutosh Chauhan commented on HIVE-13490:
-
[~kgyrtkirk] There definitely is interest in having
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269430#comment-15269430
]
Zoltan Haindrich commented on HIVE-13490:
-
I've also attached the itests to my top level project;
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251435#comment-15251435
]
Siddharth Seth commented on HIVE-13490:
---
OK. That helps me understand why these have been kept
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250537#comment-15250537
]
Sergio Peña commented on HIVE-13490:
I think "itests" should be kept separately from the root project
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250100#comment-15250100
]
Ashutosh Chauhan commented on HIVE-13490:
-
+1
> Change itests to be part of the main Hive build
>
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244476#comment-15244476
]
Hive QA commented on HIVE-13490:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242574#comment-15242574
]
Siddharth Seth commented on HIVE-13490:
---
Thanks for the pointer [~ashutoshc]. From the thread, I'm
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241633#comment-15241633
]
Ashutosh Chauhan commented on HIVE-13490:
-
I think it will be good to run tests with failsafe
[
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241609#comment-15241609
]
Ashutosh Chauhan commented on HIVE-13490:
-
There has been some discussion on list on why it was
26 matches
Mail list logo
