[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346245#comment-15346245
]
Matt McCline commented on HIVE-13872:
-
Committed to master.
> Vectorization: Fix cross-product reduce
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346244#comment-15346244
]
Matt McCline commented on HIVE-13872:
-
Ran internal PTest on patch #5. No related failures.
>
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345690#comment-15345690
]
Matt McCline commented on HIVE-13872:
-
Thank you Gopal for the review!
> Vectorization: Fix
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345439#comment-15345439
]
Gopal V commented on HIVE-13872:
LGTM - +1.
minor nit
{code}
+ColumnVector colVector =
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345382#comment-15345382
]
Matt McCline commented on HIVE-13872:
-
Failures look unrelated.
> Vectorization: Fix cross-product
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344791#comment-15344791
]
Hive QA commented on HIVE-13872:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343018#comment-15343018
]
Matt McCline commented on HIVE-13872:
-
I looked at
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343020#comment-15343020
]
Matt McCline commented on HIVE-13872:
-
Thanks for checking the patch out.
> Vectorization: Fix
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343014#comment-15343014
]
Gopal V commented on HIVE-13872:
[~mmccline]: I don't see a test run for 03.patch??
My build went
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343009#comment-15343009
]
Matt McCline commented on HIVE-13872:
-
Nonsense errors in console output for build of patch #3.
>
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339934#comment-15339934
]
Hive QA commented on HIVE-13872:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338944#comment-15338944
]
Hive QA commented on HIVE-13872:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338394#comment-15338394
]
Gopal V commented on HIVE-13872:
This is failing in my LLAP instances running with the latest master.
{{
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338285#comment-15338285
]
Matt McCline commented on HIVE-13872:
-
Updated with Tex Q out file and Q that does drive the
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338251#comment-15338251
]
Matt McCline commented on HIVE-13872:
-
I wonder if it is as simple as the first table doesn't have any
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337820#comment-15337820
]
Matt McCline commented on HIVE-13872:
-
[~gopalv] I'm trying to get a repro for the "RuntimeException:
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308356#comment-15308356
]
Jesus Camacho Rodriguez commented on HIVE-13872:
Removing 2.1.0 target as issue is not
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304019#comment-15304019
]
Gopal V commented on HIVE-13872:
Is worse than I expected - the configuration objects do not have the
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303972#comment-15303972
]
Gopal V commented on HIVE-13872:
After a quick night of debugging, the columnsToIncludeTruncated shows up
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303866#comment-15303866
]
Gopal V commented on HIVE-13872:
Thanks [~mmccline], will check whether it's getting lost as a transient
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303858#comment-15303858
]
Matt McCline commented on HIVE-13872:
-
LazySimpleDeserializeRead.readCheckNull does use a
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303842#comment-15303842
]
Gopal V commented on HIVE-13872:
Indirectly, this means that non-projected columns from TEXT are actually
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303808#comment-15303808
]
Gopal V commented on HIVE-13872:
The patch clearly breaks TEXT vectorization, which relies on this column
[
https://issues.apache.org/jira/browse/HIVE-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303480#comment-15303480
]
Gopal V commented on HIVE-13872:
AFAIK, the issue is that the column pruner removes the nearly all columns
24 matches
Mail list logo
