[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386854#comment-15386854
]
Siddharth Seth commented on HIVE-14224:
---
Thanks for the reviews. Committing. The test failures are
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386844#comment-15386844
]
Prasanth Jayachandran commented on HIVE-14224:
--
changes lgtm, +1
> LLAP rename query
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386682#comment-15386682
]
Prasanth Jayachandran commented on HIVE-14224:
--
Unchecked cast to RandomAccessFileAppender. I
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384575#comment-15384575
]
Hive QA commented on HIVE-14224:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383533#comment-15383533
]
Hive QA commented on HIVE-14224:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383122#comment-15383122
]
Prasanth Jayachandran commented on HIVE-14224:
--
+1. I think we should get rid of dagId based
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381076#comment-15381076
]
Hive QA commented on HIVE-14224:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380393#comment-15380393
]
Siddharth Seth commented on HIVE-14224:
---
Have to check whether any of the other log4j2 config files
[
https://issues.apache.org/jira/browse/HIVE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380390#comment-15380390
]
Prasanth Jayachandran commented on HIVE-14224:
--
Left some comments in RB
> LLAP rename query