[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-23 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516992#comment-15516992 ] Illya Yalovyy commented on HIVE-14713: -- Thank you! > LDAP Authentication Provider sh

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514737#comment-15514737 ] Szehon Ho commented on HIVE-14713: -- I think there is a 24 hour wait after the last +1 to

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514582#comment-15514582 ] Illya Yalovyy commented on HIVE-14713: -- [~szehon], [~ctang.ma], The CR got a "ship it

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514347#comment-15514347 ] Chaoyu Tang commented on HIVE-14713: LGTM, +1 > LDAP Authentication Provider should

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514199#comment-15514199 ] Hive QA commented on HIVE-14713: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513975#comment-15513975 ] Illya Yalovyy commented on HIVE-14713: -- The patch was updated with minor performance

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507799#comment-15507799 ] Hive QA commented on HIVE-14713: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507583#comment-15507583 ] Illya Yalovyy commented on HIVE-14713: -- I have updated Patch and CR with a fixed vers

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-16 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497940#comment-15497940 ] Chaoyu Tang commented on HIVE-14713: [~yalovyyi] I left some comments on RB. > LDAP

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-07 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471595#comment-15471595 ] Illya Yalovyy commented on HIVE-14713: -- None of failed tests look relevant. According

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-07 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471594#comment-15471594 ] Illya Yalovyy commented on HIVE-14713: -- None of failed tests look relevant. According

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470955#comment-15470955 ] Hive QA commented on HIVE-14713: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests

2016-09-07 Thread Illya Yalovyy (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470777#comment-15470777 ] Illya Yalovyy commented on HIVE-14713: -- CR: https://reviews.apache.org/r/51694/ > L