[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833829#comment-15833829
]
Rui Li commented on HIVE-15519:
---
Committed to master and branch-1.
Thanks Thejas for the review!
> BitSet
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833819#comment-15833819
]
Rui Li commented on HIVE-15519:
---
[~thejas], thanks for reviewing and the suggestion. I have locally run
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832098#comment-15832098
]
Thejas M Nair commented on HIVE-15519:
--
+1 to the v6 patch.
For branch-1, it looks like that test
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831399#comment-15831399
]
Rui Li commented on HIVE-15519:
---
The last test is for v5 patch for branch-1. I tried some of the failures
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829246#comment-15829246
]
Hive QA commented on HIVE-15519:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829151#comment-15829151
]
Rui Li commented on HIVE-15519:
---
Hi [~thejas], could you have a look at the latest patches? FYI v6 is for
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828082#comment-15828082
]
Rui Li commented on HIVE-15519:
---
The last test is for v6 patch. The patch is also in RB. Test failures with
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828017#comment-15828017
]
Hive QA commented on HIVE-15519:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819231#comment-15819231
]
Hive QA commented on HIVE-15519:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818525#comment-15818525
]
Rui Li commented on HIVE-15519:
---
Just realised we already have a UT for ColumnBuffer named TestColumn. I'll
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817679#comment-15817679
]
Rui Li commented on HIVE-15519:
---
I tried the failures with age 1 and they can't be reproduced.
> BitSet not
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817574#comment-15817574
]
Hive QA commented on HIVE-15519:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817071#comment-15817071
]
Thejas M Nair commented on HIVE-15519:
--
+1 pending test verification
> BitSet not computed properly
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816955#comment-15816955
]
Rui Li commented on HIVE-15519:
---
[~thejas], thanks for reviewing. I've updated patch to address your
[
https://issues.apache.org/jira/browse/HIVE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816040#comment-15816040
]
Thejas M Nair commented on HIVE-15519:
--
[~lirui]
Sorry about the delay.
The change looks good. Can
15 matches
Mail list logo
