[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934893#comment-15934893
]
Mohit Sabharwal commented on HIVE-15766:
Thanks, [~vgumashta], latest patch LGTM. Sorry about the
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930453#comment-15930453
]
Daniel Dai commented on HIVE-15766:
---
Patch LGTM now. [~mohitsabharwal], do you have any additional
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930378#comment-15930378
]
Vaibhav Gumashta commented on HIVE-15766:
-
bq. I will do some additional reading to see if there
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930364#comment-15930364
]
Vaibhav Gumashta commented on HIVE-15766:
-
Addressed all comments from [~thejas] and
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893846#comment-15893846
]
Thejas M Nair commented on HIVE-15766:
--
* Looks like getMS can use getMSForConf as well
* The test
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893605#comment-15893605
]
Hive QA commented on HIVE-15766:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891615#comment-15891615
]
Hive QA commented on HIVE-15766:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890778#comment-15890778
]
Thejas M Nair commented on HIVE-15766:
--
I agree with [~mohitsabharwal], getMS() is something that
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890209#comment-15890209
]
Hive QA commented on HIVE-15766:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890107#comment-15890107
]
Mohit Sabharwal commented on HIVE-15766:
Wondering if it's better to create a new static version
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888562#comment-15888562
]
Thejas M Nair commented on HIVE-15766:
--
[~availlancourt]
This is related to leak described in
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888508#comment-15888508
]
Thejas M Nair commented on HIVE-15766:
--
[~vgumashta]
It would be safer to call HMSHandler.getMS()
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887098#comment-15887098
]
Alexander Kolbasov commented on HIVE-15766:
---
Can someone post a description - what was causing
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884421#comment-15884421
]
Mohit Sabharwal commented on HIVE-15766:
LGTM, +1
A small nit that process() assumes that
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879748#comment-15879748
]
Vaibhav Gumashta commented on HIVE-15766:
-
Test failures unrelated. [~thejas] your +1 still holds?
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854557#comment-15854557
]
Thejas M Nair commented on HIVE-15766:
--
Are the TestReplicationScenarios failures related ?
>
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848849#comment-15848849
]
Thejas M Nair commented on HIVE-15766:
--
Moved this to a top level issue as this is seen independent
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848847#comment-15848847
]
Thejas M Nair commented on HIVE-15766:
--
+1
Thanks for adding the test case as well.
>
[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848618#comment-15848618
]
Sushanth Sowmyan commented on HIVE-15766:
-
+1, LGTM.
> DBNotificationlistener leaks
19 matches
Mail list logo
