[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode

2017-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865511#comment-15865511 ] ASF GitHub Bot commented on HIVE-15858: --- Github user sankarh closed the pull request at:

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode

2017-02-14 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865509#comment-15865509 ] Sankar Hariappan commented on HIVE-15858: - Thanks [~thejas] for the commit! > Beeline ^C doesn't

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-13 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863258#comment-15863258 ] Thejas M Nair commented on HIVE-15858: -- +1 Thanks for also adding the test. > Beeline ^C doesn't

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-12 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862982#comment-15862982 ] Hive QA commented on HIVE-15858: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-12 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862940#comment-15862940 ] Sankar Hariappan commented on HIVE-15858: - [~thejas] Added a unit test case and the new patch is

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-11 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862561#comment-15862561 ] Thejas M Nair commented on HIVE-15858: -- [~sankarh] Added a comment in github pull request. Can you

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-10 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861651#comment-15861651 ] Vihang Karajgaonkar commented on HIVE-15858: bq. For the desired behavior described in

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-10 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861073#comment-15861073 ] Sankar Hariappan commented on HIVE-15858: - Thanks for the review [~xuefuz]! I shall see the test

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-10 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861064#comment-15861064 ] Sankar Hariappan commented on HIVE-15858: - Thanks [~vihangk1] for the comment! I do agree with

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860814#comment-15860814 ] Thejas M Nair commented on HIVE-15858: -- bq. It looks like we have two places in Beeline code to

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859873#comment-15859873 ] Hive QA commented on HIVE-15858: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859748#comment-15859748 ] Vihang Karajgaonkar commented on HIVE-15858: Thanks [~sankarh] for the patch. It looks like we

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859412#comment-15859412 ] Xuefu Zhang commented on HIVE-15858: +1 for the change. However, I think a patch is expected here to

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859328#comment-15859328 ] ASF GitHub Bot commented on HIVE-15858: --- GitHub user sankarh opened a pull request:

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859319#comment-15859319 ] Sankar Hariappan commented on HIVE-15858: - [~xuefuz] Please review the patch where I closed all

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859271#comment-15859271 ] Sankar Hariappan commented on HIVE-15858: - Hi Xuefu Zhang, HIVE-15626 supports the smooth

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

2017-02-09 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859225#comment-15859225 ] Xuefu Zhang commented on HIVE-15858: Does HIVE-15626 help? > Beeline ^C doesn't close the session >