[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901924#comment-15901924 ] Sergey Shelukhin commented on HIVE-16078: - Forgot to mention Matt on commit message :( sorry for

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-07 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900401#comment-15900401 ] Sergey Shelukhin commented on HIVE-16078: - It completes for me with PPD disabled (PPD causes

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-07 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1580#comment-1580 ] Siddharth Seth commented on HIVE-16078: --- [~sershe] - the query where this showed up, how does that

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-07 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898976#comment-15898976 ] Rajesh Balamohan commented on HIVE-16078: - lgtm. +1. > improve abort checking in Tez/LLAP >

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898635#comment-15898635 ] Hive QA commented on HIVE-16078: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-06 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898341#comment-15898341 ] Sergey Shelukhin commented on HIVE-16078: - [~rajesh.balamohan] [~sseth] ping? > improve abort

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895483#comment-15895483 ] Hive QA commented on HIVE-16078: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-03 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894859#comment-15894859 ] Sergey Shelukhin commented on HIVE-16078: - Failures unrelated. startAbortChecks should also reset

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-02 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893767#comment-15893767 ] Hive QA commented on HIVE-16078: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-02 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893127#comment-15893127 ] Matt McCline commented on HIVE-16078: - VectorMapJoinGenerateResultOperator code looks ok, except what

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-02 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892775#comment-15892775 ] Sergey Shelukhin commented on HIVE-16078: - [~rajesh.balamohan] I added the constant, but if the

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891684#comment-15891684 ] Siddharth Seth commented on HIVE-16078: --- bq. Actually also the division is reversed. Should be

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891566#comment-15891566 ] Rajesh Balamohan commented on HIVE-16078: - {noformat} int newRows =

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891417#comment-15891417 ] Matt McCline commented on HIVE-16078: - I haven't looked at the patch yet, but forwardOverflow kicks in

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891322#comment-15891322 ] Sergey Shelukhin commented on HIVE-16078: - I also feel the target time could be bigger, maybe 1-5

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891315#comment-15891315 ] Sergey Shelukhin commented on HIVE-16078: - Actually also the division is reversed. Should be

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891303#comment-15891303 ] Sergey Shelukhin commented on HIVE-16078: - [~sseth] will test in the cluster eventually; the

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891279#comment-15891279 ] Siddharth Seth commented on HIVE-16078: --- Adjusting the interval makes sense to me. I'm not sure

[jira] [Commented] (HIVE-16078) improve abort checking in Tez/LLAP

2017-03-01 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891106#comment-15891106 ] Hive QA commented on HIVE-16078: Here are the results of testing the latest attachment: