[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018591#comment-16018591 ] Hive QA commented on HIVE-16113: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018538#comment-16018538 ] Hive QA commented on HIVE-16113: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-18 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016447#comment-16016447 ] Ashutosh Chauhan commented on HIVE-16113: - +1 > PartitionPruner::removeNonPartCols needs to

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-12 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008863#comment-16008863 ] Hive QA commented on HIVE-16113: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-09 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003324#comment-16003324 ] Gopal V commented on HIVE-16113: bq. My plan is to have these UDFs (NVL/COALESCE) replaced with NULL in

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-09 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003300#comment-16003300 ] Remus Rusanu commented on HIVE-16113: - I don't think we should handle OR in removeNonPartCols, leaving

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-09 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003117#comment-16003117 ] Remus Rusanu commented on HIVE-16113: - {{OR}}: the partition pruner is reducing the expression to

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-09 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002855#comment-16002855 ] Remus Rusanu commented on HIVE-16113: - As for the {{OR}} case, I think that is being removed because

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-09 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002677#comment-16002677 ] Remus Rusanu commented on HIVE-16113: - I think the issue is that the partition pruning logic expects

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-05-08 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001199#comment-16001199 ] Ashutosh Chauhan commented on HIVE-16113: - [~rusanu] You were working on this part of code

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-03-22 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937114#comment-15937114 ] Gopal V commented on HIVE-16113: -1 on this approach for now - the TRUE constants are actually messing up

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-03-06 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897927#comment-15897927 ] Gopal V commented on HIVE-16113: The test failures are related - looks like some of the existing golden

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-03-06 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897921#comment-15897921 ] Sergey Shelukhin commented on HIVE-16113: - +1 assuming tests are unrelated >

[jira] [Commented] (HIVE-16113) PartitionPruner::removeNonPartCols needs to handle AND/OR cases

2017-03-05 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896586#comment-15896586 ] Hive QA commented on HIVE-16113: Here are the results of testing the latest attachment: