[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258764#comment-16258764
]
Vihang Karajgaonkar commented on HIVE-16756:
{{vectorized_ptf}} is failing for a while on
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258641#comment-16258641
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258611#comment-16258611
]
Vihang Karajgaonkar commented on HIVE-16756:
some of the vectorization test failures are
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258049#comment-16258049
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255812#comment-16255812
]
Vihang Karajgaonkar commented on HIVE-16756:
+1 I would merging this change towards the EOD
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255563#comment-16255563
]
Vihang Karajgaonkar commented on HIVE-16756:
Test failures are known flaky tests.
>
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254893#comment-16254893
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254840#comment-16254840
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254585#comment-16254585
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254534#comment-16254534
]
Matt McCline commented on HIVE-16756:
-
I see it now -- sorry.
> Vectorization:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254505#comment-16254505
]
Vihang Karajgaonkar commented on HIVE-16756:
Do you mean in qfile? or a separate Junit for the
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254460#comment-16254460
]
Matt McCline commented on HIVE-16756:
-
Do we need to add modulus tests in addition to division?
>
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254339#comment-16254339
]
Matt McCline commented on HIVE-16756:
-
Yes, its true we only need the fix the for long % long -> long
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254295#comment-16254295
]
Vihang Karajgaonkar commented on HIVE-16756:
Actually, after discussing with [~aihuaxu] I
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254291#comment-16254291
]
Matt McCline commented on HIVE-16756:
-
+1 LGTM. Thanks for fixing this.
> Vectorization:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253857#comment-16253857
]
Vihang Karajgaonkar commented on HIVE-16756:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253038#comment-16253038
]
Hive QA commented on HIVE-16756:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246306#comment-16246306
]
Vihang Karajgaonkar commented on HIVE-16756:
Thanks [~mmccline] Let me take a look.
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243595#comment-16243595
]
Matt McCline commented on HIVE-16756:
-
[~vihangk1] No, I am not actively working on this. Feel free
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243457#comment-16243457
]
Vihang Karajgaonkar commented on HIVE-16756:
Hi [~mmccline] are you actively working on this
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025419#comment-16025419
]
Edward Capriolo commented on HIVE-16756:
SQL spec actually throws exception for divide by 0, but
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024240#comment-16024240
]
Gopal V commented on HIVE-16756:
Yup, I can see that LongColModuloDouble won't have this issue, but the
[
https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024229#comment-16024229
]
Matt McCline commented on HIVE-16756:
-
[~gopalv] [~teddy.choi] Ok, you guys. The vectorized templates
23 matches
Mail list logo
