[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-08 Thread Mithun Radhakrishnan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119041#comment-16119041 ] Mithun Radhakrishnan commented on HIVE-16820: - I've filed HIVE-17273 for this, so that I don't

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-03 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113361#comment-16113361 ] Sergey Shelukhin commented on HIVE-16820: - Thanks! I'd be happy to review > TezTask may not shut

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-03 Thread Mithun Radhakrishnan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113354#comment-16113354 ] Mithun Radhakrishnan commented on HIVE-16820: - bq. Yeah, what I was saying is that we don't

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-02 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111755#comment-16111755 ] Sergey Shelukhin commented on HIVE-16820: - Yeah, what I was saying is that we don't need the same

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-02 Thread Mithun Radhakrishnan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111648#comment-16111648 ] Mithun Radhakrishnan commented on HIVE-16820: - bq. MergeFileTask doesn't appear to implement

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-02 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111429#comment-16111429 ] Sergey Shelukhin commented on HIVE-16820: - MergeFileTask doesn't appear to implement shutdown at

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-08-01 Thread Mithun Radhakrishnan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110071#comment-16110071 ] Mithun Radhakrishnan commented on HIVE-16820: - [~sershe], I wonder if a similar fix should go

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-12 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047007#comment-16047007 ] Siddharth Seth commented on HIVE-16820: --- +1. I'd still change the isShutdown to a volatile, before

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-09 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045352#comment-16045352 ] Hive QA commented on HIVE-16820: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-09 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045258#comment-16045258 ] Sergey Shelukhin commented on HIVE-16820: - 1) Not necessary, the only check outside of the lock is

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-09 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044822#comment-16044822 ] Siddharth Seth commented on HIVE-16820: --- Sorry for the delay. - Should isShutdown be volatile for

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043222#comment-16043222 ] Sergey Shelukhin commented on HIVE-16820: - [~sseth] ping? [~hagleitn] maybe you can review >

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-02 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035765#comment-16035765 ] Hive QA commented on HIVE-16820: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16820) TezTask may not shut down correctly before submit

2017-06-02 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035726#comment-16035726 ] Sergey Shelukhin commented on HIVE-16820: - [~sseth] can you take a look? > TezTask may not shut