[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649688#comment-16649688 ] Vineet Garg commented on HIVE-17043: Pushed to master > Remove non unique columns from group by keys

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649654#comment-16649654 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649631#comment-16649631 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649477#comment-16649477 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648679#comment-16648679 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645850#comment-16645850 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645803#comment-16645803 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641364#comment-16641364 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641332#comment-16641332 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641316#comment-16641316 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640968#comment-16640968 ] Jesus Camacho Rodriguez commented on HIVE-17043: [~vgarg], latest patch seems to have

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640967#comment-16640967 ] Vineet Garg commented on HIVE-17043: Sorry that was a typo, thanks for reviewing it. I have uploaded

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640964#comment-16640964 ] Jesus Camacho Rodriguez commented on HIVE-17043: In latest patch, there are two calls to

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640892#comment-16640892 ] Jesus Camacho Rodriguez commented on HIVE-17043: [~vgarg], I left three minor comments in

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640672#comment-16640672 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640649#comment-16640649 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638538#comment-16638538 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637445#comment-16637445 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637389#comment-16637389 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632522#comment-16632522 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632481#comment-16632481 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626919#comment-16626919 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626863#comment-16626863 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625288#comment-16625288 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624958#comment-16624958 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624505#comment-16624505 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624494#comment-16624494 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624240#comment-16624240 ] Vineet Garg commented on HIVE-17043: [~jcamachorodriguez] I introduced new logic to compute unique

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624133#comment-16624133 ] Vineet Garg commented on HIVE-17043: [~jcamachorodriguez] I agree it is ugly. The problem with

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622990#comment-16622990 ] Jesus Camacho Rodriguez commented on HIVE-17043: [~vgarg], I had a quick look at the

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622698#comment-16622698 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622339#comment-16622339 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622276#comment-16622276 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621318#comment-16621318 ] Vineet Garg commented on HIVE-17043: Patch (3) adds NOT NULL filter elimination tests > Remove non

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620536#comment-16620536 ] Hive QA commented on HIVE-17043: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17043) Remove non unique columns from group by keys if not referenced later

[ https://issues.apache.org/jira/browse/HIVE-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620508#comment-16620508 ] Hive QA commented on HIVE-17043: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||