[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462957#comment-16462957
]
Sergey Shelukhin commented on HIVE-17657:
-
Again because HiveQA is dumb.
> export/import for MM
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462696#comment-16462696
]
Eugene Koifman commented on HIVE-17657:
---
+1
> export/import for MM tables is broken
>
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461492#comment-16461492
]
Sergey Shelukhin commented on HIVE-17657:
-
Same patch for HiveQA, build failed for unrelated
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461490#comment-16461490
]
Sergey Shelukhin commented on HIVE-17657:
-
Correct, there are no renames after that.
>
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460575#comment-16460575
]
Sankar Hariappan commented on HIVE-17657:
-
{quote}
[~sankarh] delta directory of the import after
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460429#comment-16460429
]
Hive QA commented on HIVE-17657:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460403#comment-16460403
]
Sergey Shelukhin commented on HIVE-17657:
-
Rebased the patch.
> export/import for MM tables is
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460347#comment-16460347
]
Hive QA commented on HIVE-17657:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459339#comment-16459339
]
Sergey Shelukhin commented on HIVE-17657:
-
Addressed the CR feedback.
> export/import for MM
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458902#comment-16458902
]
Sergey Shelukhin commented on HIVE-17657:
-
[~sankarh] delta directory of the import after the
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457362#comment-16457362
]
Sankar Hariappan commented on HIVE-17657:
-
[~sershe], [~ekoifman],
I've couple of questions.
#
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457291#comment-16457291
]
Sergey Shelukhin commented on HIVE-17657:
-
not_delta directories (that will be renamed to
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457286#comment-16457286
]
Eugene Koifman commented on HIVE-17657:
---
[~sershe],
left some RB comments - mostly nits, except one
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457008#comment-16457008
]
Sergey Shelukhin commented on HIVE-17657:
-
Rebased the patch. I bet HiveQA will find a way to lose
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450354#comment-16450354
]
Sergey Shelukhin commented on HIVE-17657:
-
Test failures are unrelated. [~ekoifman] can you take a
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449070#comment-16449070
]
Hive QA commented on HIVE-17657:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448906#comment-16448906
]
Hive QA commented on HIVE-17657:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448870#comment-16448870
]
Sergey Shelukhin commented on HIVE-17657:
-
Fixed another NPE, rebased.
Also I gave up on removing
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447134#comment-16447134
]
Hive QA commented on HIVE-17657:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447117#comment-16447117
]
Hive QA commented on HIVE-17657:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446547#comment-16446547
]
Sergey Shelukhin commented on HIVE-17657:
-
Fixing most of the tests... the removal of magic code
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445799#comment-16445799
]
Hive QA commented on HIVE-17657:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445719#comment-16445719
]
Hive QA commented on HIVE-17657:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444974#comment-16444974
]
Sergey Shelukhin commented on HIVE-17657:
-
The test already covers ignoring delta directories that
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444952#comment-16444952
]
Eugene Koifman commented on HIVE-17657:
---
hive.test.rollbacktxn can be used to rollback w/o
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444647#comment-16444647
]
Sergey Shelukhin commented on HIVE-17657:
-
Added a test and fixed some issues.
> export/import
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443502#comment-16443502
]
Sergey Shelukhin commented on HIVE-17657:
-
Fixing export to not generate mm dirs and removing mm
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211834#comment-16211834
]
Sergey Shelukhin commented on HIVE-17657:
-
Well, parts were broken by invalid merge 42a38577bc
[
https://issues.apache.org/jira/browse/HIVE-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211809#comment-16211809
]
Sergey Shelukhin commented on HIVE-17657:
-
This was broken even in tests after one of the master
29 matches
Mail list logo