[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297116#comment-16297116
]
Xuefu Zhang commented on HIVE-18283:
+1
> Better error message and error code for HoS exceptions
>
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297042#comment-16297042
]
Andrew Sherman commented on HIVE-18283:
---
Thanks [~csun]. The patch looks good to me. +1
> Better
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296575#comment-16296575
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296489#comment-16296489
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296059#comment-16296059
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296005#comment-16296005
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295991#comment-16295991
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295967#comment-16295967
]
Andrew Sherman commented on HIVE-18283:
---
Patch looks good to me.
If you do rework it again you
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295922#comment-16295922
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295898#comment-16295898
]
Xuefu Zhang commented on HIVE-18283:
Patch looks good to me except for a minor improvement on a faster
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295876#comment-16295876
]
Chao Sun commented on HIVE-18283:
-
I don't think the test failures are related. [~xuefuz], [~asherman]:
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295718#comment-16295718
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295642#comment-16295642
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292958#comment-16292958
]
Chao Sun commented on HIVE-18283:
-
[~asherman] Yes, this definitely deserves a test case, although it
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292899#comment-16292899
]
Andrew Sherman commented on HIVE-18283:
---
As the new getHiveException() method could be fragile, is
15 matches
Mail list logo
