[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352818#comment-16352818
]
Yongzhi Chen commented on HIVE-18511:
-
The checkstyle all passed and the change looks fine.
+1
> Fix
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352802#comment-16352802
]
Peter Vary commented on HIVE-18511:
---
[~ychena]: Could you review this please?
Thanks,
Peter
> Fix
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352748#comment-16352748
]
Hive QA commented on HIVE-18511:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352680#comment-16352680
]
Hive QA commented on HIVE-18511:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343178#comment-16343178
]
Adam Szita commented on HIVE-18511:
---
+1 non-binding, I can see all checkstyle errors are now fixes
>
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335602#comment-16335602
]
Peter Vary commented on HIVE-18511:
---
This one depends on HIVE-18509
> Fix generated checkstyle errors
>
[
https://issues.apache.org/jira/browse/HIVE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335492#comment-16335492
]
Hive QA commented on HIVE-18511:
Here are the results of testing the latest attachment:
