[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565732#comment-16565732 ] Thai Bui commented on HIVE-18513: - The timeout parameters specially for the external tables make a lot of

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565684#comment-16565684 ] Jason Dere commented on HIVE-18513: --- Created a simple patch for this at HIVE-20250, but had some

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565097#comment-16565097 ] Lars Francke commented on HIVE-18513: - Thanks Jason. If that's all that needs changing I can try to

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551426#comment-16551426 ] Jason Dere commented on HIVE-18513: --- It is certainly doable, would need changes in

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550096#comment-16550096 ] Thai Bui commented on HIVE-18513: - [~lars_francke] I have not work on disabling this limitation on cache

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549661#comment-16549661 ] Lars Francke commented on HIVE-18513: - If I read the design doc correctly the decision to disallow

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487560#comment-16487560 ] Thai Bui commented on HIVE-18513: - It's interesting that the cache won't work with external tables. That

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484227#comment-16484227 ] Jason Dere commented on HIVE-18513: --- So external tables are not allowed in the cache at all - sorry if

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484190#comment-16484190 ] Thai Bui commented on HIVE-18513: - Thanks for the quick reply. That’s a good news . I can just enable that

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484147#comment-16484147 ] Jason Dere commented on HIVE-18513: --- The cache is disabled for queries involving external tables. It is

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484084#comment-16484084 ] Thai Bui commented on HIVE-18513: - Hi [~jdere], this new feature is awesome. I'm glad we are implementing

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356094#comment-16356094 ] Jason Dere commented on HIVE-18513: --- Rebasing patch after HIVE-17991 > Query results caching >

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350765#comment-16350765 ] Hive QA commented on HIVE-18513: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350741#comment-16350741 ] Hive QA commented on HIVE-18513: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350654#comment-16350654 ] Xuefu Zhang commented on HIVE-18513: That's good. As a minor comment, if we were only doing time-based

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349994#comment-16349994 ] Jason Dere commented on HIVE-18513: --- What's currently implemented in this patch is time-based

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349716#comment-16349716 ] Xuefu Zhang commented on HIVE-18513: Thanks, [~jcamachorodriguez] and [~jdere]. I went thru the doc

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349704#comment-16349704 ] Jesus Camacho Rodriguez commented on HIVE-18513: [~xuefuz], [~jdere] already posted the

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349703#comment-16349703 ] Xuefu Zhang commented on HIVE-18513: Could we have the high-level doc linked here so others interested

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349685#comment-16349685 ] Jesus Camacho Rodriguez commented on HIVE-18513: +1 (pending tests) > Query results

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349677#comment-16349677 ] Jason Dere commented on HIVE-18513: --- patch didn't include the additional changes, re-attaching > Query

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349642#comment-16349642 ] Jason Dere commented on HIVE-18513: --- Additional changes per review from [~jcamachorodriguez]. > Query

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347346#comment-16347346 ] Hive QA commented on HIVE-18513: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347304#comment-16347304 ] Hive QA commented on HIVE-18513: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346306#comment-16346306 ] Jason Dere commented on HIVE-18513: --- Uploaded patch v4 with updates from RB comments. > Query results

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346305#comment-16346305 ] Jason Dere commented on HIVE-18513: --- Created a doc at

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341443#comment-16341443 ] Jason Dere commented on HIVE-18513: --- Hey [~xuefuz], good point, will attach a doc. > Query results

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341418#comment-16341418 ] Xuefu Zhang commented on HIVE-18513: [~jdere] Thanks for working on this useful feature! The patch

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341397#comment-16341397 ] Jason Dere commented on HIVE-18513: --- I don't think the failures are related to the patch.

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341071#comment-16341071 ] Hive QA commented on HIVE-18513: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341037#comment-16341037 ] Hive QA commented on HIVE-18513: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340305#comment-16340305 ] Hive QA commented on HIVE-18513: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340288#comment-16340288 ] Hive QA commented on HIVE-18513: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338853#comment-16338853 ] Jason Dere commented on HIVE-18513: --- Fix test failures by either enabling cache

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338499#comment-16338499 ] Hive QA commented on HIVE-18513: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338477#comment-16338477 ] Hive QA commented on HIVE-18513: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338110#comment-16338110 ] Jason Dere commented on HIVE-18513: --- Adding patch v2: * Disable caching of results if the query did not

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336669#comment-16336669 ] Jason Dere commented on HIVE-18513: --- [~vgarg] it compares a modified version of the query string, which

[jira] [Commented] (HIVE-18513) Query results caching

[ https://issues.apache.org/jira/browse/HIVE-18513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336637#comment-16336637 ] Vineet Garg commented on HIVE-18513: [~jdere] I haven't yet looked at the patch but had one question :