[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370352#comment-16370352
]
Matt McCline commented on HIVE-18744:
-
The *last* row of a batch presented to VectorGroupByOperator
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370146#comment-16370146
]
Matt McCline commented on HIVE-18744:
-
I'm not convinced this change fixes the problem.
>
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369961#comment-16369961
]
Teddy Choi commented on HIVE-18744:
---
+1 Looks good to me.
By the way, I got some unit test failures,
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369675#comment-16369675
]
Matt McCline commented on HIVE-18744:
-
[~owen.omalley] Thank you for the code review. I'm struggling
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369344#comment-16369344
]
Owen O'Malley commented on HIVE-18744:
--
+1 for the fix, however you should add new unit test cases
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369334#comment-16369334
]
Matt McCline commented on HIVE-18744:
-
No new test failures for this Hive QA run. Fix confirmed by a
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369220#comment-16369220
]
Hive QA commented on HIVE-18744:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369151#comment-16369151
]
Hive QA commented on HIVE-18744:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
