[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494259#comment-16494259
]
Vineet Garg commented on HIVE-19307:
Pushed this to branch-3. Test run in HIVE-19305
> Support
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475497#comment-16475497
]
Hive QA commented on HIVE-19307:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475471#comment-16475471
]
Hive QA commented on HIVE-19307:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474524#comment-16474524
]
Jason Dere commented on HIVE-19307:
---
+1 from me, at least code-wise.
This may have to wait for another
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473890#comment-16473890
]
Hive QA commented on HIVE-19307:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473853#comment-16473853
]
Hive QA commented on HIVE-19307:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473655#comment-16473655
]
Hive QA commented on HIVE-19307:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473645#comment-16473645
]
Hive QA commented on HIVE-19307:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473025#comment-16473025
]
Hive QA commented on HIVE-19307:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473012#comment-16473012
]
Hive QA commented on HIVE-19307:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469172#comment-16469172
]
Eric Wohlstadter commented on HIVE-19307:
-
[~jdere]
That makes sense. I'll make that change in
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469160#comment-16469160
]
Jason Dere commented on HIVE-19307:
---
How about this comment?
{quote}
This is checking
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466520#comment-16466520
]
Eric Wohlstadter commented on HIVE-19307:
-
[~jdere]
I created HIVE-19445 to followup on:
{quote}I
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461615#comment-16461615
]
Jason Dere commented on HIVE-19307:
---
A few things:
Nit: LlapOutputFormatService.java has a tab in the
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461515#comment-16461515
]
Eric Wohlstadter commented on HIVE-19307:
-
[~jdere] [~teddy.choi]
Yes, it depends on HIVE-19306
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461509#comment-16461509
]
Jason Dere commented on HIVE-19307:
---
Looks like the patch failed to compile during ptests, is this patch
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461474#comment-16461474
]
Eric Wohlstadter commented on HIVE-19307:
-
TODO (before commit):
Need to verify that the line in
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460513#comment-16460513
]
Hive QA commented on HIVE-19307:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460508#comment-16460508
]
Eric Wohlstadter commented on HIVE-19307:
-
[~jdere]
Updated patch with missing
19 matches
Mail list logo
