[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748416#comment-16748416 ] Teddy Choi commented on HIVE-20419: --- Revised and pushed to master. Thanks [~gopalv]. > Vectorization:

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748357#comment-16748357 ] Gopal V commented on HIVE-20419: LGTM - +1 [~teddy.choi]: can you fix, before commit? {code} +

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748322#comment-16748322 ] Hive QA commented on HIVE-20419: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748294#comment-16748294 ] Hive QA commented on HIVE-20419: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748076#comment-16748076 ] Hive QA commented on HIVE-20419: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2019-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747968#comment-16747968 ] ASF GitHub Bot commented on HIVE-20419: --- GitHub user pudidic opened a pull request:

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2018-10-25 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664417#comment-16664417 ] Gopal V commented on HIVE-20419: No, right now it just duplicates the desc for each partition and makes

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2018-10-25 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664409#comment-16664409 ] Sergey Shelukhin commented on HIVE-20419: - Hmm. Cannot this also cause incorrect results? If the

[jira] [Commented] (HIVE-20419) Vectorization: Prevent mutation of VectorPartitionDesc after being used in a hashmap key

2018-10-25 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664410#comment-16664410 ] Sergey Shelukhin commented on HIVE-20419: - cc [~teddy.choi] > Vectorization: Prevent mutation of