[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-18 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656197#comment-16656197 ] Hive QA commented on HIVE-20549: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-18 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656193#comment-16656193 ] Hive QA commented on HIVE-20549: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654344#comment-16654344 ] Daniel Dai commented on HIVE-20549: --- Attached the wrong patch. Thanks [~sershe]! > Allow user set

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-17 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654101#comment-16654101 ] Sergey Shelukhin commented on HIVE-20549: - +1 pending tests for 03 patch :) or its correct update

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-17 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654098#comment-16654098 ] Sergey Shelukhin commented on HIVE-20549: - The 04 patch is wrong, it just comments out some stuff

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-17 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654090#comment-16654090 ] Thejas M Nair commented on HIVE-20549: -- +1 pending tests > Allow user set query tag, and kill

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-10-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651148#comment-16651148 ] Daniel Dai commented on HIVE-20549: --- Resync with master, and fix ptest failures. > Allow user set

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-20 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622776#comment-16622776 ] Daniel Dai commented on HIVE-20549: --- New patch to address Mahesh's review comment #1, #3. > Allow user

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-19 Thread mahesh kumar behera (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621457#comment-16621457 ] mahesh kumar behera commented on HIVE-20549: [~thejas] The code changes looks fine to me >

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-18 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619697#comment-16619697 ] Daniel Dai commented on HIVE-20549: --- In both scenario, killQuery will try to kill applicable yarn

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-18 Thread mahesh kumar behera (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618716#comment-16618716 ] mahesh kumar behera commented on HIVE-20549: ya ..saw that part of the code where check is

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618516#comment-16618516 ] Daniel Dai commented on HIVE-20549: --- We can decide the owner of the children. For doAs=true,

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread mahesh kumar behera (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618508#comment-16618508 ] mahesh kumar behera commented on HIVE-20549: i think, if we can not decide on the owner

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618316#comment-16618316 ] Daniel Dai commented on HIVE-20549: --- [~maheshk114], 1. will do 2. depends on how we implement #5. If we

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618193#comment-16618193 ] Daniel Dai commented on HIVE-20549: --- [~sershe], the main use case for it is replication and webhcat.

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617962#comment-16617962 ] Sergey Shelukhin commented on HIVE-20549: - What is the problem with just using query ID? Also on

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-17 Thread mahesh kumar behera (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617565#comment-16617565 ] mahesh kumar behera commented on HIVE-20549: I have few observations ..check if these can be

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-16 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617091#comment-16617091 ] Daniel Dai commented on HIVE-20549: --- RB link attached. > Allow user set query tag, and kill query with

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-16 Thread mahesh kumar behera (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617083#comment-16617083 ] mahesh kumar behera commented on HIVE-20549: [~daijy] Can you create a pull request. Its

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615538#comment-16615538 ] Hive QA commented on HIVE-20549: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615536#comment-16615536 ] Hive QA commented on HIVE-20549: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614122#comment-16614122 ] Hive QA commented on HIVE-20549: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20549) Allow user set query tag, and kill query with tag

2018-09-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614100#comment-16614100 ] Hive QA commented on HIVE-20549: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||