[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-16 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794327#comment-16794327 ] Gopal V commented on HIVE-21399: {code} ERROR: -1 due to no test(s) being added or modified. {code} I

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794094#comment-16794094 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794085#comment-16794085 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-15 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794058#comment-16794058 ] Gopal V commented on HIVE-21399: The patch LGTM - +1 A significant number of them are 0.0 or close to

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-15 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794053#comment-16794053 ] Jesus Camacho Rodriguez commented on HIVE-21399: [~ashutoshc], [~gopalv], could you take

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793297#comment-16793297 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793292#comment-16793292 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792475#comment-16792475 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792322#comment-16792322 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792313#comment-16792313 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791423#comment-16791423 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791406#comment-16791406 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787650#comment-16787650 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787625#comment-16787625 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786762#comment-16786762 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786688#comment-16786688 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786687#comment-16786687 ] Hive QA commented on HIVE-21399: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786659#comment-16786659 ] Hive QA commented on HIVE-21399: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786359#comment-16786359 ] Gopal V commented on HIVE-21399: That might explain why it isn't working for me right now - the config is

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786357#comment-16786357 ] Jesus Camacho Rodriguez commented on HIVE-21399: [~gopalv], new value is calculated as:

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786342#comment-16786342 ] Gopal V commented on HIVE-21399: [~jcamachorodriguez]: also turn off this optimization if someone does

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786285#comment-16786285 ] Jesus Camacho Rodriguez commented on HIVE-21399: [~vgarg], yes, that is the check on

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786282#comment-16786282 ] Gopal V commented on HIVE-21399: Testing the patch - the feature is right now invisible. Can you wrap

[jira] [Commented] (HIVE-21399) Adjust hive.map.aggr.hash.min.reduction statically depending on group by statistics

2019-03-06 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786280#comment-16786280 ] Vineet Garg commented on HIVE-21399: [~jcamachorodriguez] Shouldn't {{SetHashGroupByMinReduction}} be