[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017778#comment-17017778
]
Marta Kuczora commented on HIVE-22685:
--
+1
Thanks a lot [~belugabehr] for the fix.
>
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017071#comment-17017071
]
Karen Coppage commented on HIVE-22685:
--
[~kuczoram] :)
> TestHiveSqlDateTimeFormatter Now Broken
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017065#comment-17017065
]
David Mollitor commented on HIVE-22685:
---
[~ngangam] [~pvary] Can you please chime in? :)
>
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016171#comment-17016171
]
Karen Coppage commented on HIVE-22685:
--
Hi David, ok, you've convinced me.
+1 (non-binding) for
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015902#comment-17015902
]
Hive QA commented on HIVE-22685:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015844#comment-17015844
]
Hive QA commented on HIVE-22685:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015230#comment-17015230
]
David Mollitor commented on HIVE-22685:
---
[~klcopp] Thanks. Love the discussion.
I do really
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015198#comment-17015198
]
Karen Coppage commented on HIVE-22685:
--
Hi David, ok, using the guava Optional works. But I still
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015112#comment-17015112
]
David Mollitor commented on HIVE-22685:
---
Added a new patch with proposed changes.
>
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015097#comment-17015097
]
David Mollitor commented on HIVE-22685:
---
[~klcopp] Thanks for the review.
Yes. I see now that
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015004#comment-17015004
]
Karen Coppage commented on HIVE-22685:
--
Hi David,
Thanks for fixing the issue. The flaw in my
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008365#comment-17008365
]
David Mollitor commented on HIVE-22685:
---
[~ashutoshc] Are you able to take a look at this one?
>
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006988#comment-17006988
]
Hive QA commented on HIVE-22685:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006930#comment-17006930
]
Hive QA commented on HIVE-22685:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006846#comment-17006846
]
David Mollitor commented on HIVE-22685:
---
Added new test to fix javadoc issue.
>
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006610#comment-17006610
]
Hive QA commented on HIVE-22685:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006593#comment-17006593
]
Hive QA commented on HIVE-22685:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005843#comment-17005843
]
David Mollitor commented on HIVE-22685:
---
[~klcopp]
> TestHiveSqlDateTimeFormatter Now Broken with
18 matches
Mail list logo
