[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-29 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026128#comment-17026128 ] Gopal Vijayaraghavan commented on HIVE-22784: - LGTM - +1 > Boundary condition to check if

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025553#comment-17025553 ] Hive QA commented on HIVE-22784: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025543#comment-17025543 ] Hive QA commented on HIVE-22784: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025488#comment-17025488 ] Hive QA commented on HIVE-22784: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025459#comment-17025459 ] Hive QA commented on HIVE-22784: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-28 Thread Ramesh Kumar Thangarajan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025400#comment-17025400 ] Ramesh Kumar Thangarajan commented on HIVE-22784: - Missed the case, when newLength and

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-27 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024896#comment-17024896 ] Gopal Vijayaraghavan commented on HIVE-22784: - Looks like rightTrimAndTruncate has an

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-27 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024814#comment-17024814 ] Hive QA commented on HIVE-22784: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-22784) Boundary condition to check if there is nothing to truncate in StringExpr functions

2020-01-27 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024789#comment-17024789 ] Hive QA commented on HIVE-22784: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||