[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057955#comment-17057955
]
Naveen Gangam commented on HIVE-22974:
--
+1. Looks good to me. Thank you [~amagyar]
> Metastore's
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057909#comment-17057909
]
Attila Magyar commented on HIVE-22974:
--
[~ngangam], tests finally passed. Please review the change
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057868#comment-17057868
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057819#comment-17057819
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057000#comment-17057000
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056956#comment-17056956
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056180#comment-17056180
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056123#comment-17056123
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055911#comment-17055911
]
Naveen Gangam commented on HIVE-22974:
--
Good catch by the test. I will review the new patch as well.
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055726#comment-17055726
]
Attila Magyar commented on HIVE-22974:
--
[~ngangam], I see that
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055375#comment-17055375
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055338#comment-17055338
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054895#comment-17054895
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054851#comment-17054851
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054370#comment-17054370
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054359#comment-17054359
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053730#comment-17053730
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053746#comment-17053746
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053701#comment-17053701
]
Naveen Gangam commented on HIVE-22974:
--
Will do.
> Metastore's table location check should be
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053680#comment-17053680
]
Attila Magyar commented on HIVE-22974:
--
[~ngangam], ok, could you push it to master once CI
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053547#comment-17053547
]
Naveen Gangam commented on HIVE-22974:
--
Thanks [~amagyar]. Looks like the actual tabletype is
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053520#comment-17053520
]
Attila Magyar commented on HIVE-22974:
--
[~ngangam] if I comment out the code change the test fails
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053516#comment-17053516
]
Naveen Gangam commented on HIVE-22974:
--
[~amagyar] I just realized that the newly added test might
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052184#comment-17052184
]
Hive QA commented on HIVE-22974:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052169#comment-17052169
]
Naveen Gangam commented on HIVE-22974:
--
[~amagyar] Could you please add a unit test for this in the
[
https://issues.apache.org/jira/browse/HIVE-22974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052125#comment-17052125
]
Hive QA commented on HIVE-22974:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
26 matches
Mail list logo