[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109402#comment-17109402
]
Hive QA commented on HIVE-23443:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109387#comment-17109387
]
Hive QA commented on HIVE-23443:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108798#comment-17108798
]
Prasanth Jayachandran commented on HIVE-23443:
--
[~pgaref] non-finishable to finishable is
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108523#comment-17108523
]
Panagiotis Garefalakis commented on HIVE-23443:
---
Hey [~prasanth_j] latest changes LGTM --
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108150#comment-17108150
]
Hive QA commented on HIVE-23443:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108124#comment-17108124
]
Hive QA commented on HIVE-23443:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107565#comment-17107565
]
Prasanth Jayachandran commented on HIVE-23443:
--
I was able to repro the issue with unit
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107490#comment-17107490
]
Prasanth Jayachandran commented on HIVE-23443:
--
Created HIVE-23472 to handle the guaranteed
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105809#comment-17105809
]
Gopal Vijayaraghavan commented on HIVE-23443:
-
bq. 1) If guaranteed or finishable, the task
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105308#comment-17105308
]
Panagiotis Garefalakis commented on HIVE-23443:
---
Hey [~prasanth_j] the described logic does
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105031#comment-17105031
]
Prasanth Jayachandran commented on HIVE-23443:
--
[~gopalv]/[~pgaref] I simplified logic of
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104978#comment-17104978
]
Hive QA commented on HIVE-23443:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104958#comment-17104958
]
Hive QA commented on HIVE-23443:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104926#comment-17104926
]
Prasanth Jayachandran commented on HIVE-23443:
--
Good catch. I will update the PR and pull in
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104921#comment-17104921
]
Panagiotis Garefalakis commented on HIVE-23443:
---
Btw tried to capture the scenario in a
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104915#comment-17104915
]
Panagiotis Garefalakis commented on HIVE-23443:
---
Hey [~prasanth_j] I believe updateFragment
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104908#comment-17104908
]
Gopal Vijayaraghavan commented on HIVE-23443:
-
LGTM - +1
Will wait for the scale tests, not
[
https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104868#comment-17104868
]
Prasanth Jayachandran commented on HIVE-23443:
--
The patch is still pending testing with some
18 matches
Mail list logo