[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-02-16 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285556#comment-17285556 ] Zhihua Deng commented on HIVE-24666: Thank you very much for the review and merge, [~

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-02-13 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284337#comment-17284337 ] Gopal Vijayaraghavan commented on HIVE-24666: - LGTM - +1 will merge this on

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-02-13 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284333#comment-17284333 ] Gopal Vijayaraghavan commented on HIVE-24666: - The new patch looks really goo

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-02-13 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284158#comment-17284158 ] Zhihua Deng commented on HIVE-24666: Any comments or thoughts on the changes?  thanks

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-02-02 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277409#comment-17277409 ] Gopal Vijayaraghavan commented on HIVE-24666: - bq. This is caused by the vect

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-29 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274497#comment-17274497 ] Zhihua Deng commented on HIVE-24666: Correct me if wrong... Before the patch, queries

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-26 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272061#comment-17272061 ] Zhihua Deng commented on HIVE-24666: {{{quote}}}{{ }} You're not wrong, this patch w

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-25 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271616#comment-17271616 ] Gopal Vijayaraghavan commented on HIVE-24666: - bq. Cloud you please put it a

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-24 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271106#comment-17271106 ] Zhihua Deng commented on HIVE-24666: Thanks much for the reply. > So this might need

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-24 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270899#comment-17270899 ] Gopal Vijayaraghavan commented on HIVE-24666: - I think for an uncasted column

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-24 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270881#comment-17270881 ] Gopal Vijayaraghavan commented on HIVE-24666: - So this fix is good, but it fi

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-24 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270879#comment-17270879 ] Gopal Vijayaraghavan commented on HIVE-24666: - I see your fix, but I think th

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-20 Thread Zhihua Deng (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269040#comment-17269040 ] Zhihua Deng commented on HIVE-24666: Thanks [~gopalv] for pointing it out. I've updat

[jira] [Commented] (HIVE-24666) Vectorized UDFToBoolean may unable to filter rows if input is string

2021-01-20 Thread Gopal Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/HIVE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268817#comment-17268817 ] Gopal Vijayaraghavan commented on HIVE-24666: - This looks like the wrong fix