[ 
https://issues.apache.org/jira/browse/HIVE-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang resolved HIVE-13026.
--------------------------------
    Resolution: Invalid

Looked into it and found that we should use the active call related metrics.

> Pending/running operation metrics are wrong
> -------------------------------------------
>
>                 Key: HIVE-13026
>                 URL: https://issues.apache.org/jira/browse/HIVE-13026
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>
> A query is finished, however the pending/running operation count doesn't 
> decrease. 
> For example, in TestHs2Metrics::testMetrics(), we have
> {noformat}
> MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.TIMER, 
> "api_hs2_operation_PENDING", 1);
>     MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.TIMER, 
> "api_hs2_operation_RUNNING", 1);
>     MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.COUNTER, 
> "hs2_completed_operation_FINISHED", 1);
> {noformat}
> Should it be below?
> {noformat}
> MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.TIMER, 
> "api_hs2_operation_PENDING", 0);
>     MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.TIMER, 
> "api_hs2_operation_RUNNING", 0);
>     MetricsTestUtils.verifyMetricsJson(json, MetricsTestUtils.COUNTER, 
> "hs2_completed_operation_FINISHED", 1);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to