[ https://issues.apache.org/jira/browse/HIVE-25935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Vary resolved HIVE-25935. ------------------------------- Resolution: Fixed Pushed to master. Thanks for raising the issue [~zabetak] and [~dengzh] for the review! > Cleanup IMetaStoreClient#getPartitionsByNames APIs > -------------------------------------------------- > > Key: HIVE-25935 > URL: https://issues.apache.org/jira/browse/HIVE-25935 > Project: Hive > Issue Type: Task > Components: Metastore > Reporter: Stamatis Zampetakis > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-1 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the > [IMetastoreClient|https://github.com/apache/hive/blob/4b7a948e45fd88372fef573be321cda40d189cc7/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java] > interface has 8 variants of the {{getPartitionsByNames}} method. Going > quickly over the concrete implementation it appears that not all of them are > useful/necessary so a bit of cleanup is needed. > Below a few potential problems I observed: > * Some of the APIs are not used anywhere in the project (neither by > production nor by test code). > * Some of the APIs are deprecated in some concrete implementations but not > globally at the interface level without an explanation why. > * Some of the implementations simply throw without doing anything. > * Many of the APIs are partially tested or not tested at all. > HIVE-24743, HIVE-25281 are related since they introduce/deprecate some of the > aforementioned APIs. > It would be good to review the aforementioned APIs and decide what needs to > stay and what needs to go as well as complete necessary when relevant. -- This message was sent by Atlassian Jira (v8.20.1#820001)