[jira] [Updated] (HIVE-22740) Test failing tests with return path

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22740:
--
Status: Patch Available  (was: Open)

> Test failing tests with return path 
> 
>
> Key: HIVE-22740
> URL: https://issues.apache.org/jira/browse/HIVE-22740
> Project: Hive
>  Issue Type: Bug
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-22740.01.patch
>
>
> This is a dummy Jira for testing which tests are still failing with return 
> path enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22740) Test failing tests with return path

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22740:
--
Attachment: HIVE-22740.01.patch

> Test failing tests with return path 
> 
>
> Key: HIVE-22740
> URL: https://issues.apache.org/jira/browse/HIVE-22740
> Project: Hive
>  Issue Type: Bug
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-22740.01.patch
>
>
> This is a dummy Jira for testing which tests are still failing with return 
> path enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22740) Test failing tests with return path

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22740:
--
Description: This is a dummy Jira for testing which tests are still failing 
with return path enabled.

> Test failing tests with return path 
> 
>
> Key: HIVE-22740
> URL: https://issues.apache.org/jira/browse/HIVE-22740
> Project: Hive
>  Issue Type: Bug
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>
> This is a dummy Jira for testing which tests are still failing with return 
> path enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22740) Test failing tests with return path

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely reassigned HIVE-22740:
-

Assignee: Miklos Gergely

> Test failing tests with return path 
> 
>
> Key: HIVE-22740
> URL: https://issues.apache.org/jira/browse/HIVE-22740
> Project: Hive
>  Issue Type: Bug
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22685) TestHiveSqlDateTimeFormatter Now Broken with New Year 2020

2020-01-16 Thread Marta Kuczora (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017778#comment-17017778
 ] 

Marta Kuczora commented on HIVE-22685:
--

+1
Thanks a lot [~belugabehr] for the fix.

> TestHiveSqlDateTimeFormatter Now Broken with New Year 2020
> --
>
> Key: HIVE-22685
> URL: https://issues.apache.org/jira/browse/HIVE-22685
> Project: Hive
>  Issue Type: Bug
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22685.1.patch, HIVE-22685.2.patch, 
> HIVE-22685.3.patch
>
>
> Unit test is now broken (n)(n):(
> {code:java}
> //Tests for these patterns would need changing every decade if done in 
> the above way.
> //Thursday of the first week in an ISO year always matches the Gregorian 
> year.
> checkParseTimestampIso("IY-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> checkParseTimestampIso("I-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> {code}
> {code}
> org.junit.ComparisonFailure: expected:<01, 20[1]0> but was:<01, 20[2]0>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.checkParseTimestampIso(TestHiveSqlDateTimeFormatter.java:313)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.testParseTimestamp(TestHiveSqlDateTimeFormatter.java:287)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22536) Improve return path enabling/disabling

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22536:
--
Attachment: (was: HIVE-22536.01.patch)

> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, 
> HIVE-22536.03.patch
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
> on/off/supported. In case of "supported" it should be used for a subset of 
> commands which are already verified to be able to work with return path. This 
> is a temporary solution for the time while we are developing return path, 
> before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22536) Improve return path enabling/disabling

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017776#comment-17017776
 ] 

Hive QA commented on HIVE-22536:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991132/HIVE-22536.01.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20221/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20221/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20221/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-01-17 07:45:17.647
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-20221/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-01-17 07:45:17.650
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at bd8fa5c HIVE-22713: Constant propagation shouldn't be done for 
Join-Fil(*)-RS structure (Ramesh Kumar Thangarajan, reviewed by Jesus Camacho 
Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at bd8fa5c HIVE-22713: Constant propagation shouldn't be done for 
Join-Fil(*)-RS structure (Ramesh Kumar Thangarajan, reviewed by Jesus Camacho 
Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-01-17 07:45:18.395
+ rm -rf ../yetus_PreCommit-HIVE-Build-20221
+ mkdir ../yetus_PreCommit-HIVE-Build-20221
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-20221
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-20221/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:12425
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java' with 
conflicts.
Going to apply patch with: git apply -p0
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:12425
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java' with 
conflicts.
U ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-20221
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991132 - PreCommit-HIVE-Build

> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.01.patch, 
> HIVE-22536.02.patch, HIVE-22536.03.patch
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
> on/off/supported. In case of "supported" it should be used for a subset of 
> commands which are already verified to be able to work with return path. This 
> is a temporary solution for the time while we are developing return path, 
> before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22518) SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017775#comment-17017775
 ] 

Hive QA commented on HIVE-22518:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991125/HIVE-22518.03.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17877 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb_schq] 
(batchId=180)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20220/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20220/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20220/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991125 - PreCommit-HIVE-Build

> SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests
> 
>
> Key: HIVE-22518
> URL: https://issues.apache.org/jira/browse/HIVE-22518
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22518.01.patch, HIVE-22518.01.patch, 
> HIVE-22518.02.patch, HIVE-22518.02.patch, HIVE-22518.03.patch, 
> HIVE-22518.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22705) LLAP cache is polluted by query-based compactor

2020-01-16 Thread Laszlo Pinter (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017764#comment-17017764
 ] 

Laszlo Pinter commented on HIVE-22705:
--

+1 (non-binding and pending tests) 

> LLAP cache is polluted by query-based compactor
> ---
>
> Key: HIVE-22705
> URL: https://issues.apache.org/jira/browse/HIVE-22705
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Attachments: HIVE-22705.0.patch
>
>
> One of the steps that query-based compaction does is the verification of ACID 
> sort order by using the _validate_acid_sort_order_ UDF. This is a 
> prerequisite before the actual compaction can happen, and is done by a [query 
> that reads the whole table 
> content|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java#L161-L167].
> This results in the whole table content being populated into the cache. The 
> problem is that this content is not useful and will rather pollute the cache 
> space, as it can never be used again: cache content binds to files (file IDs) 
> that obviously will be changed in this case by compaction.
> I propose we disable LLAP caching in the session of query-based compaction's 
> queries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22518) SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017745#comment-17017745
 ] 

Hive QA commented on HIVE-22518:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 43s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20220/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| modules | C: ql . U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20220/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests
> 
>
> Key: HIVE-22518
> URL: https://issues.apache.org/jira/browse/HIVE-22518
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22518.01.patch, HIVE-22518.01.patch, 
> HIVE-22518.02.patch, HIVE-22518.02.patch, HIVE-22518.03.patch, 
> HIVE-22518.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21050) Use Parquet LogicalTypes

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017740#comment-17017740
 ] 

Hive QA commented on HIVE-21050:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991127/HIVE-21050.11.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17931 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestTxnCommands.testQuotedIdentifier (batchId=357)
org.apache.hive.minikdc.TestJdbcWithMiniKdcSQLAuthBinary.testAuthorization1 
(batchId=304)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20219/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20219/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20219/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991127 - PreCommit-HIVE-Build

> Use Parquet LogicalTypes
> 
>
> Key: HIVE-21050
> URL: https://issues.apache.org/jira/browse/HIVE-21050
> Project: Hive
>  Issue Type: Improvement
>  Components: File Formats
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>  Labels: Parquet, parquet
> Attachments: HIVE-21050.1.patch, HIVE-21050.1.patch, 
> HIVE-21050.1.patch, HIVE-21050.10.patch, HIVE-21050.11.patch, 
> HIVE-21050.2.patch, HIVE-21050.3.patch, HIVE-21050.4.patch, 
> HIVE-21050.4.patch, HIVE-21050.4.patch, HIVE-21050.5.patch, 
> HIVE-21050.5.patch, HIVE-21050.5.patch, HIVE-21050.6.patch, 
> HIVE-21050.6.patch, HIVE-21050.6.patch, HIVE-21050.6.patch.txt, 
> HIVE-21050.7.patch, HIVE-21050.7.patch, HIVE-21050.8.patch, HIVE-21050.9.patch
>
>
> [WIP until Parquet community releases version 1.11.0]
> The new Parquet version (1.11.0) uses 
> [LogicalTypes|https://github.com/apache/parquet-format/blob/master/LogicalTypes.md]
>  instead of OriginalTypes.
>  These are backwards-compatible with OriginalTypes.
> Thanks to [~kuczoram] for her work on this patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21050) Use Parquet LogicalTypes

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017723#comment-17017723
 ] 

Hive QA commented on HIVE-21050:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
51s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
37s{color} | {color:red} ql: The patch generated 2 new + 151 unchanged - 5 
fixed = 153 total (was 156) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20219/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20219/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20219/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Use Parquet LogicalTypes
> 
>
> Key: HIVE-21050
> URL: https://issues.apache.org/jira/browse/HIVE-21050
> Project: Hive
>  Issue Type: Improvement
>  Components: File Formats
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>  Labels: Parquet, parquet
> Attachments: HIVE-21050.1.patch, HIVE-21050.1.patch, 
> HIVE-21050.1.patch, HIVE-21050.10.patch, HIVE-21050.11.patch, 
> HIVE-21050.2.patch, HIVE-21050.3.patch, HIVE-21050.4.patch, 
> HIVE-21050.4.patch, HIVE-21050.4.patch, HIVE-21050.5.patch, 
> HIVE-21050.5.patch, HIVE-21050.5.patch, HIVE-21050.6.patch, 
> HIVE-21050.6.patch, HIVE-21050.6.patch, HIVE-21050.6.patch.txt, 
> HIVE-21050.7.patch, HIVE-21050.7.patch, HIVE-21050.8.patch, HIVE-21050.9.patch
>
>
> [WIP until Parquet community releases version 1.11.0]
> The new Parquet version (1.11.0) uses 
> [LogicalTypes|https://github.com/apache/parquet-format/blob/master/LogicalTypes.md]
>  instead of OriginalTypes.
>  These are backwards-compatible with OriginalTypes.
> Thanks to [~kuczoram] for her work on this patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22696) Break up DDLSemanticAnalyzer - extract Table partition analyzers

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017720#comment-17017720
 ] 

Jesus Camacho Rodriguez commented on HIVE-22696:


+1

> Break up DDLSemanticAnalyzer - extract Table partition analyzers
> 
>
> Key: HIVE-22696
> URL: https://issues.apache.org/jira/browse/HIVE-22696
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22696.01.patch, HIVE-22696.02.patch, 
> HIVE-22696.03.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is 
> to refactor it in order to have everything cut into more handleable classes 
> under the package  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each analyzers
>  * have a package for each operation, containing an analyzer, a description, 
> and an operation, so the amount of classes under a package is more manageable
> Step #12: extract the table partition related analyzers from 
> DDLSemanticAnalyzer, and move them under the new package.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017711#comment-17017711
 ] 

Hive QA commented on HIVE-22730:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991180/HIVE-22730.4.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20218/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20218/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20218/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12991180/HIVE-22730.4.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991180 - PreCommit-HIVE-Build

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, HIVE-22730.4.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22725) Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017710#comment-17017710
 ] 

Hive QA commented on HIVE-22725:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991123/HIVE-22725.4.patch

{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17877 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20217/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20217/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20217/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991123 - PreCommit-HIVE-Build

> Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation
> 
>
> Key: HIVE-22725
> URL: https://issues.apache.org/jira/browse/HIVE-22725
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-22725.1.patch, HIVE-22725.2.patch, 
> HIVE-22725.3.patch, HIVE-22725.4.patch, image-2020-01-14-13-22-54-483.png
>
>
> "TransactionalValidationListener" gets added in the pre-event listeners of 
> HMS by default.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L559]
> This causes issue in short select queries, as table details are computed for 
> any partition lookups.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L4984]
>  
> !image-2020-01-14-13-22-54-483.png|width=579,height=202!
>  
> It would be good to lazy evaluate table lookup in this codepath.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017692#comment-17017692
 ] 

Jesus Camacho Rodriguez commented on HIVE-22489:


+1 (pending tests)

>  Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.10.patch, 
> HIVE-22489.10.patch, HIVE-22489.11.patch, HIVE-22489.12.patch, 
> HIVE-22489.13.patch, HIVE-22489.13.patch, HIVE-22489.13.patch, 
> HIVE-22489.2.patch, HIVE-22489.3.patch, HIVE-22489.3.patch, 
> HIVE-22489.4.patch, HIVE-22489.5.patch, HIVE-22489.6.patch, 
> HIVE-22489.7.patch, HIVE-22489.8.patch, HIVE-22489.9.patch, HIVE-22489.9.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is 
> explicitly specified in the ORDER BY clause of the query null ordering should 
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
>  A masked pattern was here 
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
>  A masked pattern was here 
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: src1
>   filterExpr: key is not null (type: boolean)
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
> Select Operator
>   expressions: key (type: string)
>   outputColumnNames: _col0
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic 
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: src
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
>  A masked pattern was here 
> name default.src
> numFiles 1
> numRows 500
> 

[jira] [Commented] (HIVE-22725) Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017687#comment-17017687
 ] 

Hive QA commented on HIVE-22725:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 0s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m  
9s{color} | {color:blue} standalone-metastore/metastore-server in master has 
181 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
55s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20217/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20217/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation
> 
>
> Key: HIVE-22725
> URL: https://issues.apache.org/jira/browse/HIVE-22725
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-22725.1.patch, HIVE-22725.2.patch, 
> HIVE-22725.3.patch, HIVE-22725.4.patch, image-2020-01-14-13-22-54-483.png
>
>
> "TransactionalValidationListener" gets added in the pre-event listeners of 
> HMS by default.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L559]
> This causes issue in short select queries, as table details are computed for 
> any partition lookups.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L4984]
>  
> !image-2020-01-14-13-22-54-483.png|width=579,height=202!
>  
> It would be good to lazy evaluate table lookup in 

[jira] [Updated] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version

2020-01-16 Thread Alice Fan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alice Fan updated HIVE-22739:
-
Attachment: HIVE-22739.1.patch
Status: Patch Available  (was: Open)

> Schematool should check if upgradeFrom version is identical to current DB 
> schema version
> 
>
> Key: HIVE-22739
> URL: https://issues.apache.org/jira/browse/HIVE-22739
> Project: Hive
>  Issue Type: Bug
>  Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-22739.1.patch
>
>
> Schematool should check if upgradeFrom version is identical to current DB 
> schema version.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41
> We should check if the user input fromVersion is identical to current DB 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22706) Jdbc storage handler incorrectly interprets boolean column value in derby

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017680#comment-17017680
 ] 

Hive QA commented on HIVE-22706:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991126/HIVE-22706.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17877 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20216/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20216/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20216/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991126 - PreCommit-HIVE-Build

> Jdbc storage handler incorrectly interprets boolean column value in derby
> -
>
> Key: HIVE-22706
> URL: https://issues.apache.org/jira/browse/HIVE-22706
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22706.01.patch, HIVE-22706.01.patch, 
> HIVE-22706.01.patch, HIVE-22706.01.patch, HIVE-22706.02.patch, 
> HIVE-22706.02.patch, HIVE-22706.02.patch, HIVE-22706.02.patch
>
>
> in case the column value is false ; the storage handler interprets it as true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22706) Jdbc storage handler incorrectly interprets boolean column value in derby

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017659#comment-17017659
 ] 

Hive QA commented on HIVE-22706:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
54s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
23s{color} | {color:blue} jdbc-handler in master has 11 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m  
9s{color} | {color:red} jdbc-handler: The patch generated 6 new + 40 unchanged 
- 1 fixed = 46 total (was 41) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 59s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20216/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20216/yetus/diff-checkstyle-jdbc-handler.txt
 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20216/yetus/whitespace-eol.txt
 |
| modules | C: ql jdbc-handler U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20216/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Jdbc storage handler incorrectly interprets boolean column value in derby
> -
>
> Key: HIVE-22706
> URL: https://issues.apache.org/jira/browse/HIVE-22706
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22706.01.patch, HIVE-22706.01.patch, 
> HIVE-22706.01.patch, HIVE-22706.01.patch, HIVE-22706.02.patch, 
> HIVE-22706.02.patch, HIVE-22706.02.patch, HIVE-22706.02.patch
>
>
> in case the column value is false ; the storage handler interprets it as true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017641#comment-17017641
 ] 

Hive QA commented on HIVE-22730:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991180/HIVE-22730.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17877 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20215/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20215/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20215/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991180 - PreCommit-HIVE-Build

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, HIVE-22730.4.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017594#comment-17017594
 ] 

Hive QA commented on HIVE-22730:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
11s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m  0s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20215/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20215/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, HIVE-22730.4.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20974) TezTask should set task exception on failures

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017586#comment-17017586
 ] 

Hive QA commented on HIVE-20974:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991116/HIVE-20974.2.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20214/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20214/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20214/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12991116/HIVE-20974.2.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991116 - PreCommit-HIVE-Build

> TezTask should set task exception on failures
> -
>
> Key: HIVE-20974
> URL: https://issues.apache.org/jira/browse/HIVE-20974
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-20974.1.patch, HIVE-20974.2.patch
>
>
> TezTask logs the error as "Failed to execute tez graph" and proceeds further. 
> "TaskRunner.runSequentail()" code would not be able to get these exceptions 
> for TezTask. If there are any failure hooks configured, these exceptions 
> wouldn't show up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20974) TezTask should set task exception on failures

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017585#comment-17017585
 ] 

Hive QA commented on HIVE-20974:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991116/HIVE-20974.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17877 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20213/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20213/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20213/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991116 - PreCommit-HIVE-Build

> TezTask should set task exception on failures
> -
>
> Key: HIVE-20974
> URL: https://issues.apache.org/jira/browse/HIVE-20974
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-20974.1.patch, HIVE-20974.2.patch
>
>
> TezTask logs the error as "Failed to execute tez graph" and proceeds further. 
> "TaskRunner.runSequentail()" code would not be able to get these exceptions 
> for TezTask. If there are any failure hooks configured, these exceptions 
> wouldn't show up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20974) TezTask should set task exception on failures

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017563#comment-17017563
 ] 

Hive QA commented on HIVE-20974:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
15s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20213/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20213/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> TezTask should set task exception on failures
> -
>
> Key: HIVE-20974
> URL: https://issues.apache.org/jira/browse/HIVE-20974
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-20974.1.patch, HIVE-20974.2.patch
>
>
> TezTask logs the error as "Failed to execute tez graph" and proceeds further. 
> "TaskRunner.runSequentail()" code would not be able to get these exceptions 
> for TezTask. If there are any failure hooks configured, these exceptions 
> wouldn't show up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Attachment: HIVE-22730.4.patch

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, HIVE-22730.4.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22735) TopNKey operator deduplication

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017544#comment-17017544
 ] 

Jesus Camacho Rodriguez commented on HIVE-22735:


+1 (pending tests)

> TopNKey operator deduplication
> --
>
> Key: HIVE-22735
> URL: https://issues.apache.org/jira/browse/HIVE-22735
> Project: Hive
>  Issue Type: Improvement
>  Components: Physical Optimizer
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22735.1.patch
>
>
> In some cases more than one TNK operator has the same expressions in the same 
> operator tree or the difference is only a constant column. Most of this cases 
> only one TNK op. should remain.
> {code}
> ++
> |  Explain   |
> ++
> | Plan not optimized by CBO. |
> ||
> | Vertex dependency in root stage|
> | Map 1 <- Reducer 8 (BROADCAST_EDGE)|
> | Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 5 (SIMPLE_EDGE), Map 6 
> (BROADCAST_EDGE), Map 7 (BROADCAST_EDGE), Map 9 (BROADCAST_EDGE) |
> | Reducer 3 <- Reducer 2 (SIMPLE_EDGE)   |
> | Reducer 4 <- Reducer 3 (SIMPLE_EDGE)   |
> | Reducer 8 <- Map 7 (CUSTOM_SIMPLE_EDGE)|
> ||
> | Stage-0|
> |   Fetch Operator   |
> | limit:50   |
> | Stage-1|
> |   Reducer 4 vectorized |
> |   File Output Operator [FS_127]|
> | Limit [LIM_126] (rows=50 width=538)|
> |   Number of rows:50|
> |   Select Operator [SEL_125] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> |   <-Reducer 3 [SIMPLE_EDGE]|
> | SHUFFLE [RS_30]|
> |   Select Operator [SEL_29] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> | Group By Operator [GBY_28] (rows=190 width=538) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(VALUE._col0)","avg(VALUE._col1)","avg(VALUE._col2)","avg(VALUE._col3)"],keys:KEY._col0,
>  KEY._col1, KEY._col2 |
> | <-Reducer 2 [SIMPLE_EDGE]  |
> |   SHUFFLE [RS_27]  |
> | PartitionCols:_col0, _col1, _col2 |
> | Group By Operator [GBY_26] (rows=190 width=1134) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(_col9)","avg(_col11)","avg(_col18)","avg(_col12)"],keys:_col102,
>  _col93, 0L |
> |   Top N Key Operator [TNK_60] (rows=127 width=234) |
> | keys:_col102, _col93, 0L,top n:50 |
> | Select Operator [SEL_25] (rows=127 width=234) |
> |   
> Output:["_col9","_col11","_col12","_col18","_col93","_col102"] |
> |   Top N Key Operator [TNK_58] (rows=127 width=234) |
> | keys:_col102, _col93,top n:50 |
> | Filter Operator [FIL_49] (rows=127 width=234) |
> |   predicate:((_col22 = _col38) and (_col1 = 
> _col101) and (_col6 = _col69) and (_col3 = _col26)) |
> |   Map Join Operator [MAPJOIN_102] (rows=2044 
> width=232) |
> | 
> Conds:MAPJOIN_101._col1=RS_123.i_item_sk(Inner),Output:["_col1","_col3","_col6","_col9","_col11","_col12","_col18","_col22","_col26","_col38","_col69","_col93","_col101","_col102"]
>  |
> |   <-Map 9 [BROADCAST_EDGE] vectorized |
> | BROADCAST [RS_123] |
> |   PartitionCols:i_item_sk |
> |   Filter Operator [FIL_122] (rows=204000 
> width=108) |
> | predicate:i_item_sk is not null |
> | TableScan [TS_4] (rows=204000 
> width=108) |
> |   
> tpcds_bin_partitioned_orc_100@item,item, ACID 
> table,Tbl:COMPLETE,Col:COMPLETE,Output:["i_item_sk","i_item_id"] |
> |   <-Map Join Operator [MAPJOIN_101] (rows=2010 
> 

[jira] [Commented] (HIVE-22663) Quote all table and column names or do not quote any

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017542#comment-17017542
 ] 

Hive QA commented on HIVE-22663:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991093/HIVE-22663.5.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17877 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestMetastoreHousekeepingLeaderEmptyConfig.testHouseKeepingThreadExistence
 (batchId=247)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20212/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20212/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20212/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991093 - PreCommit-HIVE-Build

> Quote all table and column names or do not quote any
> 
>
> Key: HIVE-22663
> URL: https://issues.apache.org/jira/browse/HIVE-22663
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2, Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Ashutosh Bapat
>Assignee: Zoltan Chovan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22663.2.patch, HIVE-22663.3.patch, 
> HIVE-22663.4.patch, HIVE-22663.5.patch, HIVE-22663.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The change in HIVE-22546 is causing following stack trace when I run Hive 
> with PostgreSQL as backend db for the metastore.
> 0: jdbc:hive2://localhost:1> create database dumpdb with 
> ('repl.source.for'='1,2,3');0: jdbc:hive2://localhost:1> create database 
> dumpdb with ('repl.source.for'='1,2,3');Error: Error while compiling 
> statement: FAILED: ParseException line 1:28 missing KW_DBPROPERTIES at '(' 
> near '' (state=42000,code=4)0: jdbc:hive2://localhost:1> create 
> database dumpdb with dbproperties ('repl.source.for'='1,2,3');ERROR : FAILED: 
> Hive Internal Error: org.apache.hadoop.hive.ql.lockmgr.LockException(Error 
> communicating with the 
> metastore)org.apache.hadoop.hive.ql.lockmgr.LockException: Error 
> communicating with the metastore at 
> org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.commitTxn(DbTxnManager.java:541)
>  at 
> org.apache.hadoop.hive.ql.Driver.releaseLocksAndCommitOrRollback(Driver.java:687)
>  at 
> org.apache.hadoop.hive.ql.Driver.releaseLocksAndCommitOrRollback(Driver.java:653)
>  at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:969)
> ... stack trace clipped
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)Caused by: 
> MetaException(message:Unable to update transaction database 
> org.postgresql.util.PSQLException: ERROR: relation 
> "materialization_rebuild_locks" does not exist  Position: 13 at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2440)
>  at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2183)
>  at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:308) 
> at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:441) at 
> org.postgresql.jdbc.PgStatement.execute(PgStatement.java:365) at 
> This happens because the table names in all the queries in TxnHandler.java 
> (including the one at 1312, which causes this stack trace) are not quoting 
> the table names. All the tablenames and column names should be quoted there. 
> Just the change in HIVE-22546 won't suffice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22738) CVE-2019-0205

2020-01-16 Thread Laurent Goujon (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laurent Goujon updated HIVE-22738:
--
Attachment: (was: image-2020-01-16-10-27-11-933.png)

> CVE-2019-0205
> -
>
> Key: HIVE-22738
> URL: https://issues.apache.org/jira/browse/HIVE-22738
> Project: Hive
>  Issue Type: Bug
>  Components: Thrift API
>Reporter: Laurent Goujon
>Priority: Major
>
> There's has been a CVE issued for a Thrift vulnerability which might impact 
> Hive. The CVE is 
> [CVE-2019-0205|https://nvd.nist.gov/vuln/detail/CVE-2019-0205], impacts both 
> clients and servers, and might cause a denial of service through an infinite 
> loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22738) CVE-2019-0205

2020-01-16 Thread Laurent Goujon (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laurent Goujon updated HIVE-22738:
--
Attachment: (was: image-2020-01-16-10-25-33-064.png)

> CVE-2019-0205
> -
>
> Key: HIVE-22738
> URL: https://issues.apache.org/jira/browse/HIVE-22738
> Project: Hive
>  Issue Type: Bug
>  Components: Thrift API
>Reporter: Laurent Goujon
>Priority: Major
> Attachments: image-2020-01-16-10-27-11-933.png
>
>
> There's has been a CVE issued for a Thrift vulnerability which might impact 
> Hive. The CVE is 
> [CVE-2019-0205|https://nvd.nist.gov/vuln/detail/CVE-2019-0205], impacts both 
> clients and servers, and might cause a denial of service through an infinite 
> loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22728) Limit the scope of uniqueness of constraint name to database

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017537#comment-17017537
 ] 

Jesus Camacho Rodriguez commented on HIVE-22728:


[~pvary], yes, sounds reasonable.

> Limit the scope of uniqueness of constraint name to database
> 
>
> Key: HIVE-22728
> URL: https://issues.apache.org/jira/browse/HIVE-22728
> Project: Hive
>  Issue Type: Wish
>Reporter: Jesus Camacho Rodriguez
>Priority: Major
>
> Currently, constraint names are globally unique across all databases 
> (assumption is that this may have done by design). Nevertheless, though 
> behavior seems to be implementation specific, it would be interesting to 
> limit the scope to uniqueness per database.
> Currently we do not store database information with the constraints. To 
> change the scope to one db, we would need to store the DB_ID in the 
> KEY_CONSTRAINTS table in metastore when we create a constraint and add the 
> DB_ID to the PRIMARY KEY of that table. Some minor changes to the error 
> messages would be needed too, since otherwise it would be difficult to 
> identify the correct violation in queries that span across multiple 
> databases. Additionally, the SQL scripts will need to be updated to populate 
> the DB_ID when we upgrade to new version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22663) Quote all table and column names or do not quote any

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017520#comment-17017520
 ] 

Hive QA commented on HIVE-22663:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
20s{color} | {color:blue} standalone-metastore/metastore-server in master has 
181 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
19s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
23s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 98 new + 486 unchanged - 79 fixed = 584 total (was 565) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m  6s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20212/dev-support/hive-personality.sh
 |
| git revision | master / bd8fa5c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20212/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
 |
| modules | C: standalone-metastore/metastore-server ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20212/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Quote all table and column names or do not quote any
> 
>
> Key: HIVE-22663
> URL: https://issues.apache.org/jira/browse/HIVE-22663
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2, Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Ashutosh Bapat
>Assignee: Zoltan Chovan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22663.2.patch, HIVE-22663.3.patch, 
> HIVE-22663.4.patch, HIVE-22663.5.patch, HIVE-22663.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The change in HIVE-22546 is causing following stack trace when I run Hive 
> with PostgreSQL as backend db for the metastore.
> 0: jdbc:hive2://localhost:1> create database dumpdb with 
> ('repl.source.for'='1,2,3');0: jdbc:hive2://localhost:1> create database 
> dumpdb 

[jira] [Commented] (HIVE-22727) Add hive db schema changes introduced in HIVE-21884 to the schema upgrade scripts

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017491#comment-17017491
 ] 

Hive QA commented on HIVE-22727:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991094/HIVE-22727.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17876 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query3] 
(batchId=303)
org.apache.hive.jdbc.TestXSRFFilter.testFilterEnabledWithInjection (batchId=286)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20211/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20211/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20211/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991094 - PreCommit-HIVE-Build

> Add hive db schema changes introduced in HIVE-21884 to the schema upgrade 
> scripts
> -
>
> Key: HIVE-22727
> URL: https://issues.apache.org/jira/browse/HIVE-22727
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HIVE-22727.2.patch, HIVE-22727.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version

2020-01-16 Thread Alice Fan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alice Fan reassigned HIVE-22739:



> Schematool should check if upgradeFrom version is identical to current DB 
> schema version
> 
>
> Key: HIVE-22739
> URL: https://issues.apache.org/jira/browse/HIVE-22739
> Project: Hive
>  Issue Type: Bug
>  Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
>
> Schematool should check if upgradeFrom version is identical to current DB 
> schema version.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41
> We should check if the user input fromVersion is identical to current DB 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22713) Constant propagation shouldn't be done for Join-Fil(*)-RS structure

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22713:
---
Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master, thanks [~rameshkumar]!

> Constant propagation shouldn't be done for Join-Fil(*)-RS structure
> ---
>
> Key: HIVE-22713
> URL: https://issues.apache.org/jira/browse/HIVE-22713
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22713.1.patch, HIVE-22713.2.patch
>
>
> Constant propagation shouldn't be done for Join-Fil(*)-RS structure too. 
> Since we output columns from the join if the structure is Join-Fil(*)-RS, the 
> expressions shouldn't be modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22727) Add hive db schema changes introduced in HIVE-21884 to the schema upgrade scripts

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017435#comment-17017435
 ] 

Hive QA commented on HIVE-22727:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20211/dev-support/hive-personality.sh
 |
| git revision | master / d5cfea6 |
| modules | C: metastore U: metastore |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20211/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Add hive db schema changes introduced in HIVE-21884 to the schema upgrade 
> scripts
> -
>
> Key: HIVE-22727
> URL: https://issues.apache.org/jira/browse/HIVE-22727
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HIVE-22727.2.patch, HIVE-22727.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HIVE-22341) abortTxns statements should be executed in a single transaction

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez resolved HIVE-22341.

Resolution: Not A Problem

[~hamvas.aron], [~dkuzmenko], thanks for investigating this. It seems it is not 
an issue so I am closing it.

> abortTxns statements should be executed in a single transaction
> ---
>
> Key: HIVE-22341
> URL: https://issues.apache.org/jira/browse/HIVE-22341
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Jesus Camacho Rodriguez
>Priority: Major
>
> Logic in `abortTxns` should be executed in a single transaction, rather than 
> multiple ones. Otherwise, if you restart HMS between txn abort and the lock 
> deletion, we end up with orphaned locks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22627) Add schema changes introduced in HIVE-21443 to the schema upgrade scripts

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017433#comment-17017433
 ] 

Hive QA commented on HIVE-22627:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991095/HIVE-22627.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17876 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucket6] 
(batchId=197)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20210/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20210/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20210/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991095 - PreCommit-HIVE-Build

> Add schema changes introduced in HIVE-21443 to the schema upgrade scripts
> -
>
> Key: HIVE-22627
> URL: https://issues.apache.org/jira/browse/HIVE-22627
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22627.2.patch, HIVE-22627.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-21425) Use DirectExecutorService for getInputSummary

2020-01-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21425?focusedWorklogId=373211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373211
 ]

ASF GitHub Bot logged work on HIVE-21425:
-

Author: ASF GitHub Bot
Created on: 16/Jan/20 19:00
Start Date: 16/Jan/20 19:00
Worklog Time Spent: 10m 
  Work Description: belugabehr commented on issue #564: HIVE-21425: Use 
DirectExecutorService for getInputSummary
URL: https://github.com/apache/hive/pull/564#issuecomment-575295689
 
 
   Done
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 373211)
Time Spent: 20m  (was: 10m)

> Use DirectExecutorService for getInputSummary
> -
>
> Key: HIVE-21425
> URL: https://issues.apache.org/jira/browse/HIVE-21425
> Project: Hive
>  Issue Type: Improvement
>  Components: HiveServer2
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21425.1.patch, HIVE-21425.1.patch, 
> HIVE-21425.1.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:java|title=Utilities.java}
>   int numExecutors = getMaxExecutorsForInputListing(ctx.getConf(), 
> pathNeedProcess.size());
>   if (numExecutors > 1) {
> LOG.info("Using {} threads for getContentSummary", numExecutors);
> executor = Executors.newFixedThreadPool(numExecutors,
> new ThreadFactoryBuilder().setDaemon(true)
> .setNameFormat("Get-Input-Summary-%d").build());
>   } else {
> executor = null;
>   }
> {code}
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L2482-L2490
> Instead of using a 'null' {{ExecutorService}}, use Guava's 
> {{DirectExecutorService}} and remove special casing for a 'null' value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-21425) Use DirectExecutorService for getInputSummary

2020-01-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21425?focusedWorklogId=373212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373212
 ]

ASF GitHub Bot logged work on HIVE-21425:
-

Author: ASF GitHub Bot
Created on: 16/Jan/20 19:00
Start Date: 16/Jan/20 19:00
Worklog Time Spent: 10m 
  Work Description: belugabehr commented on pull request #564: HIVE-21425: 
Use DirectExecutorService for getInputSummary
URL: https://github.com/apache/hive/pull/564
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 373212)
Time Spent: 0.5h  (was: 20m)

> Use DirectExecutorService for getInputSummary
> -
>
> Key: HIVE-21425
> URL: https://issues.apache.org/jira/browse/HIVE-21425
> Project: Hive
>  Issue Type: Improvement
>  Components: HiveServer2
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21425.1.patch, HIVE-21425.1.patch, 
> HIVE-21425.1.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {code:java|title=Utilities.java}
>   int numExecutors = getMaxExecutorsForInputListing(ctx.getConf(), 
> pathNeedProcess.size());
>   if (numExecutors > 1) {
> LOG.info("Using {} threads for getContentSummary", numExecutors);
> executor = Executors.newFixedThreadPool(numExecutors,
> new ThreadFactoryBuilder().setDaemon(true)
> .setNameFormat("Get-Input-Summary-%d").build());
>   } else {
> executor = null;
>   }
> {code}
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L2482-L2490
> Instead of using a 'null' {{ExecutorService}}, use Guava's 
> {{DirectExecutorService}} and remove special casing for a 'null' value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-21426) Remove Utilities Global Random

2020-01-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21426?focusedWorklogId=373209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373209
 ]

ASF GitHub Bot logged work on HIVE-21426:
-

Author: ASF GitHub Bot
Created on: 16/Jan/20 18:59
Start Date: 16/Jan/20 18:59
Worklog Time Spent: 10m 
  Work Description: belugabehr commented on issue #565: HIVE-21426: Remove 
Utilities Global Random
URL: https://github.com/apache/hive/pull/565#issuecomment-575295397
 
 
   Done.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 373209)
Time Spent: 20m  (was: 10m)

> Remove Utilities Global Random
> --
>
> Key: HIVE-21426
> URL: https://issues.apache.org/jira/browse/HIVE-21426
> Project: Hive
>  Issue Type: Improvement
>  Components: HiveServer2
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21426.1.patch, HIVE-21426.2.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L253
> Remove global {{Random}} object in favor of {{ThreadLocalRandom}}.
> {quote}
> ThreadLocalRandom is initialized with an internally generated seed that may 
> not otherwise be modified. When applicable, use of ThreadLocalRandom rather 
> than shared Random objects in concurrent programs will typically encounter 
> much less overhead and contention.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-21426) Remove Utilities Global Random

2020-01-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21426?focusedWorklogId=373210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373210
 ]

ASF GitHub Bot logged work on HIVE-21426:
-

Author: ASF GitHub Bot
Created on: 16/Jan/20 18:59
Start Date: 16/Jan/20 18:59
Worklog Time Spent: 10m 
  Work Description: belugabehr commented on pull request #565: HIVE-21426: 
Remove Utilities Global Random
URL: https://github.com/apache/hive/pull/565
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 373210)
Time Spent: 0.5h  (was: 20m)

> Remove Utilities Global Random
> --
>
> Key: HIVE-21426
> URL: https://issues.apache.org/jira/browse/HIVE-21426
> Project: Hive
>  Issue Type: Improvement
>  Components: HiveServer2
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21426.1.patch, HIVE-21426.2.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L253
> Remove global {{Random}} object in favor of {{ThreadLocalRandom}}.
> {quote}
> ThreadLocalRandom is initialized with an internally generated seed that may 
> not otherwise be modified. When applicable, use of ThreadLocalRandom rather 
> than shared Random objects in concurrent programs will typically encounter 
> much less overhead and contention.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22486:
---
Attachment: HIVE-22486.91.patch

> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.90.patch, HIVE-22486.90.patch, HIVE-22486.91.patch, 
> HIVE-22486.91.patch, HIVE-22486.91.patch, HIVE-22486.91.patch, 
> HIVE-22486.91.patch, HIVE-22486.patch, HIVE-22486.patchaddendum
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22713) Constant propagation shouldn't be done for Join-Fil(*)-RS structure

2020-01-16 Thread Jesus Camacho Rodriguez (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017410#comment-17017410
 ] 

Jesus Camacho Rodriguez commented on HIVE-22713:


+1

> Constant propagation shouldn't be done for Join-Fil(*)-RS structure
> ---
>
> Key: HIVE-22713
> URL: https://issues.apache.org/jira/browse/HIVE-22713
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22713.1.patch, HIVE-22713.2.patch
>
>
> Constant propagation shouldn't be done for Join-Fil(*)-RS structure too. 
> Since we output columns from the join if the structure is Join-Fil(*)-RS, the 
> expressions shouldn't be modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22627) Add schema changes introduced in HIVE-21443 to the schema upgrade scripts

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017391#comment-17017391
 ] 

Hive QA commented on HIVE-22627:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 2s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20210/dev-support/hive-personality.sh
 |
| git revision | master / d5cfea6 |
| modules | C: metastore U: metastore |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20210/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Add schema changes introduced in HIVE-21443 to the schema upgrade scripts
> -
>
> Key: HIVE-22627
> URL: https://issues.apache.org/jira/browse/HIVE-22627
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22627.2.patch, HIVE-22627.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017377#comment-17017377
 ] 

Hive QA commented on HIVE-22730:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991124/HIVE-22730.3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17876 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2]
 (batchId=114)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20209/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20209/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20209/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991124 - PreCommit-HIVE-Build

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22666) Introduce TopNKey operator for PTF Reduce Sink

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22666:
--
Attachment: HIVE-22666.3.patch

> Introduce TopNKey operator for PTF Reduce Sink
> --
>
> Key: HIVE-22666
> URL: https://issues.apache.org/jira/browse/HIVE-22666
> Project: Hive
>  Issue Type: Improvement
>Reporter: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22666.1.patch, HIVE-22666.2.patch, 
> HIVE-22666.3.patch
>
>
> {code}
> EXPLAIN EXTENDED
> SELECT s_state, ranking
> FROM (
>  SELECT s_state AS s_state,
>  rank() OVER (PARTITION BY s_state ORDER BY ss_net_profit) AS ranking
>  FROM testtable_n1000) tmp1
>  WHERE ranking <= 3;
> {code}
> {code}
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: testtable_n1000
>   Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Reduce Output Operator
> key expressions: s_state (type: string), ss_net_profit 
> (type: double)
> null sort order: az
> sort order: ++
> Map-reduce partition columns: s_state (type: string)
> Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
> tag: -1
> TopN: 4
> TopN Hash Memory Usage: 0.1
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: testtable_n1000
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns s_state,ss_net_profit
> columns.comments 
> columns.types string:double
>  A masked pattern was here 
> name default.testtable_n1000
> numFiles 1
> numRows 10
> rawDataSize 80
> serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
> serialization.format 1
> serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 90
>  A masked pattern was here 
>   serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> 
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
>   COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
>   bucket_count -1
>   bucketing_version 2
>   column.name.delimiter ,
>   columns s_state,ss_net_profit
>   columns.comments 
>   columns.types string:double
>  A masked pattern was here 
>   name default.testtable_n1000
>   numFiles 1
>   numRows 10
>   rawDataSize 80
>   serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
>   serialization.format 1
>   serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
>   totalSize 90
>  A masked pattern was here 
> serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> name: default.testtable_n1000
>   name: default.testtable_n1000
> Truncated Path -> Alias:
>   /testtable_n1000 [testtable_n1000]
> Reducer 2 
> Execution mode: vectorized, llap
>   

[jira] [Updated] (HIVE-22666) Introduce TopNKey operator for PTF Reduce Sink

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22666:
--
Status: Patch Available  (was: Open)

> Introduce TopNKey operator for PTF Reduce Sink
> --
>
> Key: HIVE-22666
> URL: https://issues.apache.org/jira/browse/HIVE-22666
> Project: Hive
>  Issue Type: Improvement
>Reporter: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22666.1.patch, HIVE-22666.2.patch, 
> HIVE-22666.3.patch
>
>
> {code}
> EXPLAIN EXTENDED
> SELECT s_state, ranking
> FROM (
>  SELECT s_state AS s_state,
>  rank() OVER (PARTITION BY s_state ORDER BY ss_net_profit) AS ranking
>  FROM testtable_n1000) tmp1
>  WHERE ranking <= 3;
> {code}
> {code}
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: testtable_n1000
>   Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Reduce Output Operator
> key expressions: s_state (type: string), ss_net_profit 
> (type: double)
> null sort order: az
> sort order: ++
> Map-reduce partition columns: s_state (type: string)
> Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
> tag: -1
> TopN: 4
> TopN Hash Memory Usage: 0.1
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: testtable_n1000
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns s_state,ss_net_profit
> columns.comments 
> columns.types string:double
>  A masked pattern was here 
> name default.testtable_n1000
> numFiles 1
> numRows 10
> rawDataSize 80
> serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
> serialization.format 1
> serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 90
>  A masked pattern was here 
>   serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> 
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
>   COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
>   bucket_count -1
>   bucketing_version 2
>   column.name.delimiter ,
>   columns s_state,ss_net_profit
>   columns.comments 
>   columns.types string:double
>  A masked pattern was here 
>   name default.testtable_n1000
>   numFiles 1
>   numRows 10
>   rawDataSize 80
>   serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
>   serialization.format 1
>   serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
>   totalSize 90
>  A masked pattern was here 
> serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> name: default.testtable_n1000
>   name: default.testtable_n1000
> Truncated Path -> Alias:
>   /testtable_n1000 [testtable_n1000]
> Reducer 2 
> Execution mode: vectorized, 

[jira] [Updated] (HIVE-22666) Introduce TopNKey operator for PTF Reduce Sink

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22666:
--
Status: Open  (was: Patch Available)

> Introduce TopNKey operator for PTF Reduce Sink
> --
>
> Key: HIVE-22666
> URL: https://issues.apache.org/jira/browse/HIVE-22666
> Project: Hive
>  Issue Type: Improvement
>Reporter: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22666.1.patch, HIVE-22666.2.patch, 
> HIVE-22666.3.patch
>
>
> {code}
> EXPLAIN EXTENDED
> SELECT s_state, ranking
> FROM (
>  SELECT s_state AS s_state,
>  rank() OVER (PARTITION BY s_state ORDER BY ss_net_profit) AS ranking
>  FROM testtable_n1000) tmp1
>  WHERE ranking <= 3;
> {code}
> {code}
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: testtable_n1000
>   Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Reduce Output Operator
> key expressions: s_state (type: string), ss_net_profit 
> (type: double)
> null sort order: az
> sort order: ++
> Map-reduce partition columns: s_state (type: string)
> Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
> tag: -1
> TopN: 4
> TopN Hash Memory Usage: 0.1
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: testtable_n1000
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns s_state,ss_net_profit
> columns.comments 
> columns.types string:double
>  A masked pattern was here 
> name default.testtable_n1000
> numFiles 1
> numRows 10
> rawDataSize 80
> serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
> serialization.format 1
> serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 90
>  A masked pattern was here 
>   serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> 
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
>   COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
>   bucket_count -1
>   bucketing_version 2
>   column.name.delimiter ,
>   columns s_state,ss_net_profit
>   columns.comments 
>   columns.types string:double
>  A masked pattern was here 
>   name default.testtable_n1000
>   numFiles 1
>   numRows 10
>   rawDataSize 80
>   serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
>   serialization.format 1
>   serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
>   totalSize 90
>  A masked pattern was here 
> serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> name: default.testtable_n1000
>   name: default.testtable_n1000
> Truncated Path -> Alias:
>   /testtable_n1000 [testtable_n1000]
> Reducer 2 
> Execution mode: vectorized, 

[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22489:
--
Attachment: HIVE-22489.13.patch

>  Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.10.patch, 
> HIVE-22489.10.patch, HIVE-22489.11.patch, HIVE-22489.12.patch, 
> HIVE-22489.13.patch, HIVE-22489.13.patch, HIVE-22489.13.patch, 
> HIVE-22489.2.patch, HIVE-22489.3.patch, HIVE-22489.3.patch, 
> HIVE-22489.4.patch, HIVE-22489.5.patch, HIVE-22489.6.patch, 
> HIVE-22489.7.patch, HIVE-22489.8.patch, HIVE-22489.9.patch, HIVE-22489.9.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is 
> explicitly specified in the ORDER BY clause of the query null ordering should 
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
>  A masked pattern was here 
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
>  A masked pattern was here 
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: src1
>   filterExpr: key is not null (type: boolean)
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
> Select Operator
>   expressions: key (type: string)
>   outputColumnNames: _col0
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic 
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: src
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
>  A masked pattern was here 
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> 

[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22489:
--
Status: Patch Available  (was: Open)

>  Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.10.patch, 
> HIVE-22489.10.patch, HIVE-22489.11.patch, HIVE-22489.12.patch, 
> HIVE-22489.13.patch, HIVE-22489.13.patch, HIVE-22489.13.patch, 
> HIVE-22489.2.patch, HIVE-22489.3.patch, HIVE-22489.3.patch, 
> HIVE-22489.4.patch, HIVE-22489.5.patch, HIVE-22489.6.patch, 
> HIVE-22489.7.patch, HIVE-22489.8.patch, HIVE-22489.9.patch, HIVE-22489.9.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is 
> explicitly specified in the ORDER BY clause of the query null ordering should 
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
>  A masked pattern was here 
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
>  A masked pattern was here 
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: src1
>   filterExpr: key is not null (type: boolean)
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
> Select Operator
>   expressions: key (type: string)
>   outputColumnNames: _col0
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic 
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: src
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
>  A masked pattern was here 
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> 

[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22489:
--
Status: Open  (was: Patch Available)

>  Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.10.patch, 
> HIVE-22489.10.patch, HIVE-22489.11.patch, HIVE-22489.12.patch, 
> HIVE-22489.13.patch, HIVE-22489.13.patch, HIVE-22489.2.patch, 
> HIVE-22489.3.patch, HIVE-22489.3.patch, HIVE-22489.4.patch, 
> HIVE-22489.5.patch, HIVE-22489.6.patch, HIVE-22489.7.patch, 
> HIVE-22489.8.patch, HIVE-22489.9.patch, HIVE-22489.9.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is 
> explicitly specified in the ORDER BY clause of the query null ordering should 
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
>  A masked pattern was here 
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
>  A masked pattern was here 
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: src1
>   filterExpr: key is not null (type: boolean)
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
> Select Operator
>   expressions: key (type: string)
>   outputColumnNames: _col0
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic 
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: src
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
>  A masked pattern was here 
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> serialization.ddl struct src 

[jira] [Commented] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017318#comment-17017318
 ] 

Hive QA commented on HIVE-22730:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
5s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 48s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20209/dev-support/hive-personality.sh
 |
| git revision | master / d5cfea6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20209/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22538:
--
Status: Patch Available  (was: Open)

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22538:
--
Status: Open  (was: Patch Available)

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017293#comment-17017293
 ] 

Hive QA commented on HIVE-22538:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991112/HIVE-22538.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17862 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=160)

[unionDistinct_1.q,table_nonprintable.q,file_with_header_footer_aggregation.q,vector_offset_limit.q,orc_llap_counters1.q,mm_cttas.q,whroot_external1.q,global_limit.q,rcfile_createas1.q,dynamic_partition_pruning_2.q,intersect_merge.q,results_cache_diff_fs.q,parallel_colstats.q,load_hdfs_file_with_space_in_the_name.q,orc_merge3.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[clusterctas] (batchId=55)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_4]
 (batchId=168)
org.apache.hadoop.hive.ql.TestAcidOnTez.testBucketedAcidInsertWithRemoveUnion 
(batchId=250)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20208/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20208/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20208/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991112 - PreCommit-HIVE-Build

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22735) TopNKey operator deduplication

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22735:
--
Attachment: HIVE-22735.1.patch

> TopNKey operator deduplication
> --
>
> Key: HIVE-22735
> URL: https://issues.apache.org/jira/browse/HIVE-22735
> Project: Hive
>  Issue Type: Improvement
>  Components: Physical Optimizer
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22735.1.patch
>
>
> In some cases more than one TNK operator has the same expressions in the same 
> operator tree or the difference is only a constant column. Most of this cases 
> only one TNK op. should remain.
> {code}
> ++
> |  Explain   |
> ++
> | Plan not optimized by CBO. |
> ||
> | Vertex dependency in root stage|
> | Map 1 <- Reducer 8 (BROADCAST_EDGE)|
> | Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 5 (SIMPLE_EDGE), Map 6 
> (BROADCAST_EDGE), Map 7 (BROADCAST_EDGE), Map 9 (BROADCAST_EDGE) |
> | Reducer 3 <- Reducer 2 (SIMPLE_EDGE)   |
> | Reducer 4 <- Reducer 3 (SIMPLE_EDGE)   |
> | Reducer 8 <- Map 7 (CUSTOM_SIMPLE_EDGE)|
> ||
> | Stage-0|
> |   Fetch Operator   |
> | limit:50   |
> | Stage-1|
> |   Reducer 4 vectorized |
> |   File Output Operator [FS_127]|
> | Limit [LIM_126] (rows=50 width=538)|
> |   Number of rows:50|
> |   Select Operator [SEL_125] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> |   <-Reducer 3 [SIMPLE_EDGE]|
> | SHUFFLE [RS_30]|
> |   Select Operator [SEL_29] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> | Group By Operator [GBY_28] (rows=190 width=538) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(VALUE._col0)","avg(VALUE._col1)","avg(VALUE._col2)","avg(VALUE._col3)"],keys:KEY._col0,
>  KEY._col1, KEY._col2 |
> | <-Reducer 2 [SIMPLE_EDGE]  |
> |   SHUFFLE [RS_27]  |
> | PartitionCols:_col0, _col1, _col2 |
> | Group By Operator [GBY_26] (rows=190 width=1134) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(_col9)","avg(_col11)","avg(_col18)","avg(_col12)"],keys:_col102,
>  _col93, 0L |
> |   Top N Key Operator [TNK_60] (rows=127 width=234) |
> | keys:_col102, _col93, 0L,top n:50 |
> | Select Operator [SEL_25] (rows=127 width=234) |
> |   
> Output:["_col9","_col11","_col12","_col18","_col93","_col102"] |
> |   Top N Key Operator [TNK_58] (rows=127 width=234) |
> | keys:_col102, _col93,top n:50 |
> | Filter Operator [FIL_49] (rows=127 width=234) |
> |   predicate:((_col22 = _col38) and (_col1 = 
> _col101) and (_col6 = _col69) and (_col3 = _col26)) |
> |   Map Join Operator [MAPJOIN_102] (rows=2044 
> width=232) |
> | 
> Conds:MAPJOIN_101._col1=RS_123.i_item_sk(Inner),Output:["_col1","_col3","_col6","_col9","_col11","_col12","_col18","_col22","_col26","_col38","_col69","_col93","_col101","_col102"]
>  |
> |   <-Map 9 [BROADCAST_EDGE] vectorized |
> | BROADCAST [RS_123] |
> |   PartitionCols:i_item_sk |
> |   Filter Operator [FIL_122] (rows=204000 
> width=108) |
> | predicate:i_item_sk is not null |
> | TableScan [TS_4] (rows=204000 
> width=108) |
> |   
> tpcds_bin_partitioned_orc_100@item,item, ACID 
> table,Tbl:COMPLETE,Col:COMPLETE,Output:["i_item_sk","i_item_id"] |
> |   <-Map Join Operator [MAPJOIN_101] (rows=2010 
> width=118) |
> | 

[jira] [Updated] (HIVE-22735) TopNKey operator deduplication

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22735:
--
Status: Patch Available  (was: Open)

> TopNKey operator deduplication
> --
>
> Key: HIVE-22735
> URL: https://issues.apache.org/jira/browse/HIVE-22735
> Project: Hive
>  Issue Type: Improvement
>  Components: Physical Optimizer
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22735.1.patch
>
>
> In some cases more than one TNK operator has the same expressions in the same 
> operator tree or the difference is only a constant column. Most of this cases 
> only one TNK op. should remain.
> {code}
> ++
> |  Explain   |
> ++
> | Plan not optimized by CBO. |
> ||
> | Vertex dependency in root stage|
> | Map 1 <- Reducer 8 (BROADCAST_EDGE)|
> | Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 5 (SIMPLE_EDGE), Map 6 
> (BROADCAST_EDGE), Map 7 (BROADCAST_EDGE), Map 9 (BROADCAST_EDGE) |
> | Reducer 3 <- Reducer 2 (SIMPLE_EDGE)   |
> | Reducer 4 <- Reducer 3 (SIMPLE_EDGE)   |
> | Reducer 8 <- Map 7 (CUSTOM_SIMPLE_EDGE)|
> ||
> | Stage-0|
> |   Fetch Operator   |
> | limit:50   |
> | Stage-1|
> |   Reducer 4 vectorized |
> |   File Output Operator [FS_127]|
> | Limit [LIM_126] (rows=50 width=538)|
> |   Number of rows:50|
> |   Select Operator [SEL_125] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> |   <-Reducer 3 [SIMPLE_EDGE]|
> | SHUFFLE [RS_30]|
> |   Select Operator [SEL_29] (rows=190 width=538) |
> | 
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"] |
> | Group By Operator [GBY_28] (rows=190 width=538) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(VALUE._col0)","avg(VALUE._col1)","avg(VALUE._col2)","avg(VALUE._col3)"],keys:KEY._col0,
>  KEY._col1, KEY._col2 |
> | <-Reducer 2 [SIMPLE_EDGE]  |
> |   SHUFFLE [RS_27]  |
> | PartitionCols:_col0, _col1, _col2 |
> | Group By Operator [GBY_26] (rows=190 width=1134) |
> |   
> Output:["_col0","_col1","_col2","_col3","_col4","_col5","_col6"],aggregations:["avg(_col9)","avg(_col11)","avg(_col18)","avg(_col12)"],keys:_col102,
>  _col93, 0L |
> |   Top N Key Operator [TNK_60] (rows=127 width=234) |
> | keys:_col102, _col93, 0L,top n:50 |
> | Select Operator [SEL_25] (rows=127 width=234) |
> |   
> Output:["_col9","_col11","_col12","_col18","_col93","_col102"] |
> |   Top N Key Operator [TNK_58] (rows=127 width=234) |
> | keys:_col102, _col93,top n:50 |
> | Filter Operator [FIL_49] (rows=127 width=234) |
> |   predicate:((_col22 = _col38) and (_col1 = 
> _col101) and (_col6 = _col69) and (_col3 = _col26)) |
> |   Map Join Operator [MAPJOIN_102] (rows=2044 
> width=232) |
> | 
> Conds:MAPJOIN_101._col1=RS_123.i_item_sk(Inner),Output:["_col1","_col3","_col6","_col9","_col11","_col12","_col18","_col22","_col26","_col38","_col69","_col93","_col101","_col102"]
>  |
> |   <-Map 9 [BROADCAST_EDGE] vectorized |
> | BROADCAST [RS_123] |
> |   PartitionCols:i_item_sk |
> |   Filter Operator [FIL_122] (rows=204000 
> width=108) |
> | predicate:i_item_sk is not null |
> | TableScan [TS_4] (rows=204000 
> width=108) |
> |   
> tpcds_bin_partitioned_orc_100@item,item, ACID 
> table,Tbl:COMPLETE,Col:COMPLETE,Output:["i_item_sk","i_item_id"] |
> |   <-Map Join Operator [MAPJOIN_101] (rows=2010 
> width=118) |
> |   

[jira] [Commented] (HIVE-22685) TestHiveSqlDateTimeFormatter Now Broken with New Year 2020

2020-01-16 Thread Karen Coppage (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017071#comment-17017071
 ] 

Karen Coppage commented on HIVE-22685:
--

[~kuczoram]  :) 

> TestHiveSqlDateTimeFormatter Now Broken with New Year 2020
> --
>
> Key: HIVE-22685
> URL: https://issues.apache.org/jira/browse/HIVE-22685
> Project: Hive
>  Issue Type: Bug
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22685.1.patch, HIVE-22685.2.patch, 
> HIVE-22685.3.patch
>
>
> Unit test is now broken (n)(n):(
> {code:java}
> //Tests for these patterns would need changing every decade if done in 
> the above way.
> //Thursday of the first week in an ISO year always matches the Gregorian 
> year.
> checkParseTimestampIso("IY-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> checkParseTimestampIso("I-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> {code}
> {code}
> org.junit.ComparisonFailure: expected:<01, 20[1]0> but was:<01, 20[2]0>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.checkParseTimestampIso(TestHiveSqlDateTimeFormatter.java:313)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.testParseTimestamp(TestHiveSqlDateTimeFormatter.java:287)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22685) TestHiveSqlDateTimeFormatter Now Broken with New Year 2020

2020-01-16 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017065#comment-17017065
 ] 

David Mollitor commented on HIVE-22685:
---

[~ngangam] [~pvary] Can you please chime in? :)

> TestHiveSqlDateTimeFormatter Now Broken with New Year 2020
> --
>
> Key: HIVE-22685
> URL: https://issues.apache.org/jira/browse/HIVE-22685
> Project: Hive
>  Issue Type: Bug
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22685.1.patch, HIVE-22685.2.patch, 
> HIVE-22685.3.patch
>
>
> Unit test is now broken (n)(n):(
> {code:java}
> //Tests for these patterns would need changing every decade if done in 
> the above way.
> //Thursday of the first week in an ISO year always matches the Gregorian 
> year.
> checkParseTimestampIso("IY-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> checkParseTimestampIso("I-IW-ID", "0-01-04", "iw, ", "01, " + 
> thisYearString.substring(0, 3) + "0");
> {code}
> {code}
> org.junit.ComparisonFailure: expected:<01, 20[1]0> but was:<01, 20[2]0>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.checkParseTimestampIso(TestHiveSqlDateTimeFormatter.java:313)
>   at 
> org.apache.hadoop.hive.common.format.datetime.TestHiveSqlDateTimeFormatter.testParseTimestamp(TestHiveSqlDateTimeFormatter.java:287)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017053#comment-17017053
 ] 

Hive QA commented on HIVE-22538:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
5s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
43s{color} | {color:red} ql: The patch generated 6 new + 463 unchanged - 3 
fixed = 469 total (was 466) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 10s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20208/dev-support/hive-personality.sh
 |
| git revision | master / d5cfea6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20208/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20208/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017026#comment-17017026
 ] 

Hive QA commented on HIVE-22489:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991077/HIVE-22489.13.patch

{color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17862 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=160)

[unionDistinct_1.q,table_nonprintable.q,file_with_header_footer_aggregation.q,vector_offset_limit.q,orc_llap_counters1.q,mm_cttas.q,whroot_external1.q,global_limit.q,rcfile_createas1.q,dynamic_partition_pruning_2.q,intersect_merge.q,results_cache_diff_fs.q,parallel_colstats.q,load_hdfs_file_with_space_in_the_name.q,orc_merge3.q]
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20207/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20207/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20207/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991077 - PreCommit-HIVE-Build

>  Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.10.patch, 
> HIVE-22489.10.patch, HIVE-22489.11.patch, HIVE-22489.12.patch, 
> HIVE-22489.13.patch, HIVE-22489.13.patch, HIVE-22489.2.patch, 
> HIVE-22489.3.patch, HIVE-22489.3.patch, HIVE-22489.4.patch, 
> HIVE-22489.5.patch, HIVE-22489.6.patch, HIVE-22489.7.patch, 
> HIVE-22489.8.patch, HIVE-22489.9.patch, HIVE-22489.9.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is 
> explicitly specified in the ORDER BY clause of the query null ordering should 
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
>  A masked pattern was here 
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key = 
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
>  A masked pattern was here 
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: src1
>   filterExpr: key is not null (type: boolean)
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
> Select Operator
>   expressions: key (type: string)
>   outputColumnNames: _col0
>   Statistics: Num rows: 500 Data size: 43500 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort 

[jira] [Commented] (HIVE-22355) Beeline should not prompt for hive user and password when authentication is NONE

2020-01-16 Thread Mate Juhasz (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017013#comment-17017013
 ] 

Mate Juhasz commented on HIVE-22355:


Added a new patch, thanks [~ngangam]. So the prerequisite to skip prompting is 
have auth="NONE" in the jdbc url, or add -a "NONE" from the cli.

> Beeline should not prompt for hive user and password when authentication is 
> NONE
> 
>
> Key: HIVE-22355
> URL: https://issues.apache.org/jira/browse/HIVE-22355
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Mate Juhasz
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: HIVE-22355.1.patch, HIVE-22355.2.patch, 
> HIVE-22355.3.patch, HIVE-22355.4.patch, HIVE-22355.5.patch
>
>
> Beeline - without adding the jdbc url - prompts for username and password in 
> case hive.server2.authentication=NONE, which is possibly pointless and can be 
> misleading for users as any input is accepted.
> In addition, Sqoop has dropped hive cli recently in favor of beeline and if 
> there is no authentication set in Hive, Sqoop fails to connect as the process 
> stops waiting for the user/password input. 
> I think it would be nice to check the auth type "NONE" before reading unused 
> inputs from the console before this point:
> https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/Commands.java#L1641



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22355) Beeline should not prompt for hive user and password when authentication is NONE

2020-01-16 Thread Mate Juhasz (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mate Juhasz updated HIVE-22355:
---
Attachment: HIVE-22355.5.patch

> Beeline should not prompt for hive user and password when authentication is 
> NONE
> 
>
> Key: HIVE-22355
> URL: https://issues.apache.org/jira/browse/HIVE-22355
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Mate Juhasz
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: HIVE-22355.1.patch, HIVE-22355.2.patch, 
> HIVE-22355.3.patch, HIVE-22355.4.patch, HIVE-22355.5.patch
>
>
> Beeline - without adding the jdbc url - prompts for username and password in 
> case hive.server2.authentication=NONE, which is possibly pointless and can be 
> misleading for users as any input is accepted.
> In addition, Sqoop has dropped hive cli recently in favor of beeline and if 
> there is no authentication set in Hive, Sqoop fails to connect as the process 
> stops waiting for the user/password input. 
> I think it would be nice to check the auth type "NONE" before reading unused 
> inputs from the console before this point:
> https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/Commands.java#L1641



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22489) Reduce Sink operator should order nulls by parameter

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017008#comment-17017008
 ] 

Hive QA commented on HIVE-22489:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
39s{color} | {color:blue} serde in master has 198 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
4s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
32s{color} | {color:blue} accumulo-handler in master has 20 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
23s{color} | {color:blue} contrib in master has 11 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
32s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
22s{color} | {color:blue} kudu-handler in master has 1 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} serde: The patch generated 0 new + 564 unchanged - 2 
fixed = 564 total (was 566) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
54s{color} | {color:green} ql: The patch generated 0 new + 794 unchanged - 1 
fixed = 794 total (was 795) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch accumulo-handler passed checkstyle {color} 
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} The patch contrib passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} The patch hbase-handler passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} The patch kudu-handler passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} The patch hive-blobstore passed checkstyle {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
1s{color} | {color:red} The patch has 121 line(s) that end in whitespace. Use 
git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
4s{color} | {color:red} The patch 25483 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
47s{color} | {color:green} serde generated 0 new + 197 unchanged - 1 fixed = 
197 total (was 198) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
8s{color} | {color:red} ql generated 1 new + 1531 unchanged - 0 fixed = 1532 
total (was 1531) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
37s{color} | {color:green} accumulo-handler in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} 

[jira] [Updated] (HIVE-16690) Configure Tez cartesian product edge based on LLAP cluster size

2020-01-16 Thread Jira


 [ 
https://issues.apache.org/jira/browse/HIVE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

László Bodor updated HIVE-16690:

Attachment: HIVE-16690.03.patch

> Configure Tez cartesian product edge based on LLAP cluster size
> ---
>
> Key: HIVE-16690
> URL: https://issues.apache.org/jira/browse/HIVE-16690
> Project: Hive
>  Issue Type: Bug
>Reporter: Zhiyuan Yang
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-16690.03.patch, HIVE-16690.03.patch, 
> HIVE-16690.03.patch, HIVE-16690.1.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.2.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.2.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.addendum.patch
>
>
> In HIVE-14731 we are using default value for target parallelism of fair 
> cartesian product edge. Ideally this should be set according to cluster size. 
> In case of LLAP it's pretty easy to get cluster size, i.e., number of 
> executors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22536) Improve return path enabling/disabling

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22536:
--
Attachment: HIVE-22536.01.patch

> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.01.patch, 
> HIVE-22536.02.patch, HIVE-22536.03.patch
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
> on/off/supported. In case of "supported" it should be used for a subset of 
> commands which are already verified to be able to work with return path. This 
> is a temporary solution for the time while we are developing return path, 
> before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22536) Improve return path enabling/disabling

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22536:
--
Attachment: (was: HIVE-22536.01.patch)

> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, 
> HIVE-22536.03.patch
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
> on/off/supported. In case of "supported" it should be used for a subset of 
> commands which are already verified to be able to work with return path. This 
> is a temporary solution for the time while we are developing return path, 
> before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22536) Improve return path enabling/disabling

2020-01-16 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-22536:
--
Attachment: HIVE-22536.01.patch

> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.01.patch, 
> HIVE-22536.02.patch, HIVE-22536.03.patch
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be 
> on/off/supported. In case of "supported" it should be used for a subset of 
> commands which are already verified to be able to work with return path. This 
> is a temporary solution for the time while we are developing return path, 
> before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22666) Introduce TopNKey operator for PTF Reduce Sink

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016953#comment-17016953
 ] 

Hive QA commented on HIVE-22666:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991074/HIVE-22666.2.patch

{color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17882 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] 
(batchId=303)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query49]
 (batchId=303)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20206/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20206/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20206/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991074 - PreCommit-HIVE-Build

> Introduce TopNKey operator for PTF Reduce Sink
> --
>
> Key: HIVE-22666
> URL: https://issues.apache.org/jira/browse/HIVE-22666
> Project: Hive
>  Issue Type: Improvement
>Reporter: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22666.1.patch, HIVE-22666.2.patch
>
>
> {code}
> EXPLAIN EXTENDED
> SELECT s_state, ranking
> FROM (
>  SELECT s_state AS s_state,
>  rank() OVER (PARTITION BY s_state ORDER BY ss_net_profit) AS ranking
>  FROM testtable_n1000) tmp1
>  WHERE ranking <= 3;
> {code}
> {code}
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: testtable_n1000
>   Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Reduce Output Operator
> key expressions: s_state (type: string), ss_net_profit 
> (type: double)
> null sort order: az
> sort order: ++
> Map-reduce partition columns: s_state (type: string)
> Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
> tag: -1
> TopN: 4
> TopN Hash Memory Usage: 0.1
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
>  A masked pattern was here 
> Path -> Partition:
>  A masked pattern was here 
> Partition
>   base file name: testtable_n1000
>   input format: org.apache.hadoop.mapred.TextInputFormat
>   output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
>   properties:
> COLUMN_STATS_ACCURATE 
> {"BASIC_STATS":"true","COLUMN_STATS":{"s_state":"true","ss_net_profit":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns s_state,ss_net_profit
> columns.comments 
> columns.types string:double
>  A masked pattern was here 
> name default.testtable_n1000
> numFiles 1
> numRows 10
> rawDataSize 80
> serialization.ddl struct testtable_n1000 { string 
> s_state, double ss_net_profit}
> serialization.format 1
> serialization.lib 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 90
>  A masked pattern was here 
>   serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> 
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format: 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
>   COLUMN_STATS_ACCURATE 
> 

[jira] [Work started] (HIVE-22736) Support replication across multiple encryption zones

2020-01-16 Thread Aasha Medhi (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-22736 started by Aasha Medhi.
--
> Support replication across multiple encryption zones
> 
>
> Key: HIVE-22736
> URL: https://issues.apache.org/jira/browse/HIVE-22736
> Project: Hive
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22736) Support replication across multiple encryption zones

2020-01-16 Thread Aasha Medhi (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016919#comment-17016919
 ] 

Aasha Medhi commented on HIVE-22736:


[https://docs.google.com/document/d/1E_BYRymD2hasz7E7BuT9IrDdi9z92VLST__Mv3AmDR8/edit#]

> Support replication across multiple encryption zones
> 
>
> Key: HIVE-22736
> URL: https://issues.apache.org/jira/browse/HIVE-22736
> Project: Hive
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-21050) Use Parquet LogicalTypes

2020-01-16 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage updated HIVE-21050:
-
Attachment: HIVE-21050.11.patch
Status: Patch Available  (was: Open)

> Use Parquet LogicalTypes
> 
>
> Key: HIVE-21050
> URL: https://issues.apache.org/jira/browse/HIVE-21050
> Project: Hive
>  Issue Type: Improvement
>  Components: File Formats
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>  Labels: Parquet, parquet
> Attachments: HIVE-21050.1.patch, HIVE-21050.1.patch, 
> HIVE-21050.1.patch, HIVE-21050.10.patch, HIVE-21050.11.patch, 
> HIVE-21050.2.patch, HIVE-21050.3.patch, HIVE-21050.4.patch, 
> HIVE-21050.4.patch, HIVE-21050.4.patch, HIVE-21050.5.patch, 
> HIVE-21050.5.patch, HIVE-21050.5.patch, HIVE-21050.6.patch, 
> HIVE-21050.6.patch, HIVE-21050.6.patch, HIVE-21050.6.patch.txt, 
> HIVE-21050.7.patch, HIVE-21050.7.patch, HIVE-21050.8.patch, HIVE-21050.9.patch
>
>
> [WIP until Parquet community releases version 1.11.0]
> The new Parquet version (1.11.0) uses 
> [LogicalTypes|https://github.com/apache/parquet-format/blob/master/LogicalTypes.md]
>  instead of OriginalTypes.
>  These are backwards-compatible with OriginalTypes.
> Thanks to [~kuczoram] for her work on this patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-21050) Use Parquet LogicalTypes

2020-01-16 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage updated HIVE-21050:
-
Status: Open  (was: Patch Available)

> Use Parquet LogicalTypes
> 
>
> Key: HIVE-21050
> URL: https://issues.apache.org/jira/browse/HIVE-21050
> Project: Hive
>  Issue Type: Improvement
>  Components: File Formats
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>  Labels: Parquet, parquet
> Attachments: HIVE-21050.1.patch, HIVE-21050.1.patch, 
> HIVE-21050.1.patch, HIVE-21050.10.patch, HIVE-21050.11.patch, 
> HIVE-21050.2.patch, HIVE-21050.3.patch, HIVE-21050.4.patch, 
> HIVE-21050.4.patch, HIVE-21050.4.patch, HIVE-21050.5.patch, 
> HIVE-21050.5.patch, HIVE-21050.5.patch, HIVE-21050.6.patch, 
> HIVE-21050.6.patch, HIVE-21050.6.patch, HIVE-21050.6.patch.txt, 
> HIVE-21050.7.patch, HIVE-21050.7.patch, HIVE-21050.8.patch, HIVE-21050.9.patch
>
>
> [WIP until Parquet community releases version 1.11.0]
> The new Parquet version (1.11.0) uses 
> [LogicalTypes|https://github.com/apache/parquet-format/blob/master/LogicalTypes.md]
>  instead of OriginalTypes.
>  These are backwards-compatible with OriginalTypes.
> Thanks to [~kuczoram] for her work on this patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22719) Remove Log from HiveConf::getLogIdVar

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-22719:

Fix Version/s: 4.0.0

> Remove Log from HiveConf::getLogIdVar
> -
>
> Key: HIVE-22719
> URL: https://issues.apache.org/jira/browse/HIVE-22719
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Fix For: 4.0.0
>
> Attachments: ExecuteStatemt_getResult.jpg, HIVE-22719.1.patch, 
> HIVE-22719.2.patch
>
>
> Log statement gets in the hotpath when executing large number of tiny sql 
> statements.
> !ExecuteStatemt_getResult.jpg|width=260,height=177!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22719) Remove Log from HiveConf::getLogIdVar

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-22719:

  Assignee: Rajesh Balamohan
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thanks [~ashutoshc] , [~gopalv] . Committed to master.

> Remove Log from HiveConf::getLogIdVar
> -
>
> Key: HIVE-22719
> URL: https://issues.apache.org/jira/browse/HIVE-22719
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Attachments: ExecuteStatemt_getResult.jpg, HIVE-22719.1.patch, 
> HIVE-22719.2.patch
>
>
> Log statement gets in the hotpath when executing large number of tiny sql 
> statements.
> !ExecuteStatemt_getResult.jpg|width=260,height=177!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22720) Optimise AuthenticationProviderFactory::getAuthenticationProvider

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-22720:

Fix Version/s: 4.0.0
 Assignee: Rajesh Balamohan
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Thanks [~ashutoshc] , [~gopalv] . Committed to master.

> Optimise AuthenticationProviderFactory::getAuthenticationProvider
> -
>
> Key: HIVE-22720
> URL: https://issues.apache.org/jira/browse/HIVE-22720
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22720.1.patch, HIVE-22720.2.patch, Screenshot 
> 2020-01-13 at 10.07.34 AM.jpg
>
>
> !Screenshot 2020-01-13 at 10.07.34 AM.jpg|width=439,height=269!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22720) Optimise AuthenticationProviderFactory::getAuthenticationProvider

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-22720:

Priority: Minor  (was: Major)

> Optimise AuthenticationProviderFactory::getAuthenticationProvider
> -
>
> Key: HIVE-22720
> URL: https://issues.apache.org/jira/browse/HIVE-22720
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-22720.1.patch, HIVE-22720.2.patch, Screenshot 
> 2020-01-13 at 10.07.34 AM.jpg
>
>
> !Screenshot 2020-01-13 at 10.07.34 AM.jpg|width=439,height=269!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22706) Jdbc storage handler incorrectly interprets boolean column value in derby

2020-01-16 Thread Zoltan Haindrich (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Haindrich updated HIVE-22706:

Attachment: HIVE-22706.02.patch

> Jdbc storage handler incorrectly interprets boolean column value in derby
> -
>
> Key: HIVE-22706
> URL: https://issues.apache.org/jira/browse/HIVE-22706
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22706.01.patch, HIVE-22706.01.patch, 
> HIVE-22706.01.patch, HIVE-22706.01.patch, HIVE-22706.02.patch, 
> HIVE-22706.02.patch, HIVE-22706.02.patch, HIVE-22706.02.patch
>
>
> in case the column value is false ; the storage handler interprets it as true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22518) SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests

2020-01-16 Thread Zoltan Haindrich (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Haindrich updated HIVE-22518:

Attachment: HIVE-22518.03.patch

> SQLStdHiveAuthorizerFactoryForTest doesn't work correctly for llap tests
> 
>
> Key: HIVE-22518
> URL: https://issues.apache.org/jira/browse/HIVE-22518
> Project: Hive
>  Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22518.01.patch, HIVE-22518.01.patch, 
> HIVE-22518.02.patch, HIVE-22518.02.patch, HIVE-22518.03.patch, 
> HIVE-22518.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Attachment: HIVE-22730.3.patch

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, 
> HIVE-22730.3.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22666) Introduce TopNKey operator for PTF Reduce Sink

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016881#comment-17016881
 ] 

Hive QA commented on HIVE-22666:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
4s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
39s{color} | {color:red} ql: The patch generated 2 new + 7 unchanged - 0 fixed 
= 9 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20206/dev-support/hive-personality.sh
 |
| git revision | master / 3b1138b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20206/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20206/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Introduce TopNKey operator for PTF Reduce Sink
> --
>
> Key: HIVE-22666
> URL: https://issues.apache.org/jira/browse/HIVE-22666
> Project: Hive
>  Issue Type: Improvement
>Reporter: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22666.1.patch, HIVE-22666.2.patch
>
>
> {code}
> EXPLAIN EXTENDED
> SELECT s_state, ranking
> FROM (
>  SELECT s_state AS s_state,
>  rank() OVER (PARTITION BY s_state ORDER BY ss_net_profit) AS ranking
>  FROM testtable_n1000) tmp1
>  WHERE ranking <= 3;
> {code}
> {code}
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
> Tez
>  A masked pattern was here 
>   Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE)
>  A masked pattern was here 
>   Vertices:
> Map 1 
> Map Operator Tree:
> TableScan
>   alias: testtable_n1000
>   Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE Column stats: COMPLETE
>   GatherStats: false
>   Reduce Output Operator
> key expressions: s_state (type: string), ss_net_profit 
> (type: double)
> null sort order: az
> sort order: ++
> Map-reduce partition columns: s_state (type: string)
> Statistics: Num rows: 10 Data size: 940 Basic stats: 
> COMPLETE 

[jira] [Updated] (HIVE-22725) Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-22725:

Attachment: HIVE-22725.4.patch

> Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation
> 
>
> Key: HIVE-22725
> URL: https://issues.apache.org/jira/browse/HIVE-22725
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-22725.1.patch, HIVE-22725.2.patch, 
> HIVE-22725.3.patch, HIVE-22725.4.patch, image-2020-01-14-13-22-54-483.png
>
>
> "TransactionalValidationListener" gets added in the pre-event listeners of 
> HMS by default.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L559]
> This causes issue in short select queries, as table details are computed for 
> any partition lookups.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L4984]
>  
> !image-2020-01-14-13-22-54-483.png|width=579,height=202!
>  
> It would be good to lazy evaluate table lookup in this codepath.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22733) After disable operation log property in hive, still HS2 saving the operation log

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016852#comment-17016852
 ] 

Hive QA commented on HIVE-22733:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991063/HIVE-22733.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 17877 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testCreateTableLike (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testDatabaseLocation (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testDropPartitionsWithPartialSpec 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testDropTableException (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testEmptyTableInstantiation 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testGetMessageBusTopicName 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testGetPartitionsWithPartialSpec 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testObjectNotFoundException 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testOtherFailure (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
 (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSchema (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
 (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionsHCatClientImpl 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testRenameTable (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testReplicationTaskIter 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation 
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testUpdateTableSchema (batchId=211)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20205/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20205/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20205/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 19 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991063 - PreCommit-HIVE-Build

> After disable operation log property in hive, still HS2 saving the operation 
> log
> 
>
> Key: HIVE-22733
> URL: https://issues.apache.org/jira/browse/HIVE-22733
> Project: Hive
>  Issue Type: Bug
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22733.01.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are few issues in this area.
>  1. If logging is disabled using hive.server2.logging.operation.enabled, then 
> operation logs for the queries should not be generated. But the 
> registerLoggingContext method in LogUtils, registers the logging context  
> even if the operation log is disabled. This causes the logs to be added by 
> logger. The registration of query context should be done only if operation 
> logging is enabled.
> {code:java}
>  public static void registerLoggingContext(Configuration conf) {
> -MDC.put(SESSIONID_LOG_KEY, HiveConf.getVar(conf, 
> HiveConf.ConfVars.HIVESESSIONID));
> -MDC.put(QUERYID_LOG_KEY, HiveConf.getVar(conf, 
> HiveConf.ConfVars.HIVEQUERYID));
>  if (HiveConf.getBoolVar(conf, 
> HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED)) {
> +  MDC.put(SESSIONID_LOG_KEY, HiveConf.getVar(conf, 
> HiveConf.ConfVars.HIVESESSIONID));
> +  MDC.put(QUERYID_LOG_KEY, HiveConf.getVar(conf, 
> HiveConf.ConfVars.HIVEQUERYID));
>MDC.put(OPERATIONLOG_LEVEL_KEY, HiveConf.getVar(conf, 
> HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_LEVEL));{code}
>  
> 2. In case of failed query, we close the operations and that deletes the 
> logging context (appender and route) from logger for that query. But if any 
> log is added after that, the query logs are getting added and new operation 
> log file is getting generated for the query. This looks like issue with MCD 
> clear. MCD clear is not removing the keys from the map. If remove is used 
> instead of clear, its 

[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Attachment: HIVE-22730.2.patch

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, HIVE-22730.2.patch, Screenshot 
> 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-21939) protoc:2.5.0 dependence has broken building on aarch64

2020-01-16 Thread chenjianjian (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenjianjian reassigned HIVE-21939:
---

Assignee: (was: chenjianjian)

> protoc:2.5.0  dependence has broken building on aarch64
> ---
>
> Key: HIVE-21939
> URL: https://issues.apache.org/jira/browse/HIVE-21939
> Project: Hive
>  Issue Type: Bug
>Reporter: liusheng
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When I try to build master of Hive from source code on "aarch64" server, I 
> met following error:
> [ERROR] Failed to execute goal 
> com.github.os72:protoc-jar-maven-plugin:3.5.1.1:run (default) on project 
> hive-standalone-metastore-common: Error resolving artifact: 
> com.google.protobuf:protoc:2.5.0: Could not find artifact 
> com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0 in central 
> ([https://repo.maven.apache.org/maven2)]
> that is because Hive using the "com.google.protobuf:protoc:2.5.0" as required 
> artifact, which does not have released package for "aarch64" platform.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-21939) protoc:2.5.0 dependence has broken building on aarch64

2020-01-16 Thread chenjianjian (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenjianjian reassigned HIVE-21939:
---

Assignee: chenjianjian  (was: zhangxj)

> protoc:2.5.0  dependence has broken building on aarch64
> ---
>
> Key: HIVE-21939
> URL: https://issues.apache.org/jira/browse/HIVE-21939
> Project: Hive
>  Issue Type: Bug
>Reporter: liusheng
>Assignee: chenjianjian
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When I try to build master of Hive from source code on "aarch64" server, I 
> met following error:
> [ERROR] Failed to execute goal 
> com.github.os72:protoc-jar-maven-plugin:3.5.1.1:run (default) on project 
> hive-standalone-metastore-common: Error resolving artifact: 
> com.google.protobuf:protoc:2.5.0: Could not find artifact 
> com.google.protobuf:protoc:exe:linux-aarch_64:2.5.0 in central 
> ([https://repo.maven.apache.org/maven2)]
> that is because Hive using the "com.google.protobuf:protoc:2.5.0" as required 
> artifact, which does not have released package for "aarch64" platform.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22733) After disable operation log property in hive, still HS2 saving the operation log

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016813#comment-17016813
 ] 

Hive QA commented on HIVE-22733:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
34s{color} | {color:blue} common in master has 63 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
16s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 4 
unchanged - 0 fixed = 6 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 30s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20205/dev-support/hive-personality.sh
 |
| git revision | master / 3b1138b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20205/yetus/diff-checkstyle-itests_hive-unit.txt
 |
| modules | C: common itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20205/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> After disable operation log property in hive, still HS2 saving the operation 
> log
> 
>
> Key: HIVE-22733
> URL: https://issues.apache.org/jira/browse/HIVE-22733
> Project: Hive
>  Issue Type: Bug
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22733.01.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are few issues in this area.
>  1. If logging is disabled using hive.server2.logging.operation.enabled, then 
> operation logs for the queries should not be generated. But the 
> registerLoggingContext method in LogUtils, registers the logging context  
> even if the operation log is disabled. This causes the logs to be added by 
> logger. The registration of query context should be done only if operation 
> logging is enabled.
> {code:java}
>  public 

[jira] [Updated] (HIVE-20974) TezTask should set task exception on failures

2020-01-16 Thread Rajesh Balamohan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-20974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated HIVE-20974:

Attachment: HIVE-20974.2.patch

> TezTask should set task exception on failures
> -
>
> Key: HIVE-20974
> URL: https://issues.apache.org/jira/browse/HIVE-20974
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-20974.1.patch, HIVE-20974.2.patch
>
>
> TezTask logs the error as "Failed to execute tez graph" and proceeds further. 
> "TaskRunner.runSequentail()" code would not be able to get these exceptions 
> for TezTask. If there are any failure hooks configured, these exceptions 
> wouldn't show up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22712) ReExec Driver execute submit the query in default queue irrespective of user defined queue

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016803#comment-17016803
 ] 

Hive QA commented on HIVE-22712:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991053/HIVE-22712.04.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17876 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] 
(batchId=90)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[retry_failure]
 (batchId=178)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20204/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20204/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20204/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12991053 - PreCommit-HIVE-Build

> ReExec Driver execute submit the query in default queue irrespective of user 
> defined queue
> --
>
> Key: HIVE-22712
> URL: https://issues.apache.org/jira/browse/HIVE-22712
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, HiveServer2
>Affects Versions: 3.1.2
> Environment: Hive-3
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Major
> Attachments: HIVE-22712.01.patch, HIVE-22712.02.patch, 
> HIVE-22712.03.patch, HIVE-22712.04.patch, HIVE-22712.patch
>
>
> we unset the queue name intentionally in 
> TezSessionState#startSessionAndContainers, 
> as a result reexec create a new session in the default queue and create a 
> problem, its a cumbersome to add reexec.overlay.tez.queue.name at session 
> level.
> I could not find a better way of setting the queue name (I am open for the 
> suggestion here) since it can create a  conflict with the Global queue name 
> vs user-defined queue that's why setting while initialization of 
> ReExecutionOverlayPlugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22538:
--
Attachment: HIVE-22538.4.patch

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22538:
--
Status: Open  (was: Patch Available)

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22538) RS deduplication does not always enforce hive.optimize.reducededuplication.min.reducer

2020-01-16 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-22538:
--
Status: Patch Available  (was: Open)

> RS deduplication does not always enforce 
> hive.optimize.reducededuplication.min.reducer
> --
>
> Key: HIVE-22538
> URL: https://issues.apache.org/jira/browse/HIVE-22538
> Project: Hive
>  Issue Type: Bug
>  Components: Physical Optimizer
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22538.2.patch, HIVE-22538.3.patch, 
> HIVE-22538.4.patch, HIVE-22538.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For transactional tables, that property might be overriden to 1, which can 
> lead to merging final aggregation into a single stage (hence leading to 
> performance degradation). For instance, when autogather column stats is 
> enabled, this can happen for the following query:
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> EXPLAIN
> CREATE TABLE x STORED AS ORC TBLPROPERTIES('transactional'='true') AS
> SELECT * FROM SRC x CLUSTER BY x.key;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Description: 
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!

  was:
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=800,height=50!


> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=60!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Description: 
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=50!

  was:
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=70!


> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=50!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Description: 
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=800,height=50!

  was:
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=900,height=50!


> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=800,height=50!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Description: 
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=900,height=50!

  was:
{code}
insert into b values(1);
{code}

List lockComponents = 
AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
plan.getInputs() contains single entry <_dummy_database@_dummy_table>
!Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=50!


> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=900,height=50!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Status: Patch Available  (was: Open)

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=70!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22730) Do not acquire read lock for dummy input

2020-01-16 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22730:
--
Attachment: HIVE-22730.1.patch

> Do not acquire read lock for dummy input
> 
>
> Key: HIVE-22730
> URL: https://issues.apache.org/jira/browse/HIVE-22730
> Project: Hive
>  Issue Type: Bug
>  Components: Locking
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22730.1.patch, Screenshot 2020-01-15 at 16.49.16.png
>
>
> {code}
> insert into b values(1);
> {code}
> List lockComponents = 
> AcidUtils.makeLockComponents(plan.getOutputs(), plan.getInputs(), conf);
> plan.getInputs() contains single entry <_dummy_database@_dummy_table>
> !Screenshot 2020-01-15 at 16.49.16.png|width=1024,height=70!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22712) ReExec Driver execute submit the query in default queue irrespective of user defined queue

2020-01-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016769#comment-17016769
 ] 

Hive QA commented on HIVE-22712:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
2s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 34s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20204/dev-support/hive-personality.sh
 |
| git revision | master / 3b1138b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20204/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> ReExec Driver execute submit the query in default queue irrespective of user 
> defined queue
> --
>
> Key: HIVE-22712
> URL: https://issues.apache.org/jira/browse/HIVE-22712
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, HiveServer2
>Affects Versions: 3.1.2
> Environment: Hive-3
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Major
> Attachments: HIVE-22712.01.patch, HIVE-22712.02.patch, 
> HIVE-22712.03.patch, HIVE-22712.04.patch, HIVE-22712.patch
>
>
> we unset the queue name intentionally in 
> TezSessionState#startSessionAndContainers, 
> as a result reexec create a new session in the default queue and create a 
> problem, its a cumbersome to add reexec.overlay.tez.queue.name at session 
> level.
> I could not find a better way of setting the queue name (I am open for the 
> suggestion here) since it can create a  conflict with the Global queue name 
> vs user-defined queue that's why setting while initialization of 
> ReExecutionOverlayPlugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >