[jira] [Resolved] (HIVE-24602) Retry compaction after configured time
[ https://issues.apache.org/jira/browse/HIVE-24602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Coppage resolved HIVE-24602. -- Fix Version/s: 4.0.0 Resolution: Fixed Committed to master branch. Thanks for your contribution [~pvargacl]! > Retry compaction after configured time > -- > > Key: HIVE-24602 > URL: https://issues.apache.org/jira/browse/HIVE-24602 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Currently if compaction fails two consecutive times it will stop compaction > forever for the given partition / table unless someone manually intervenes. > See COMPACTOR_INITIATOR_FAILED_THRESHOLD. > The Initiator should retry again after a configurable amount of time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24602) Retry compaction after configured time
[ https://issues.apache.org/jira/browse/HIVE-24602?focusedWorklogId=534138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534138 ] ASF GitHub Bot logged work on HIVE-24602: - Author: ASF GitHub Bot Created on: 11/Jan/21 07:55 Start Date: 11/Jan/21 07:55 Worklog Time Spent: 10m Work Description: klcopp merged pull request #1839: URL: https://github.com/apache/hive/pull/1839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 534138) Time Spent: 2h (was: 1h 50m) > Retry compaction after configured time > -- > > Key: HIVE-24602 > URL: https://issues.apache.org/jira/browse/HIVE-24602 > Project: Hive > Issue Type: Improvement >Reporter: Peter Varga >Assignee: Peter Varga >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > Currently if compaction fails two consecutive times it will stop compaction > forever for the given partition / table unless someone manually intervenes. > See COMPACTOR_INITIATOR_FAILED_THRESHOLD. > The Initiator should retry again after a configurable amount of time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24558) Handle update in table level regular expression.
[
https://issues.apache.org/jira/browse/HIVE-24558?focusedWorklogId=534116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534116
]
ASF GitHub Bot logged work on HIVE-24558:
-
Author: ASF GitHub Bot
Created on: 11/Jan/21 03:27
Start Date: 11/Jan/21 03:27
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1804:
URL: https://github.com/apache/hive/pull/1804#discussion_r554672844
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##
@@ -410,12 +413,16 @@ private boolean shouldDump(Path previousDumpPath) throws
IOException {
* @return true if need to examine tables for dump and false if not.
*/
private boolean shouldExamineTablesToDump() {
-return (work.oldReplScope != null)
+return (previousReplScopeModified())
|| !tablesForBootstrap.isEmpty()
|| conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)
|| conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES);
}
+ private boolean previousReplScopeModified() {
Review comment:
dmd.setDump(DumpType.BOOTSTRAP, bootDumpBeginReplId, bootDumpEndReplId,
cmRoot, executorId,
work.oldReplScope != null);
Shouldn't this line also also previousReplScopeModified() otherwise load
will always assume that there is change in expession.
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/repl/ReplScope.java
##
@@ -116,4 +117,27 @@ private boolean inTableExcludedList(final String
tableName) {
}
return excludedTableNamePattern.matcher(tableName).matches();
}
+
+ @Override
+ public boolean equals(Object o) {
+if (o == this) {
+ return true;
+}
+if (! (o instanceof ReplScope)) {
+ return false;
+}
+
+ReplScope replScope = (ReplScope)o;
+return ((replScope.getExcludedTableNames() == null ?
(this.excludedTableNames == null) :
+ replScope.getExcludedTableNames().equals(this.excludedTableNames))
Review comment:
nit: getExcludedTableNames() /getIncludedTableNames() methods can be
replaced by replScope.excludedTableNamePattern and
replScope.includedTableNamePattern respectively.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 534116)
Time Spent: 20m (was: 10m)
> Handle update in table level regular expression.
>
>
> Key: HIVE-24558
> URL: https://issues.apache.org/jira/browse/HIVE-24558
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24558.01.patch, HIVE-24558.02.patch,
> HIVE-24558.03.patch, HIVE-24558.04.patch, HIVE-24558.05.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24366) changeMarker value sent to atlas export API is set to 0 in the 2nd repl dump call
[ https://issues.apache.org/jira/browse/HIVE-24366?focusedWorklogId=534100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534100 ] ASF GitHub Bot logged work on HIVE-24366: - Author: ASF GitHub Bot Created on: 11/Jan/21 01:15 Start Date: 11/Jan/21 01:15 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1659: URL: https://github.com/apache/hive/pull/1659#issuecomment-757580333 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 534100) Time Spent: 20m (was: 10m) > changeMarker value sent to atlas export API is set to 0 in the 2nd repl dump > call > - > > Key: HIVE-24366 > URL: https://issues.apache.org/jira/browse/HIVE-24366 > Project: Hive > Issue Type: Bug >Reporter: Arko Sharma >Assignee: Arko Sharma >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24366.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-24612) Enable materialized view tests on TPCDS queries
[ https://issues.apache.org/jira/browse/HIVE-24612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis reassigned HIVE-24612: -- > Enable materialized view tests on TPCDS queries > --- > > Key: HIVE-24612 > URL: https://issues.apache.org/jira/browse/HIVE-24612 > Project: Hive > Issue Type: Task >Reporter: Stamatis Zampetakis >Assignee: Stamatis Zampetakis >Priority: Major > > The tests using materialized views and TPC-DS queries 30, 44, 45, 67, 68, > were disabled when HIVE-23965 was merged. The metastore introduced in > HIVE-23965 includes some paths to HDFS and this makes the CREATE VIEW > statements in the tests fail since the path cannot be found. > The goal of this issue is to enable the following qtests: > * mv_query30 > * mv_query44 > * mv_query45 > * mv_query67 > * mv_query68 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24611) Remove unnecessary parameter from AbstractAlterTableOperation
[ https://issues.apache.org/jira/browse/HIVE-24611?focusedWorklogId=534030=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534030 ] ASF GitHub Bot logged work on HIVE-24611: - Author: ASF GitHub Bot Created on: 10/Jan/21 17:24 Start Date: 10/Jan/21 17:24 Worklog Time Spent: 10m Work Description: miklosgergely opened a new pull request #1846: URL: https://github.com/apache/hive/pull/1846 ### What changes were proposed in this pull request? AbstractAlterTableOperation has a private method (finalizeAlterTableWithWriteIdOp) which receives one of it's field, which doesn't make much sense. ### Why are the changes needed? To have a cleaner code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? All the tests are still running. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 534030) Remaining Estimate: 0h Time Spent: 10m > Remove unnecessary parameter from AbstractAlterTableOperation > - > > Key: HIVE-24611 > URL: https://issues.apache.org/jira/browse/HIVE-24611 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-24611) Remove unnecessary parameter from AbstractAlterTableOperation
[ https://issues.apache.org/jira/browse/HIVE-24611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-24611: -- Labels: pull-request-available (was: ) > Remove unnecessary parameter from AbstractAlterTableOperation > - > > Key: HIVE-24611 > URL: https://issues.apache.org/jira/browse/HIVE-24611 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-24611) Remove unnecessary parameter from AbstractAlterTableOperation
[ https://issues.apache.org/jira/browse/HIVE-24611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely reassigned HIVE-24611: - > Remove unnecessary parameter from AbstractAlterTableOperation > - > > Key: HIVE-24611 > URL: https://issues.apache.org/jira/browse/HIVE-24611 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24559) Fix some spelling issues
[ https://issues.apache.org/jira/browse/HIVE-24559?focusedWorklogId=534012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534012 ] ASF GitHub Bot logged work on HIVE-24559: - Author: ASF GitHub Bot Created on: 10/Jan/21 16:25 Start Date: 10/Jan/21 16:25 Worklog Time Spent: 10m Work Description: rickyma commented on pull request #1818: URL: https://github.com/apache/hive/pull/1818#issuecomment-757502981 @sunchao Thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 534012) Time Spent: 2h (was: 1h 50m) > Fix some spelling issues > > > Key: HIVE-24559 > URL: https://issues.apache.org/jira/browse/HIVE-24559 > Project: Hive > Issue Type: Improvement >Reporter: RickyMa >Assignee: RickyMa >Priority: Trivial > Labels: pull-request-available > Fix For: 2.3.8, 4.0.0 > > Time Spent: 2h > Remaining Estimate: 0h > > There are some minor typos: > [https://github.com/apache/hive/pull/1805/fileshttps://github.com/apache/hive/pull/1805/fileshttps://github.com/apache/hive/blob/branch-2.3/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L858|https://github.com/apache/hive/blob/branch-2.3/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L858] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24610) Remove superfluous throws IOException from Context
[ https://issues.apache.org/jira/browse/HIVE-24610?focusedWorklogId=533989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533989 ] ASF GitHub Bot logged work on HIVE-24610: - Author: ASF GitHub Bot Created on: 10/Jan/21 15:10 Start Date: 10/Jan/21 15:10 Worklog Time Spent: 10m Work Description: miklosgergely opened a new pull request #1845: URL: https://github.com/apache/hive/pull/1845 ### What changes were proposed in this pull request? Remove superfluous throws IOException from Context constructor, which may never be thrown. ### Why are the changes needed? To keep the code clean by not having unused parts in it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? All the tests are still running fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 533989) Remaining Estimate: 0h Time Spent: 10m > Remove superfluous throws IOException from Context > -- > > Key: HIVE-24610 > URL: https://issues.apache.org/jira/browse/HIVE-24610 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-24610) Remove superfluous throws IOException from Context
[ https://issues.apache.org/jira/browse/HIVE-24610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-24610: -- Labels: pull-request-available (was: ) > Remove superfluous throws IOException from Context > -- > > Key: HIVE-24610 > URL: https://issues.apache.org/jira/browse/HIVE-24610 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-24610) Remove superfluous throws IOException from Context
[ https://issues.apache.org/jira/browse/HIVE-24610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely reassigned HIVE-24610: - > Remove superfluous throws IOException from Context > -- > > Key: HIVE-24610 > URL: https://issues.apache.org/jira/browse/HIVE-24610 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-24593) Clean up checkstyle violations in ddl
[ https://issues.apache.org/jira/browse/HIVE-24593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely resolved HIVE-24593. --- Resolution: Fixed Merged to master, thank you [~kkasa] > Clean up checkstyle violations in ddl > - > > Key: HIVE-24593 > URL: https://issues.apache.org/jira/browse/HIVE-24593 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24593) Clean up checkstyle violations in ddl
[ https://issues.apache.org/jira/browse/HIVE-24593?focusedWorklogId=533984=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533984 ] ASF GitHub Bot logged work on HIVE-24593: - Author: ASF GitHub Bot Created on: 10/Jan/21 14:25 Start Date: 10/Jan/21 14:25 Worklog Time Spent: 10m Work Description: miklosgergely merged pull request #1835: URL: https://github.com/apache/hive/pull/1835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 533984) Time Spent: 20m (was: 10m) > Clean up checkstyle violations in ddl > - > > Key: HIVE-24593 > URL: https://issues.apache.org/jira/browse/HIVE-24593 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
