[jira] [Work logged] (HIVE-23644) Fix FindBug issues in hive-jdbc
[ https://issues.apache.org/jira/browse/HIVE-23644?focusedWorklogId=749031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749031 ] ASF GitHub Bot logged work on HIVE-23644: - Author: ASF GitHub Bot Created on: 29/Mar/22 00:21 Start Date: 29/Mar/22 00:21 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2960: URL: https://github.com/apache/hive/pull/2960#issuecomment-1081275759 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 749031) Time Spent: 20m (was: 10m) > Fix FindBug issues in hive-jdbc > --- > > Key: HIVE-23644 > URL: https://issues.apache.org/jira/browse/HIVE-23644 > Project: Hive > Issue Type: Sub-task >Reporter: Panagiotis Garefalakis >Assignee: David Mollitor >Priority: Major > Labels: pull-request-available > Attachments: spotbugsXml.xml > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-23650) Fix FindBug issues in hive-streaming
[ https://issues.apache.org/jira/browse/HIVE-23650?focusedWorklogId=749030=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749030 ] ASF GitHub Bot logged work on HIVE-23650: - Author: ASF GitHub Bot Created on: 29/Mar/22 00:20 Start Date: 29/Mar/22 00:20 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2983: URL: https://github.com/apache/hive/pull/2983#issuecomment-1081275709 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 749030) Time Spent: 20m (was: 10m) > Fix FindBug issues in hive-streaming > > > Key: HIVE-23650 > URL: https://issues.apache.org/jira/browse/HIVE-23650 > Project: Hive > Issue Type: Sub-task >Reporter: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Attachments: spotbugsXml.xml > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-23635) Fix FindBug issues in hive-vector-code-gen
[ https://issues.apache.org/jira/browse/HIVE-23635?focusedWorklogId=749029=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749029 ] ASF GitHub Bot logged work on HIVE-23635: - Author: ASF GitHub Bot Created on: 29/Mar/22 00:20 Start Date: 29/Mar/22 00:20 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2982: URL: https://github.com/apache/hive/pull/2982#issuecomment-1081275724 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 749029) Time Spent: 20m (was: 10m) > Fix FindBug issues in hive-vector-code-gen > -- > > Key: HIVE-23635 > URL: https://issues.apache.org/jira/browse/HIVE-23635 > Project: Hive > Issue Type: Sub-task >Reporter: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Attachments: spotbugsXml.xml > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=748963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748963
]
ASF GitHub Bot logged work on HIVE-21456:
-
Author: ASF GitHub Bot
Created on: 28/Mar/22 21:45
Start Date: 28/Mar/22 21:45
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r828072598
##
File path: standalone-metastore/pom.xml
##
@@ -103,6 +103,7 @@
4.0.3
2.8.4
1.7.30
+4.4.10
Review comment:
This seems to be an older version compared to what HS2 uses. Can we
atleast use the same version as HS2? This will probably address some known CVEs
##
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestRemoteHiveHttpMetaStore.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore;
+
+import org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.hive.metastore.annotation.MetastoreCheckinTest;
+import org.apache.hadoop.hive.metastore.conf.MetastoreConf;
+import org.apache.hadoop.hive.metastore.conf.MetastoreConf.ConfVars;
+
+@Category(MetastoreCheckinTest.class)
+public class TestRemoteHiveHttpMetaStore extends TestRemoteHiveMetaStore {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestRemoteHiveHttpMetaStore.class);
+
+ @Override
+ public void start() throws Exception {
+MetastoreConf.setVar(conf, ConfVars.THRIFT_TRANSPORT_MODE, "http");
+//MetastoreConf.setBoolVar(conf, ConfVars.USE_SSL, true);
+//MetastoreConf.setVar(conf, ConfVars.SSL_KEYSTORE_PATH,
"/home/sourabh/src/certs1/keystore");
+//MetastoreConf.setVar(conf, ConfVars.SSL_KEYSTORE_PASSWORD, "password");
+//MetastoreConf.setVar(conf, ConfVars.SSL_KEYSTORE_TYPE, "pkcs12");
+//MetastoreConf.setVar(conf, ConfVars.SSL_KEYMANAGERFACTORY_ALGORITHM,
"SunX509");
Review comment:
nit: delete dead code.
##
File path: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java
##
@@ -437,15 +439,36 @@ public void testConnectionWrongCertCN() throws Exception {
* Test HMS server with SSL
* @throws Exception
*/
+ @Ignore
@Test
public void testMetastoreWithSSL() throws Exception {
testSSLHMS(true);
}
+ /**
+ * Test HMS server with Http + SSL
+ * @throws Exception
+ */
+ @Test
+ public void testMetastoreWithHttps() throws Exception {
+// MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.EVENT_DB_NOTIFICATION_API_AUTH, false);
+//MetastoreConf.setVar(conf,
MetastoreConf.ConfVars.METASTORE_CLIENT_TRANSPORT_MODE, "http");
Review comment:
nit: delete commented code
##
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestRemoteHiveHttpMetaStore.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore;
+
+import org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest;
+import org.junit.experimental.categories.Category;
+import
[jira] [Work started] (HIVE-26077) Implement CTAS for Iceberg tables with partition spec
[
https://issues.apache.org/jira/browse/HIVE-26077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-26077 started by Peter Vary.
-
> Implement CTAS for Iceberg tables with partition spec
> -
>
> Key: HIVE-26077
> URL: https://issues.apache.org/jira/browse/HIVE-26077
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We enabled CTAS for Iceberg tables, but currently only for unpartitioned
> tables and tables where the partitioning schema uses the original HIVE
> {{PARTITIONED BY}} syntax.
> We would like to use CTAS with the new syntax, like:
> {code}
> CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (HIVE-26077) Implement CTAS for Iceberg tables with partition spec
[
https://issues.apache.org/jira/browse/HIVE-26077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Vary reassigned HIVE-26077:
-
Assignee: Peter Vary
> Implement CTAS for Iceberg tables with partition spec
> -
>
> Key: HIVE-26077
> URL: https://issues.apache.org/jira/browse/HIVE-26077
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We enabled CTAS for Iceberg tables, but currently only for unpartitioned
> tables and tables where the partitioning schema uses the original HIVE
> {{PARTITIONED BY}} syntax.
> We would like to use CTAS with the new syntax, like:
> {code}
> CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HIVE-26041) Fix wrong type supplied for getLatestCommittedCompaction
[
https://issues.apache.org/jira/browse/HIVE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu-Wen Lai resolved HIVE-26041.
---
Resolution: Fixed
> Fix wrong type supplied for getLatestCommittedCompaction
>
>
> Key: HIVE-26041
> URL: https://issues.apache.org/jira/browse/HIVE-26041
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
>Reporter: Yu-Wen Lai
>Assignee: Yu-Wen Lai
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In HIVE-25753, we filter compactions by CC_ID, but I used string type as the
> parameter for the prepared statement. That cause a type error on some
> databases (at least failed on PostgreSQL).
> To correctly handle the filter, we should use
> {code:java}
> preparedStatement.setLong(...){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HIVE-25980) Reduce fs calls in HiveMetaStoreChecker.checkTable
[
https://issues.apache.org/jira/browse/HIVE-25980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513422#comment-17513422
]
Steve Loughran commented on HIVE-25980:
---
use listStatusIterator for incremental listing, page by page, rather than
blocking to the end. if you can switch to listStatus(recursive=true) then on s3
you avoid the need to mimic a treewalk entirely
> Reduce fs calls in HiveMetaStoreChecker.checkTable
> --
>
> Key: HIVE-25980
> URL: https://issues.apache.org/jira/browse/HIVE-25980
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
>Affects Versions: 3.1.2, 4.0.0
>Reporter: Chiran Ravani
>Assignee: Chiran Ravani
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> MSCK Repair table for high partition table can perform slow on Cloud Storage
> such as S3, one of the case we found where slowness was observed in
> HiveMetaStoreChecker.checkTable.
> {code:java}
> "HiveServer2-Background-Pool: Thread-382" #382 prio=5 os_prio=0
> tid=0x7f97fc4a4000 nid=0x5c2a runnable [0x7f97c41a8000]
>java.lang.Thread.State: RUNNABLE
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
> at java.net.SocketInputStream.read(SocketInputStream.java:171)
> at java.net.SocketInputStream.read(SocketInputStream.java:141)
> at
> sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:464)
> at
> sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:68)
> at
> sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1341)
> at sun.security.ssl.SSLSocketImpl.access$300(SSLSocketImpl.java:73)
> at
> sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:957)
> at
> com.amazonaws.thirdparty.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
> at
> com.amazonaws.thirdparty.apache.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
> at
> com.amazonaws.thirdparty.apache.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
> at
> com.amazonaws.thirdparty.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
> at
> com.amazonaws.thirdparty.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
> at
> com.amazonaws.thirdparty.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
> at
> com.amazonaws.thirdparty.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
> at
> com.amazonaws.thirdparty.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
> at
> com.amazonaws.thirdparty.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
> at
> com.amazonaws.http.protocol.SdkHttpRequestExecutor.doReceiveResponse(SdkHttpRequestExecutor.java:82)
> at
> com.amazonaws.thirdparty.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
> at
> com.amazonaws.thirdparty.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
> at
> com.amazonaws.thirdparty.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
> at
> com.amazonaws.thirdparty.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
> at
> com.amazonaws.thirdparty.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
> at
> com.amazonaws.thirdparty.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
> at
> com.amazonaws.http.apache.client.impl.SdkHttpClient.execute(SdkHttpClient.java:72)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1331)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1145)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:802)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:770)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:744)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:704)
> at
> com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:686)
> at
>
[jira] [Updated] (HIVE-26077) Implement CTAS for Iceberg tables with partition spec
[
https://issues.apache.org/jira/browse/HIVE-26077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HIVE-26077:
--
Labels: pull-request-available (was: )
> Implement CTAS for Iceberg tables with partition spec
> -
>
> Key: HIVE-26077
> URL: https://issues.apache.org/jira/browse/HIVE-26077
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We enabled CTAS for Iceberg tables, but currently only for unpartitioned
> tables and tables where the partitioning schema uses the original HIVE
> {{PARTITIONED BY}} syntax.
> We would like to use CTAS with the new syntax, like:
> {code}
> CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-26077) Implement CTAS for Iceberg tables with partition spec
[
https://issues.apache.org/jira/browse/HIVE-26077?focusedWorklogId=748585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748585
]
ASF GitHub Bot logged work on HIVE-26077:
-
Author: ASF GitHub Bot
Created on: 28/Mar/22 13:00
Start Date: 28/Mar/22 13:00
Worklog Time Spent: 10m
Work Description: pvary opened a new pull request #3147:
URL: https://github.com/apache/hive/pull/3147
### What changes were proposed in this pull request?
Implements the following query:
```
CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
```
### Why are the changes needed?
We need to have a way to create a table with the spec
### Does this PR introduce _any_ user-facing change?
Implements a new syntax
### How was this patch tested?
New unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 748585)
Remaining Estimate: 0h
Time Spent: 10m
> Implement CTAS for Iceberg tables with partition spec
> -
>
> Key: HIVE-26077
> URL: https://issues.apache.org/jira/browse/HIVE-26077
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We enabled CTAS for Iceberg tables, but currently only for unpartitioned
> tables and tables where the partitioning schema uses the original HIVE
> {{PARTITIONED BY}} syntax.
> We would like to use CTAS with the new syntax, like:
> {code}
> CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HIVE-25977) Enhance Compaction Cleaner to skip when there is nothing to do #2
[ https://issues.apache.org/jira/browse/HIVE-25977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denys Kuzmenko resolved HIVE-25977. --- Resolution: Fixed > Enhance Compaction Cleaner to skip when there is nothing to do #2 > - > > Key: HIVE-25977 > URL: https://issues.apache.org/jira/browse/HIVE-25977 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > initially this was just an addendum to the original patch ; but got delayed > and altered - so it should have its own ticket -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HIVE-25977) Enhance Compaction Cleaner to skip when there is nothing to do #2
[ https://issues.apache.org/jira/browse/HIVE-25977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513352#comment-17513352 ] Denys Kuzmenko commented on HIVE-25977: --- Merged addendum. [~klcopp], thank you for the review! > Enhance Compaction Cleaner to skip when there is nothing to do #2 > - > > Key: HIVE-25977 > URL: https://issues.apache.org/jira/browse/HIVE-25977 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > initially this was just an addendum to the original patch ; but got delayed > and altered - so it should have its own ticket -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25977) Enhance Compaction Cleaner to skip when there is nothing to do #2
[ https://issues.apache.org/jira/browse/HIVE-25977?focusedWorklogId=748572=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748572 ] ASF GitHub Bot logged work on HIVE-25977: - Author: ASF GitHub Bot Created on: 28/Mar/22 12:39 Start Date: 28/Mar/22 12:39 Worklog Time Spent: 10m Work Description: deniskuzZ merged pull request #3102: URL: https://github.com/apache/hive/pull/3102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 748572) Time Spent: 3h 10m (was: 3h) > Enhance Compaction Cleaner to skip when there is nothing to do #2 > - > > Key: HIVE-25977 > URL: https://issues.apache.org/jira/browse/HIVE-25977 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > initially this was just an addendum to the original patch ; but got delayed > and altered - so it should have its own ticket -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HIVE-26075) hive metastore connection leaking when hiveserver2 kerberos enable and hive.server2.enable.doAs set to true
[ https://issues.apache.org/jira/browse/HIVE-26075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513341#comment-17513341 ] Stamatis Zampetakis commented on HIVE-26075: [~liuguanghua] Which Hive version are you using? Is the problem reproducible in master? Keep in mind that contributions are now done via pull requests on GitHub (https://github.com/apache/hive/pulls). > hive metastore connection leaking when hiveserver2 kerberos enable and > hive.server2.enable.doAs set to true > > > Key: HIVE-26075 > URL: https://issues.apache.org/jira/browse/HIVE-26075 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: liuguanghua >Assignee: liuguanghua >Priority: Major > Attachments: HIVE-26075.patch > > > (1)When hadoop cluster kerberos is enable > (2) HiveServer2 config hive.server2.enable.doAs is set true > After a beeline scripte has been executed, hivemetastore connection is > created are in ESTABLISHED state and never closed. > If we submit a lot of task to hiveserver2 ,this will result in hive metastore > thrift thread(default is 1000) full ,thus new task will fail. > > HiveServer2 use ThreadLocal to store multithreading metastore > connection,the application should call Hive.closeCurrent() to close > connection after task finished. > > When HiveServer2 impersonate is enable (hive.server2.enable.doAs is set > true), the ugi will create proxy user via > UserGroupInformation.createProxyUser( > owner, UserGroupInformation.getLoginUser()),the old metastore client is never > closed. > > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-26064) For Iceberg external table do not set external.table.purge=true by default
[
https://issues.apache.org/jira/browse/HIVE-26064?focusedWorklogId=748488=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748488
]
ASF GitHub Bot logged work on HIVE-26064:
-
Author: ASF GitHub Bot
Created on: 28/Mar/22 08:51
Start Date: 28/Mar/22 08:51
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #3132:
URL: https://github.com/apache/hive/pull/3132#discussion_r836194268
##
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##
@@ -1052,6 +1053,47 @@ public void testDropTableWithAppendedData() throws
IOException {
shell.executeStatement("DROP TABLE customers");
}
+ @Test
+ public void testDropTableWithoutPurge() throws IOException {
+TableIdentifier identifier = TableIdentifier.of("default", "customers");
+
+shell.executeStatement("CREATE EXTERNAL TABLE customers (" +
+"t_int INT, " +
+"t_string STRING) " +
+"STORED BY ICEBERG " +
+testTables.locationForCreateTableSQL(identifier) +
+
testTables.propertiesForCreateTableSQL(ImmutableMap.of(InputFormatConfig.EXTERNAL_TABLE_PURGE,
"FALSE")));
Review comment:
How about running this test without adding the purge=false flag
explicitly? Explicitly adding it with FALSE will circumvent the MetaHook
behaviour for the default case where the purge flag is simply omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 748488)
Time Spent: 20m (was: 10m)
> For Iceberg external table do not set external.table.purge=true by default
> --
>
> Key: HIVE-26064
> URL: https://issues.apache.org/jira/browse/HIVE-26064
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When creating an Iceberg table, in the MetaHook we currently set
> external.table.purge=true for all tables, unless provided otherwise.
> This goes against the docs / user expectations:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=82706445#:~:text=When%20dropping%20an%20EXTERNAL%20table%2C%20data%20in%20the%20table%20is%20NOT%20deleted%20from%20the%20file%20system
> As well as this property: hive.external.table.purge.default, which is set to
> false in the system.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HIVE-26061) Do not add 'from deserializer' comment upon alter commands for Iceberg tables
[ https://issues.apache.org/jira/browse/HIVE-26061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary resolved HIVE-26061. --- Fix Version/s: 4.0.0 Resolution: Fixed Pushed to master. Thanks for the review [~Marton Bod] > Do not add 'from deserializer' comment upon alter commands for Iceberg tables > - > > Key: HIVE-26061 > URL: https://issues.apache.org/jira/browse/HIVE-26061 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently an ALTER TABLE command for Iceberg tables adds the 'from > deserializer' comment to all columns which do not already have a comment. > This becomes annoying when issueing REPLACE COLUMNS operations, where you > have to write out all these superflous comments. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-26061) Do not add 'from deserializer' comment upon alter commands for Iceberg tables
[ https://issues.apache.org/jira/browse/HIVE-26061?focusedWorklogId=748468=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748468 ] ASF GitHub Bot logged work on HIVE-26061: - Author: ASF GitHub Bot Created on: 28/Mar/22 07:52 Start Date: 28/Mar/22 07:52 Worklog Time Spent: 10m Work Description: pvary merged pull request #3129: URL: https://github.com/apache/hive/pull/3129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 748468) Time Spent: 1h 20m (was: 1h 10m) > Do not add 'from deserializer' comment upon alter commands for Iceberg tables > - > > Key: HIVE-26061 > URL: https://issues.apache.org/jira/browse/HIVE-26061 > Project: Hive > Issue Type: Bug >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently an ALTER TABLE command for Iceberg tables adds the 'from > deserializer' comment to all columns which do not already have a comment. > This becomes annoying when issueing REPLACE COLUMNS operations, where you > have to write out all these superflous comments. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-26079) Upgrade protobuf to 3.16.1
[
https://issues.apache.org/jira/browse/HIVE-26079?focusedWorklogId=748442=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748442
]
ASF GitHub Bot logged work on HIVE-26079:
-
Author: ASF GitHub Bot
Created on: 28/Mar/22 06:40
Start Date: 28/Mar/22 06:40
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #3144:
URL: https://github.com/apache/hive/pull/3144#discussion_r836096416
##
File path:
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestPutResultWritable.java
##
@@ -50,6 +51,7 @@ public void testResult() throws Exception {
}
@Test
+ @Ignore
Review comment:
it failing because old version of protobuf is getting fetched via Hbase
dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 748442)
Time Spent: 0.5h (was: 20m)
> Upgrade protobuf to 3.16.1
> --
>
> Key: HIVE-26079
> URL: https://issues.apache.org/jira/browse/HIVE-26079
> Project: Hive
> Issue Type: Task
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Upgrade com.google.protobuf:protobuf-java from 2.5.0 to 3.16.1 to fix
> CVE-2021-22569
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
