[jira] [Comment Edited] (HIVE-14772) NPE when MSCK REPAIR
[
https://issues.apache.org/jira/browse/HIVE-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531953#comment-15531953
]
Per Ullberg edited comment on HIVE-14772 at 9/29/16 6:36 AM:
-
[~alunarbeach] Not really, the NPE is already worked around with a boolean
before that commit. Ugly!
But using a set should probably remove the NPE so applying what you link to
should do the trick I guess.
was (Author: hiverunner@github):
[~alunarbeach] Not really, the NPE is already worked around with a boolean
before that commit. Ugly!
> NPE when MSCK REPAIR
>
>
> Key: HIVE-14772
> URL: https://issues.apache.org/jira/browse/HIVE-14772
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 2.1.0
> Environment: HiveRunner on OSX Yosemite
>Reporter: Per Ullberg
>
> HiveMetaStoreChecker throws NullPointerException when doing a MSCK REPAIR
> TABLE.
> The bug is here:
> {code}
> ...
> 18 package org.apache.hadoop.hive.ql.metadata;
> ...
> 58 public class HiveMetaStoreChecker {
> ...
> 408if (!directoryFound) {
> 409 allDirs.put(path, null);
> 410}
> ...
> {code}
> allDirs is a ConcurrentHashMap and those does not allow either key or value
> to be null.
> I found the bug while trying to port https://github.com/klarna/HiveRunner to
> Hive 2.1.0
> Implemented explicit test case that exposes the bug here:
> https://github.com/klarna/HiveRunner/blob/hive-2.1.0-NPE-at-msck-repair/src/test/java/com/klarna/hiverunner/MSCKRepairNPE.java
> Reproduce by cloning branch
> https://github.com/klarna/HiveRunner/tree/hive-2.1.0-NPE-at-msck-repair
> and run
> {code} mvn -Dtest=MSCKRepairNPE clean test{code}
> ( Does not work on windows :( )
> Looks like this email thread talks about the same issue:
> http://user.hive.apache.narkive.com/ETOpbKk5/msck-repair-table-and-hive-v2-1-0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14772) NPE when MSCK REPAIR
[
https://issues.apache.org/jira/browse/HIVE-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531953#comment-15531953
]
Per Ullberg commented on HIVE-14772:
[~alunarbeach] Not really, the NPE is already worked around with a boolean
before that commit. Ugly!
> NPE when MSCK REPAIR
>
>
> Key: HIVE-14772
> URL: https://issues.apache.org/jira/browse/HIVE-14772
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 2.1.0
> Environment: HiveRunner on OSX Yosemite
>Reporter: Per Ullberg
>
> HiveMetaStoreChecker throws NullPointerException when doing a MSCK REPAIR
> TABLE.
> The bug is here:
> {code}
> ...
> 18 package org.apache.hadoop.hive.ql.metadata;
> ...
> 58 public class HiveMetaStoreChecker {
> ...
> 408if (!directoryFound) {
> 409 allDirs.put(path, null);
> 410}
> ...
> {code}
> allDirs is a ConcurrentHashMap and those does not allow either key or value
> to be null.
> I found the bug while trying to port https://github.com/klarna/HiveRunner to
> Hive 2.1.0
> Implemented explicit test case that exposes the bug here:
> https://github.com/klarna/HiveRunner/blob/hive-2.1.0-NPE-at-msck-repair/src/test/java/com/klarna/hiverunner/MSCKRepairNPE.java
> Reproduce by cloning branch
> https://github.com/klarna/HiveRunner/tree/hive-2.1.0-NPE-at-msck-repair
> and run
> {code} mvn -Dtest=MSCKRepairNPE clean test{code}
> ( Does not work on windows :( )
> Looks like this email thread talks about the same issue:
> http://user.hive.apache.narkive.com/ETOpbKk5/msck-repair-table-and-hive-v2-1-0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-3296) comments before a set statement in a test do not work
[
https://issues.apache.org/jira/browse/HIVE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492104#comment-14492104
]
Per Ullberg commented on HIVE-3296:
---
This also fails in the Cli so it's not isolated to the Testing Infrastructure.
{code}
hive
-- this is a comment
select * from some_table limit 1;
OK
...
hive
-- this is another comment
set foo=bar;
NoViableAltException(213@[])
at
org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:900)
at
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:190)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:435)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:353)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:979)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1022)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:915)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:905)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:259)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:216)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:413)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:781)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.main(RunJar.java:208)
FAILED: ParseException line 2:0 cannot recognize input near 'set' 'foo' '='
{code}
Running CDH5beta1-Packaging-Hive-2013-10-27_18-38-32/hive-0.11.0-cdh5.0.0-beta-1
comments before a set statement in a test do not work
-
Key: HIVE-3296
URL: https://issues.apache.org/jira/browse/HIVE-3296
Project: Hive
Issue Type: Bug
Components: Testing Infrastructure
Reporter: Namit Jain
Assignee: Srinivas Vemuri
The following test fails:::
-- test comment
set hive.test=foo;
create table tst(key string);
The output is::
FAILED: ParseException line 2:0 cannot recognize input near 'set' 'hive' '.'
However, if the comment position is changed it works fine.
The following test:
-- test comment
create table tst(key string);
set hive.test=foo;
works fine
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
