[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Saijin Huang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970609#comment-15970609
 ] 

Saijin Huang commented on HIVE-15442:
-

hi,Aihua Xu can you  take a quick commit?

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Saijin Huang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966943#comment-15966943
 ] 

Saijin Huang commented on HIVE-15442:
-

hi,[~aihuaxu] can you plz take a commit?

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Aihua Xu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964377#comment-15964377
 ] 

Aihua Xu commented on HIVE-15442:
-

Yeah. It does look redundant. 

+1. I will need to commit your change after 1 day. 

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964227#comment-15964227
 ] 

Hive QA commented on HIVE-15442:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862800/HIVE-15442.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10570 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=143)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4639/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4639/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4639/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12862800 - PreCommit-HIVE-Build

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Saijin Huang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964171#comment-15964171
 ] 

Saijin Huang commented on HIVE-15442:
-

hello,[~aihuaxu] ,i have opened a pull request.Can you take a quick review and 
merge it?

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964160#comment-15964160
 ] 

ASF GitHub Bot commented on HIVE-15442:
---

GitHub user txhsj opened a pull request:

https://github.com/apache/hive/pull/169

HIVE-15442:Driver.java has a redundancy code

Driver.java has a redundancy code about "explain output", i think the if 
statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
repeat judge with the above statement.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/txhsj/hive master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #169


commit 24f38ceb34c2663197abfdadbd22c73a257e4a98
Author: 黄赛金10202350 
Date:   2017-04-11T10:40:51Z

HIVE-15442:Driver.java has a redundancy code




> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
>Priority: Minor
> Attachments: HIVE-15442.1.patch
>
>
> Driver.java has a  redundancy  code about "explain output", i think the if 
> statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a 
> repeat judge with the above statement. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15442) Driver.java has a redundancy code

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753737#comment-15753737
 ] 

Hive QA commented on HIVE-15442:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12843543/HIVE-15442.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10818 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=234)
TestVectorizedColumnReaderBase - did not produce a TEST-*.xml file (likely 
timed out) (batchId=251)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sort_array] 
(batchId=59)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] 
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadataonly1]
 (batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_based_fetch_decision]
 (batchId=151)
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery 
(batchId=216)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2605/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2605/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2605/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12843543 - PreCommit-HIVE-Build

> Driver.java has a redundancy  code
> --
>
> Key: HIVE-15442
> URL: https://issues.apache.org/jira/browse/HIVE-15442
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: Gold huang
>Assignee: Gold huang
>Priority: Minor
> Attachments: HIVE-15442.patch
>
>
> Driver.java has a  redundancy  code,i think the third if statement could be 
> remved.
> if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) {
> String explainOutput = getExplainOutput(sem, plan, tree.dump());
> if (explainOutput != null) {
>   if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) {
> LOG.info("EXPLAIN output for queryid " + queryId + " : " + 
> explainOutput);
>   }
>   if (conf.isWebUiQueryInfoCacheEnabled()) {
> queryDisplay.setExplainPlan(explainOutput);
>   }
> }
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)