[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-13 Thread Prasanth Jayachandran (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397774#comment-16397774
 ] 

Prasanth Jayachandran commented on HIVE-18933:
--

ok. make sense. +1

> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-13 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397649#comment-16397649
 ] 

Sergey Shelukhin commented on HIVE-18933:
-

That is one thing that it's doing. It's also removing clone calls. I'm not sure 
why they are needed... seems error prone to clone an object with IO stream and 
codec via Java shallow clone without explicitly accounting for things being 
duplicated. 

> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-13 Thread Prasanth Jayachandran (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397603#comment-16397603
 ] 

Prasanth Jayachandran commented on HIVE-18933:
--

Is this patch is just removing references to codec object (delegating the 
cleanup to parent data reader)?

> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-13 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397564#comment-16397564
 ] 

Sergey Shelukhin commented on HIVE-18933:
-

Negative tests OOMed as usual. [~prasanth_j] can you take a look?

> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-12 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396483#comment-16396483
 ] 

Hive QA commented on HIVE-18933:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} The patch common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} llap-server: The patch generated 0 new + 33 
unchanged - 3 fixed = 33 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 12s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9612/dev-support/hive-personality.sh
 |
| git revision | master / 12041d3 |
| Default Java | 1.8.0_111 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9612/yetus/patch-asflicense-problems.txt
 |
| modules | C: common llap-server U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9612/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18933) disable ORC codec pool for now; remove clone

2018-03-12 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396313#comment-16396313
 ] 

Sergey Shelukhin commented on HIVE-18933:
-

[~prasanth_j] can you take a look?

cc [~owen.omalley] I'm not sure why these clone calls were added.

> disable ORC codec pool for now; remove clone
> 
>
> Key: HIVE-18933
> URL: https://issues.apache.org/jira/browse/HIVE-18933
> Project: Hive
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HIVE-18933.patch
>
>
> See ORC-310.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)