[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469003#comment-16469003
]
Matt McCline commented on HIVE-19448:
-
Committed patch #2 to master and branch-3. [~djaiswal] thank you for your code
review!
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch, HIVE-19448.02.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468987#comment-16468987
]
Hive QA commented on HIVE-19448:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12922478/HIVE-19448.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 45 failed/errored test(s), 13543 tests
executed
*Failed tests:*
{noformat}
TestDbNotificationListener - did not produce a TEST-*.xml file (likely timed
out) (batchId=247)
TestHCatHiveCompatibility - did not produce a TEST-*.xml file (likely timed
out) (batchId=247)
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=95)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468968#comment-16468968
]
Matt McCline commented on HIVE-19448:
-
The JDBC SerDe seems to return Strings instead of ints, booleans, etc, by
design. I don't understand why and I don't think it is an important case.
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468963#comment-16468963
]
Gunther Hagleitner commented on HIVE-19448:
---
[~djaiswal] [~mmccline] what about fixing the jdbc serde instead of just
disabling it?
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468916#comment-16468916
]
Hive QA commented on HIVE-19448:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
28s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
49s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} common: The patch generated 1 new + 427 unchanged - 0
fixed = 428 total (was 427) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} ql: The patch generated 6 new + 71 unchanged - 1 fixed
= 77 total (was 72) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10782/dev-support/hive-personality.sh
|
| git revision | master / 99a2b8b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10782/yetus/diff-checkstyle-common.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10782/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10782/yetus/patch-asflicense-problems.txt
|
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10782/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
>
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468299#comment-16468299
]
Matt McCline commented on HIVE-19448:
-
#10782
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467965#comment-16467965
]
Deepak Jaiswal commented on HIVE-19448:
---
Looks good to me.
+1 pending test results.
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467549#comment-16467549
]
Matt McCline commented on HIVE-19448:
-
Messed up creating the patch (forgot to commit change first).
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19448) Vectorization: sysdb test doesn't work after enabling vectorization by default
[
https://issues.apache.org/jira/browse/HIVE-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467535#comment-16467535
]
Gunther Hagleitner commented on HIVE-19448:
---
Are all these Yetus changes needed for this patch? If it's just the wrong
return type for the jdbc handler - is it possible to just fix that?
> Vectorization: sysdb test doesn't work after enabling vectorization by default
> --
>
> Key: HIVE-19448
> URL: https://issues.apache.org/jira/browse/HIVE-19448
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19448.01.patch
>
>
> Solution: EXCLUDE org.apache.hive.storage.jdbc.JdbcInputFormat which returns
> String for boolean.
> {noformat}
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Boolean
> at
> org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaBooleanObjectInspector.getPrimitiveWritableObject(JavaBooleanObjectInspector.java:36)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:434)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:347)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:948){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
